Hi, maybe I was to quick to ack this, is the change at line 565 correct? Don't you have to create an array of SaCkptIOVectorElements? /HansN
-----Original Message----- From: Hans Feldt Sent: den 21 oktober 2013 12:36 To: Hans Nordebäck; Carl Johannesson Cc: opensaf-devel@lists.sourceforge.net Subject: RE: [devel] [PATCH 1 of 1] saf/pyosaf: methods incorrectly specified in saCkpt.py [590] Please change the commit message to something reasonable. /Hans > -----Original Message----- > From: Hans Nordebäck [mailto:hans.nordeb...@ericsson.com] > Sent: den 21 oktober 2013 12:08 > To: Carl Johannesson > Cc: opensaf-devel@lists.sourceforge.net > Subject: Re: [devel] [PATCH 1 of 1] saf/pyosaf: methods incorrectly > specified in saCkpt.py [590] > > Ack, I'll push the changes./BR HansN > > -----Original Message----- > From: Carl Johannesson > Sent: den 10 oktober 2013 10:34 > To: Hans Nordebäck > Cc: opensaf-devel@lists.sourceforge.net > Subject: [PATCH 1 of 1] saf/pyosaf: methods incorrectly specified in > saCkpt.py [590] > > python/pyosaf/saCkpt.py | 12 ++++++------ > 1 files changed, 6 insertions(+), 6 deletions(-) > > > The saCkptCheckpointWrite() and saCkptCheckpointRead() methods are > incorrectly declared, making it impossible to write/read to/from a checkpoint. > > diff --git a/python/pyosaf/saCkpt.py b/python/pyosaf/saCkpt.py > --- a/python/pyosaf/saCkpt.py > +++ b/python/pyosaf/saCkpt.py > @@ -555,7 +555,7 @@ def saCkptCheckpointWrite(checkpointHand > > type arguments: > SaCkptCheckpointHandleT checkpointHandle > - createSaCkptIOVector ioVector > + SaCkptIOVectorElementT* ioVector > SaUint32T numberOfElements > SaUint32T erroneousVectorIndex > > @@ -565,7 +565,7 @@ def saCkptCheckpointWrite(checkpointHand > """ > ckptdll.saCkptCheckpointWrite.argtypes = [ > SaCkptCheckpointHandleT, > - createSaCkptIOVector, > + POINTER(SaCkptIOVectorElementT), > SaUint32T, > POINTER(SaUint32T) > ] > @@ -573,7 +573,7 @@ def saCkptCheckpointWrite(checkpointHand > ckptdll.saCkptCheckpointWrite.restype = SaAisErrorT > > return ckptdll.saCkptCheckpointWrite(checkpointHandle, > - ioVector, > + BYREF(ioVector), > numberOfElements, > BYREF(erroneousVectorIndex)) > > @@ -617,7 +617,7 @@ def saCkptCheckpointRead(checkpointHandl > > type arguments: > SaCkptCheckpointHandleT checkpointHandle > - createSaCkptIOVector ioVector > + SaCkptIOVectorElementT* ioVector > SaUint32T numberOfElements > SaUint32T erroneousVectorIndex > > @@ -627,14 +627,14 @@ def saCkptCheckpointRead(checkpointHandl > """ > ckptdll.saCkptCheckpointRead.argtypes = [ > SaCkptCheckpointHandleT, > - createSaCkptIOVector, > + POINTER(SaCkptIOVectorElementT), > SaUint32T, > POINTER(SaUint32T) > ] > ckptdll.saCkptCheckpointRead.restype = SaAisErrorT > > return ckptdll.saCkptCheckpointRead(checkpointHandle, > - ioVector, > + BYREF(ioVector), > numberOfElements, > BYREF(erroneousVectorIndex)) > > > ---------------------------------------------------------------------- > -------- October Webinars: Code for Performance Free Intel webinars > can help you accelerate application performance. > Explore tips for MPI, OpenMP, advanced profiling, and more. Get the > most from the latest Intel processors and coprocessors. See abstracts > and register > > http://pubads.g.doubleclick.net/gampad/clk?id=60135031&iu=/4140/ostg.c > lktrk _______________________________________________ > Opensaf-devel mailing list > Opensaf-devel@lists.sourceforge.net > https://lists.sourceforge.net/lists/listinfo/opensaf-devel ------------------------------------------------------------------------------ October Webinars: Code for Performance Free Intel webinars can help you accelerate application performance. Explore tips for MPI, OpenMP, advanced profiling, and more. Get the most from the latest Intel processors and coprocessors. See abstracts and register > http://pubads.g.doubleclick.net/gampad/clk?id=60135031&iu=/4140/ostg.clktrk _______________________________________________ Opensaf-devel mailing list Opensaf-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/opensaf-devel
