Ramesh,

Thanks for the review .

1)   `$pkglocalstatedir/osaf_dtm_intra_server` file will be created only 
TCP case  , it is not required   for TIPC.

2)  Before fixing Ticket #1993   MDS library also use to bind() and  MDS 
library also use to create  Unix sock file prefixing with application PID
       `$pkglocalstatedir/osaf_mdtm_process_<PID>` , it is not required  
now , I will remove that like  while pushing .


- AVM


Mds/tcp : Removed bind() in the MDS library( client side ) which is not 
required (#1993)

On 10/24/2013 1:40 PM, Ramesh Betham wrote:
> Few comments:
>
> +        rm -f $pkglocalstatedir/osaf_mdtm_process_*
>
> Where this "osaf_mdtm_process_*" file is getting created?, I did not 
> see reference of this file in OpenSAF code. Please check.
>
> Also what about cleaning of the following file in TIPC case.
>
> +    rm -f $pkglocalstatedir/osaf_dtm_intra_server
>
>
> Thanks,
> Ramesh.
>
> On 10/24/2013 10:41 AM, [email protected] wrote:
>> osaf/services/infrastructure/nid/scripts/opensafd.in |  4 ++--
>>   1 files changed, 2 insertions(+), 2 deletions(-)
>>
>>
>> diff --git a/osaf/services/infrastructure/nid/scripts/opensafd.in 
>> b/osaf/services/infrastructure/nid/scripts/opensafd.in
>> --- a/osaf/services/infrastructure/nid/scripts/opensafd.in
>> +++ b/osaf/services/infrastructure/nid/scripts/opensafd.in
>> @@ -128,8 +128,8 @@ final_clean() {
>>       else
>>           # stop dtm, now all dependent services should be stopped
>>           $pkgclcclidir/osaf-dtm stop >/dev/null 2>&1
>> -        rm -f /tmp/osaf_dtm_intra_server
>> -        rm -f /tmp/osaf_mdtm_process_*
>> +        rm -f $pkglocalstatedir/osaf_dtm_intra_server
>> +        rm -f $pkglocalstatedir/osaf_mdtm_process_*
>>       fi
>>         clean_shm
>


------------------------------------------------------------------------------
October Webinars: Code for Performance
Free Intel webinars can help you accelerate application performance.
Explore tips for MPI, OpenMP, advanced profiling, and more. Get the most from 
the latest Intel processors and coprocessors. See abstracts and register >
http://pubads.g.doubleclick.net/gampad/clk?id=60135991&iu=/4140/ostg.clktrk
_______________________________________________
Opensaf-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/opensaf-devel

Reply via email to