Hi, Ack with these minor comments: - report_ccb_validation_error sounds like a better name than report_oi_error - in report_oi_error vsnprintf should use sizeof(err_str) - in report_oi_error add explicit null termination because I am sure some analysis tools will complain otherwise: err_str[sizeof(err_str) - 1] = 0; - in report_oi_error change LOG_ER to LOG_WA or LOG_NO, error logs should be reserved for errors in the service, this log is about config errors which is something else
Thanks, Hans On 24 October 2013 13:04, <[email protected]> wrote: > osaf/services/saf/amf/amfd/app.cc | 10 +- > osaf/services/saf/amf/amfd/apptype.cc | 13 +- > osaf/services/saf/amf/amfd/cluster.cc | 6 +- > osaf/services/saf/amf/amfd/comp.cc | 105 > ++++++++++++++++---------- > osaf/services/saf/amf/amfd/compcstype.cc | 18 ++-- > osaf/services/saf/amf/amfd/comptype.cc | 46 ++++++---- > osaf/services/saf/amf/amfd/csi.cc | 62 +++++++++------ > osaf/services/saf/amf/amfd/csiattr.cc | 32 ++++--- > osaf/services/saf/amf/amfd/cstype.cc | 14 +- > osaf/services/saf/amf/amfd/ctcstype.cc | 10 +- > osaf/services/saf/amf/amfd/hlt.cc | 11 +- > osaf/services/saf/amf/amfd/hlttype.cc | 2 +- > osaf/services/saf/amf/amfd/imm.cc | 23 +++++ > osaf/services/saf/amf/amfd/include/imm.h | 2 + > osaf/services/saf/amf/amfd/node.cc | 33 ++++--- > osaf/services/saf/amf/amfd/nodegroup.cc | 34 ++++--- > osaf/services/saf/amf/amfd/nodeswbundle.cc | 22 ++-- > osaf/services/saf/amf/amfd/sg.cc | 43 ++++++---- > osaf/services/saf/amf/amfd/sgtype.cc | 27 +++--- > osaf/services/saf/amf/amfd/si.cc | 36 ++++---- > osaf/services/saf/amf/amfd/si_dep.cc | 36 +++++--- > osaf/services/saf/amf/amfd/sirankedsu.cc | 12 +- > osaf/services/saf/amf/amfd/su.cc | 80 +++++++++++--------- > osaf/services/saf/amf/amfd/sutcomptype.cc | 2 +- > osaf/services/saf/amf/amfd/sutype.cc | 24 +++--- > osaf/services/saf/amf/amfd/svctype.cc | 8 +- > osaf/services/saf/amf/amfd/svctypecstypes.cc | 2 +- > osaf/services/saf/amf/amfnd/mbcsv.cc | 2 +- > 28 files changed, 414 insertions(+), 301 deletions(-) > > ------------------------------------------------------------------------------ October Webinars: Code for Performance Free Intel webinars can help you accelerate application performance. Explore tips for MPI, OpenMP, advanced profiling, and more. Get the most from the latest Intel processors and coprocessors. See abstracts and register > http://pubads.g.doubleclick.net/gampad/clk?id=60135991&iu=/4140/ostg.clktrk _______________________________________________ Opensaf-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/opensaf-devel
