Please see inline.

Thanks
Praveen
On 31-Oct-13 1:43 PM, Hans Feldt wrote:
>   osaf/services/saf/amf/amfd/imm.cc |  32 ++++++++++++++++++--------------
>   1 files changed, 18 insertions(+), 14 deletions(-)
>
>
> Trivial change, move a code block so that it saflog also for base entity 
> types.
>
> diff --git a/osaf/services/saf/amf/amfd/imm.cc 
> b/osaf/services/saf/amf/amfd/imm.cc
> --- a/osaf/services/saf/amf/amfd/imm.cc
> +++ b/osaf/services/saf/amf/amfd/imm.cc
> @@ -886,21 +886,25 @@ static void ccb_apply_cb(SaImmOiHandleT
>                        * AMFD's information model
>                        */
>                       ccb_insert_ordered_list(ccb_apply_callback[type], 
> opdata, type);
> +             }
>   
> -                     if (avd_cb->avail_state_avd != SA_AMF_HA_ACTIVE) {
All saflogging should be done on Active controller.

> -                             switch (opdata->operationType) {
> -                             case CCBUTIL_CREATE:
> -                                     saflog(LOG_NOTICE, amfSvcUsrName, "CCB 
> %llu Created %s", ccb_id, opdata->objectName.value);
> -                                     break;
> -                             case CCBUTIL_MODIFY:
> -                                     saflog(LOG_NOTICE, amfSvcUsrName, "CCB 
> %llu Modified %s", ccb_id, opdata->objectName.value);
> -                                     break;
> -                             case CCBUTIL_DELETE:
> -                                     saflog(LOG_NOTICE, amfSvcUsrName, "CCB 
> %llu Deleted %s", ccb_id, opdata->objectName.value);
> -                                     break;
> -                             default:
> -                                     osafassert(0);
> -                             }
> +             // SAF LOG all changes
> +             if (avd_cb->avail_state_avd != SA_AMF_HA_ACTIVE) {
> +                     switch (opdata->operationType) {
> +                     case CCBUTIL_CREATE:
> +                             saflog(LOG_NOTICE, amfSvcUsrName, "CCB %llu 
> Created %s",
> +                                             ccb_id, 
> opdata->objectName.value);
> +                             break;
> +                     case CCBUTIL_MODIFY:
> +                             saflog(LOG_NOTICE, amfSvcUsrName, "CCB %llu 
> Modified %s",
> +                                             ccb_id, 
> opdata->objectName.value);
> +                             break;
> +                     case CCBUTIL_DELETE:
> +                             saflog(LOG_NOTICE, amfSvcUsrName, "CCB %llu 
> Deleted %s",
> +                                             ccb_id, 
> opdata->objectName.value);
> +                             break;
> +                     default:
> +                             osafassert(0);
>                       }
>               }
>       }


------------------------------------------------------------------------------
Android is increasing in popularity, but the open development platform that
developers love is also attractive to malware creators. Download this white
paper to learn more about secure code signing practices that can help keep
Android apps secure.
http://pubads.g.doubleclick.net/gampad/clk?id=65839951&iu=/4140/ostg.clktrk
_______________________________________________
Opensaf-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/opensaf-devel

Reply via email to