Hi AndersBj, Reviewed and tested the patch. Ack.
/Neel. On Tuesday 05 November 2013 12:18 PM, Anders Bjornerstedt wrote: > Summary: IMM: Support for 'immadm -a (--admin-owner) <admo-name>' [#613] > Review request for Trac Ticket(s): 613 > Peer Reviewer(s): Neel, Zoran > Pull request to: > Affected branch(es): default (4.4) > Development branch: > > -------------------------------- > Impacted area Impact y/n > -------------------------------- > Docs n > Build system n > RPM/packaging n > Configuration files n > Startup scripts n > SAF services y > OpenSAF services n > Core libraries n > Samples n > Tests n > Other n > > Comments (indicate scope for each "y" above): > --------------------------------------------- > > changeset fd1cd7c8d9808b8a11c9cedc5da348c60c234bee > Author: Anders Bjornerstedt <[email protected]> > Date: Tue, 05 Nov 2013 07:10:57 +0100 > > IMM: Support for 'immadm -a (--admin-owner) <admo-name>' [#613] > > Allow user to request immadm to set admin-owner to a specific admin > owner > name. By default, a temprary admin-oener name is allocated by the immadm > commnad. The '-a' argument allows the user to choose the explicit admin- > owner name that shall be set for the object on which the administrative > operation is to be invoked on. This is typically only needed if the > object > already has admin owner set, more or less permanently. Because of this, > no > admin-owner-release will be done by immadm when explicit admin-owner > name is > used. > > Complete diffstat: > ------------------ > osaf/tools/safimm/immadm/imm_admin.c | 22 ++++++++++++++++------ > 1 files changed, 16 insertions(+), 6 deletions(-) > > Testing Commands: > ----------------- > Used for example when requesting 2PBE to enter 1-safe mode. > This would be to open up for allowing CCBs to proceed when one > SC is down in a 2PBE system. > > immadm -o 1 -p opensafImmNostdFlags:SA_UINT32_T:8 \ > -a safImmService opensafImm=opensafImm,safApp=safImmService > > Because the object opensafImm=opensafImm,safApp=safImmService has admin-owner > permanently set to 'safImmService', the user invoking an admin-operation on > this objects needs to set the same admin-owner-name for the handle they use. > Should admin-owner-name later need to be released from the object(s), this may > be done using 'immcfg --admin-owner-clear <object-names>' > > Testing, Expected Results: > -------------------------- > Invoking an admin-operation using an explicitly set admin-owner-name shall be > possible. > > Conditions of Submission: > ------------------------- > Ack from Neel. ------------------------------------------------------------------------------ November Webinars for C, C++, Fortran Developers Accelerate application performance with scalable programming models. Explore techniques for threading, error checking, porting, and tuning. Get the most from the latest Intel processors and coprocessors. See abstracts and register http://pubads.g.doubleclick.net/gampad/clk?id=60136231&iu=/4140/ostg.clktrk _______________________________________________ Opensaf-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/opensaf-devel
