Summary: clm: treat ERR_EXIST as TRY_AGAIN and support a flag for pending
RTupdates [#528]
Review request for Trac Ticket(s): #528
Peer Reviewer(s): ramesh.bet...@oracle.com
Pull request to: <<LIST THE PERSON WITH PUSH ACCESS HERE>>
Affected branch(es): opensaf-4.3.x, default
Development branch: <<IF ANY GIVE THE REPO URL>>
--------------------------------
Impacted area Impact y/n
--------------------------------
Docs n
Build system n
RPM/packaging n
Configuration files n
Startup scripts n
SAF services y
OpenSAF services n
Core libraries n
Samples n
Tests n
Other n
Comments (indicate scope for each "y" above):
---------------------------------------------
changeset fed62b5b3a11ef99877f82cdff4b92222ee2219a
Author: Mathivanan N.P.<mathi.naic...@oracle.com>
Date: Fri, 15 Nov 2013 12:50:25 +0530
clm: treat ERR_EXIST as TRY_AGAIN and support a flag for pending
RTupdates
[#528] ERR_EXIST and TRY_AGAIN are treated the same. Also, a rtu_pending
flag is introduced. The flag is toggled when an IMM API throws a
TRY_AGAIN
or ERR_EXIST and when the call is reattempted later and if the call
succeeds
the flag is turned off.
Complete diffstat:
------------------
osaf/services/saf/clmsv/clms/clms_amf.c | 9 +++-
osaf/services/saf/clmsv/clms/clms_cb.h | 4 +
osaf/services/saf/clmsv/clms/clms_imm.c | 243
+++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++------------
osaf/services/saf/clmsv/clms/clms_imm.h | 3 +
osaf/services/saf/clmsv/clms/clms_main.c | 25 +++++++++-
5 files changed, 252 insertions(+), 32 deletions(-)
Testing Commands:
-----------------
Suite 1
1) Succesful bring up of one node. Verify the output of immlist.
2) Successful bring up of first node, followed by second node. veirfy the
output of immlist.
3) After 2), reboot the second node, verify the output of immlist.
4) Repeat 1) with an error(TRY_AGAIN, TIMEOUT, ERRLIBRARY) in RT update. verify
the output of
immlist.
5) Repeat 2) with an error in RT update on both nodes. Verify the output of
immlist.
6) Repeat 3) with an error in RT update on both nodes. Verify the output of
immlist.
7) Switchover. Verify the output of immlist.
8) Reverse switchover. Verify the output of immlist.
9) Repeat 7) with an error in RT update during switchover. verify immlist
output.
10) Repeat 8) with an error in RT update during switchover. Verify immlist
output.
11) After 3) trigger a failover. verify immlist.
12) Repeat 11) but with an error in RT update
13) After 12) do a switchover.
14) After 13) do a switchover with error in RT update.
Suite 2
Repeat Suite 1 intermixed with implementerset error.
Testing, Expected Results:
--------------------------
During a TRY_AGAIN, TIMEOUT and all other error codes, IMM RT update refresh
should
eventually happen and an immlist of the node and cluster objects should have
the updated information.
Conditions of Submission:
-------------------------
Ack from Ramesh.
Arch Built Started Linux distro
-------------------------------------------
mips n n
mips64 n n
x86 n n
x86_64 y y
powerpc n n
powerpc64 n n
Reviewer Checklist:
-------------------
[Submitters: make sure that your review doesn't trigger any checkmarks!]
Your checkin has not passed review because (see checked entries):
___ Your RR template is generally incomplete; it has too many blank entries
that need proper data filled in.
___ You have failed to nominate the proper persons for review and push.
___ Your patches do not have proper short+long header
___ You have grammar/spelling in your header that is unacceptable.
___ You have exceeded a sensible line length in your headers/comments/text.
___ You have failed to put in a proper Trac Ticket # into your commits.
___ You have incorrectly put/left internal data in your comments/files
(i.e. internal bug tracking tool IDs, product names etc)
___ You have not given any evidence of testing beyond basic build tests.
Demonstrate some level of runtime or other sanity testing.
___ You have ^M present in some of your files. These have to be removed.
___ You have needlessly changed whitespace or added whitespace crimes
like trailing spaces, or spaces before tabs.
___ You have mixed real technical changes with whitespace and other
cosmetic code cleanup changes. These have to be separate commits.
___ You need to refactor your submission into logical chunks; there is
too much content into a single commit.
___ You have extraneous garbage in your review (merge commits etc)
___ You have giant attachments which should never have been sent;
Instead you should place your content in a public tree to be pulled.
___ You have too many commits attached to an e-mail; resend as threaded
commits, or place in a public tree for a pull.
___ You have resent this content multiple times without a clear indication
of what has changed between each re-send.
___ You have failed to adequately and individually address all of the
comments and change requests that were proposed in the initial review.
___ You have a misconfigured ~/.hgrc file (i.e. username, email etc)
___ Your computer have a badly configured date and time; confusing the
the threaded patch review.
___ Your changes affect IPC mechanism, and you don't present any results
for in-service upgradability test.
___ Your changes affect user manual and documentation, your patch series
do not contain the patch that updates the Doxygen manual.
------------------------------------------------------------------------------
DreamFactory - Open Source REST & JSON Services for HTML5 & Native Apps
OAuth, Users, Roles, SQL, NoSQL, BLOB Storage and External API Access
Free app hosting. Or install the open source package on any LAMP server.
Sign up and see examples for AngularJS, jQuery, Sencha Touch and Native!
http://pubads.g.doubleclick.net/gampad/clk?id=63469471&iu=/4140/ostg.clktrk
_______________________________________________
Opensaf-devel mailing list
Opensaf-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/opensaf-devel
