Can I have some feedback?
Right now we have no logging for CCB related validation errors.
Thanks,
Hans
On 11/28/2013 10:24 AM, Hans Feldt wrote:
> osaf/services/saf/amf/amfd/cluster.cc | 2 +-
> osaf/services/saf/amf/amfd/imm.cc | 14 ++++++++++----
> 2 files changed, 11 insertions(+), 5 deletions(-)
>
>
> diff --git a/osaf/services/saf/amf/amfd/cluster.cc
> b/osaf/services/saf/amf/amfd/cluster.cc
> --- a/osaf/services/saf/amf/amfd/cluster.cc
> +++ b/osaf/services/saf/amf/amfd/cluster.cc
> @@ -118,7 +118,7 @@ static SaAisErrorT ccb_completed_modify_
> SaTimeT cluster_startup_timeout = *((SaTimeT
> *)attr_mod->modAttr.attrValues[0]);
> if (0 == cluster_startup_timeout) {
> report_ccb_validation_error(opdata, "Invalid
> saAmfClusterStartupTimeout %llu",
> -
> avd_cluster->saAmfClusterStartupTimeout);
> + cluster_startup_timeout);
> rc = SA_AIS_ERR_BAD_OPERATION;
> goto done;
> }
> diff --git a/osaf/services/saf/amf/amfd/imm.cc
> b/osaf/services/saf/amf/amfd/imm.cc
> --- a/osaf/services/saf/amf/amfd/imm.cc
> +++ b/osaf/services/saf/amf/amfd/imm.cc
> @@ -1792,12 +1792,18 @@ void report_ccb_validation_error(const C
> va_start(ap, format);
> (void) vsnprintf(err_str, sizeof(err_str), format, ap);
> va_end(ap);
> - TRACE("%s", err_str);
> - if (opdata != NULL)
> +
> + if (opdata != NULL) {
> + TRACE("%s", err_str);
> + saflog(LOG_NOTICE, amfSvcUsrName, "CCB %llu validation error:
> %s",
> + opdata->ccbId, err_str);
> (void) saImmOiCcbSetErrorString(avd_cb->immOiHandle,
> opdata->ccbId, err_str);
> - else
> - LOG_WA("%s", err_str);
> + } else {
> + // errors found during initial configuration read
> + LOG_WA("configuration validation error: %s", err_str);
> + }
> }
> +
> /**
> * Respond admin op to IMM
> * @param immOiHandle
>
> ------------------------------------------------------------------------------
> Rapidly troubleshoot problems before they affect your business. Most IT
> organizations don't have a clear picture of how application performance
> affects their revenue. With AppDynamics, you get 100% visibility into your
> Java,.NET, & PHP application. Start your 15-day FREE TRIAL of AppDynamics Pro!
> http://pubads.g.doubleclick.net/gampad/clk?id=84349351&iu=/4140/ostg.clktrk
> _______________________________________________
> Opensaf-devel mailing list
> Opensaf-devel@lists.sourceforge.net
> https://lists.sourceforge.net/lists/listinfo/opensaf-devel
>
>
------------------------------------------------------------------------------
Sponsored by Intel(R) XDK
Develop, test and display web and hybrid apps with a single code base.
Download it for free now!
http://pubads.g.doubleclick.net/gampad/clk?id=111408631&iu=/4140/ostg.clktrk
_______________________________________________
Opensaf-devel mailing list
Opensaf-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/opensaf-devel
