Ack with the following comments.

+       $(top_builddir)/osaf/libs/saf/libSaAmf/libSaAmf.la \
+       $(top_builddir)/osaf/libs/saf/libSaImm/libSaImmOi.la
[Ramesh]: Not required to add libSaImmOi.la


+       /* Detach from IPC */
+       m_NCS_IPC_DETACH(&clmna_cb->mbx, NULL, clmna_cb);
[Ramesh]: As the process EXITs, can avoid doing the above step.


+       NCS_SEL_OBJ mbx_fd;
+       SaNameT comp_name;      /* My AMF name */
+       SaAmfHandleT amf_hdl;   /* Handle obtained from AMF */
+       SaInvocationT amf_inv;  /* AMF Invocation Id */
+       bool is_quiesced_set;   /* */
[Ramesh]: mds_role, amf_inv and is_quiesced_set are unsued variables.


+       CLMNA_EVT_INVALID = 0,
+       CLMNA_EVT_DUMMY_MSG,
+       CLMNA_EVT_NODE_INFO_MSG
[Ramesh]: Better CLMNA_EVT_NODE_INFO_MSG be part of ticket# 228 fix.

Thanks,
Ramesh.

On 12/11/2013 4:53 PM, Mathivanan Naickan Palanivelu wrote:
> Ramesh, Looks like hg add/remove was missed while adding to the queue.
> Attached the patch.
> -Mathi.
>
>> -----Original Message-----
>> From: Mathivanan Naickan Palanivelu
>> Sent: Wednesday, December 04, 2013 6:31 PM
>> To: Ramesh Babu Betham
>> Cc: opensaf-devel@lists.sourceforge.net
>> Subject: [devel] [PATCH 3 of 4] clm: register with amf [#220]
>>
>>   osaf/services/saf/clmsv/nodeagent/Makefile.am |  14 +++++++++++---
>>   1 files changed, 11 insertions(+), 3 deletions(-)
>>
>>
>> diff --git a/osaf/services/saf/clmsv/nodeagent/Makefile.am
>> b/osaf/services/saf/clmsv/nodeagent/Makefile.am
>> --- a/osaf/services/saf/clmsv/nodeagent/Makefile.am
>> +++ b/osaf/services/saf/clmsv/nodeagent/Makefile.am
>> @@ -20,16 +20,24 @@ MAINTAINERCLEANFILES = Makefile.in
>>
>>   SUBDIRS = scripts
>>
>> +noinst_HEADERS = \
>> +    cb.h \
>> +    clmna.h
>> +
>>   osaf_execbindir = $(pkglibdir)
>>   osaf_execbin_PROGRAMS = osafclmna
>>
>>   osafclmna_CPPFLAGS = \
>>      $(AM_CPPFLAGS) \
>> -    -I$(top_srcdir)/osaf/libs/common/clmsv/include
>> +    -I$(top_srcdir)/osaf/libs/common/clmsv/include \
>> +    -I$(top_srcdir)/osaf/saf/services/saf/clmsv/nodeagent
>>
>>   osafclmna_SOURCES = \
>> -    clms_nodeagent.c
>> +    main.c \
>> +    amf.c
>>
>>   osafclmna_LDADD = \
>>      $(top_builddir)/osaf/libs/common/clmsv/libclmsv_common.la \
>> -    $(top_builddir)/osaf/libs/core/libopensaf_core.la
>> +    $(top_builddir)/osaf/libs/core/libopensaf_core.la \
>> +    $(top_builddir)/osaf/libs/saf/libSaAmf/libSaAmf.la \
>> +    $(top_builddir)/osaf/libs/saf/libSaImm/libSaImmOi.la
>>
>> ------------------------------------------------------------------------------
>> Sponsored by Intel(R) XDK
>> Develop, test and display web and hybrid apps with a single code base.
>> Download it for free now!
>> http://pubads.g.doubleclick.net/gampad/clk?id=111408631&iu=/4140/ostg.cl
>> ktrk
>> _______________________________________________
>> Opensaf-devel mailing list
>> Opensaf-devel@lists.sourceforge.net
>> https://lists.sourceforge.net/lists/listinfo/opensaf-devel


------------------------------------------------------------------------------
Rapidly troubleshoot problems before they affect your business. Most IT 
organizations don't have a clear picture of how application performance 
affects their revenue. With AppDynamics, you get 100% visibility into your 
Java,.NET, & PHP application. Start your 15-day FREE TRIAL of AppDynamics Pro!
http://pubads.g.doubleclick.net/gampad/clk?id=84349831&iu=/4140/ostg.clktrk
_______________________________________________
Opensaf-devel mailing list
Opensaf-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/opensaf-devel

Reply via email to