Summary:mds: provide nodes IPV4/IPV6 address in MDS NODEUP event [#617]
Review request for Trac Ticket(s):#617
Peer Reviewer(s):Ramesh & Mathi
Pull request to: <<LIST THE PERSON WITH PUSH ACCESS HERE>>
Affected branch(es): <<LIST ALL AFFECTED BRANCH(ES)>>
Development branch: <<IF ANY GIVE THE REPO URL>>
--------------------------------
Impacted area Impact y/n
--------------------------------
Docs n
Build system n
RPM/packaging n
Configuration files n
Startup scripts n
SAF services n
OpenSAF services n
Core libraries y
Samples n
Tests n
Other n
Comments (indicate scope for each "y" above):
---------------------------------------------
Now mds node up event also proved follwing in addition to node_id in NODEUP
event ,the application which is
subscribed for MDS_NODE_SUBSCRIBE.
uint8_t ip_addr[INET6_ADDRSTRLEN];
uint16_t length;
uint16_t addr_family; /* IP V6 or IP V4 */
Note : for TIPC addr_family will be AF_TIPC & ip_addr will be NULL
At current the CLM is the user of this data (
https://sourceforge.net/p/opensaf/tickets/228 Add support for saClmNodeAddress
and saClmNodeCurrAddress)
changeset 33a7b153732bfd79d7f4ce25ca07ac2812a78e3b
Author: A V Mahesh <mahesh.va...@oracle.com>
Date: Wed, 18 Dec 2013 10:05:26 +0530
mds: provide node's IPV4/IPV6 address in MDS NODEUP event [#617]
Complete diffstat:
------------------
osaf/libs/core/include/mds_papi.h | 3 +++
osaf/libs/core/mds/include/mds_dt2c.h | 4 ++--
osaf/libs/core/mds/mds_c_api.c | 18
+++++++++++++++---
osaf/libs/core/mds/mds_dt_tipc.c | 4 ++--
osaf/libs/core/mds/mds_dt_trans.c | 16
++++++++++++++--
osaf/services/infrastructure/dtms/dtm/dtm_inter_svc.c | 6 +++++-
osaf/services/infrastructure/dtms/dtm/dtm_intra.c | 22
+++++++++++++++-------
osaf/services/infrastructure/dtms/dtm/dtm_intra_svc.c | 22
+++++++++++++++++++---
osaf/services/infrastructure/dtms/dtm/dtm_main.c | 2 +-
osaf/services/infrastructure/dtms/dtm/dtm_node.c | 10 ++++++----
osaf/services/infrastructure/dtms/dtm/dtm_node_sockets.c | 16
++++++++++------
osaf/services/infrastructure/dtms/include/dtm.h | 5 ++++-
osaf/services/infrastructure/dtms/include/dtm_cb.h | 1 +
osaf/services/infrastructure/dtms/include/dtm_inter.h | 2 +-
osaf/services/infrastructure/dtms/include/dtm_intra.h | 2 +-
osaf/services/infrastructure/dtms/include/dtm_intra_disc.h | 12 ++++++++----
osaf/services/infrastructure/dtms/include/dtm_node.h | 2 +-
17 files changed, 108 insertions(+), 39 deletions(-)
Testing Commands:
-----------------
Ticket #228
Testing, Expected Results:
--------------------------
hould fulfill Ticket #228 requirements.
Conditions of Submission:
-------------------------
Ack for Ramesh
Arch Built Started Linux distro
-------------------------------------------
mips n n
mips64 n n
x86 y y
x86_64 n n
powerpc n n
powerpc64 n n
Reviewer Checklist:
-------------------
[Submitters: make sure that your review doesn't trigger any checkmarks!]
Your checkin has not passed review because (see checked entries):
___ Your RR template is generally incomplete; it has too many blank entries
that need proper data filled in.
___ You have failed to nominate the proper persons for review and push.
___ Your patches do not have proper short+long header
___ You have grammar/spelling in your header that is unacceptable.
___ You have exceeded a sensible line length in your headers/comments/text.
___ You have failed to put in a proper Trac Ticket # into your commits.
___ You have incorrectly put/left internal data in your comments/files
(i.e. internal bug tracking tool IDs, product names etc)
___ You have not given any evidence of testing beyond basic build tests.
Demonstrate some level of runtime or other sanity testing.
___ You have ^M present in some of your files. These have to be removed.
___ You have needlessly changed whitespace or added whitespace crimes
like trailing spaces, or spaces before tabs.
___ You have mixed real technical changes with whitespace and other
cosmetic code cleanup changes. These have to be separate commits.
___ You need to refactor your submission into logical chunks; there is
too much content into a single commit.
___ You have extraneous garbage in your review (merge commits etc)
___ You have giant attachments which should never have been sent;
Instead you should place your content in a public tree to be pulled.
___ You have too many commits attached to an e-mail; resend as threaded
commits, or place in a public tree for a pull.
___ You have resent this content multiple times without a clear indication
of what has changed between each re-send.
___ You have failed to adequately and individually address all of the
comments and change requests that were proposed in the initial review.
___ You have a misconfigured ~/.hgrc file (i.e. username, email etc)
___ Your computer have a badly configured date and time; confusing the
the threaded patch review.
___ Your changes affect IPC mechanism, and you don't present any results
for in-service upgradability test.
___ Your changes affect user manual and documentation, your patch series
do not contain the patch that updates the Doxygen manual.
------------------------------------------------------------------------------
Rapidly troubleshoot problems before they affect your business. Most IT
organizations don't have a clear picture of how application performance
affects their revenue. With AppDynamics, you get 100% visibility into your
Java,.NET, & PHP application. Start your 15-day FREE TRIAL of AppDynamics Pro!
http://pubads.g.doubleclick.net/gampad/clk?id=84349831&iu=/4140/ostg.clktrk
_______________________________________________
Opensaf-devel mailing list
Opensaf-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/opensaf-devel
