Fix to fds variable in immd needs to be moved from the immnd patch to the immd
patch.
Ack from me.
Tested with 0-PBE and 1-PBE
(not tested with 2PBE as the immtests dont work there anyway #624).
(The immomtest/immoitest also need fixing to use version A.2.13 of the imm api,
otherwise at least immomtest fails in some tests sensitive to version.
Zoran will fix this as part of #636).
In "principle" you should give Neelakanta a chance to comment.
/AndersBj
-----Original Message-----
From: Hans Feldt
Sent: den 19 december 2013 09:28
To: Anders Björnerstedt
Cc: opensaf-devel@lists.sourceforge.net
Subject: [PATCH 0 of 2] Review Request for imm #581
Summary: IMM use of exit handler
Review request for Trac Ticket(s): 581
Peer Reviewer(s): Anders B
Pull request to: <<LIST THE PERSON WITH PUSH ACCESS HERE>> Affected branch(es):
default Development branch: <<IF ANY GIVE THE REPO URL>>
--------------------------------
Impacted area Impact y/n
--------------------------------
Docs n
Build system n
RPM/packaging n
Configuration files n
Startup scripts n
SAF services y
OpenSAF services n
Core libraries n
Samples n
Tests n
Other n
Comments (indicate scope for each "y" above):
---------------------------------------------
changeset 49cb587ebc95ccf26715207c22a454018f16fbe2
Author: Hans Feldt <hans.fe...@ericsson.com>
Date: Thu, 19 Dec 2013 09:18:40 +0100
immd: use daemon_sigterm_install (#581)
changeset 6f7226ad8a5ac8e062f7c0c825a94c63460a8a8c
Author: Hans Feldt <hans.fe...@ericsson.com>
Date: Thu, 19 Dec 2013 09:19:04 +0100
immnd: use daemon_sigterm_install (#581)
Complete diffstat:
------------------
osaf/services/saf/immsv/immd/immd_main.c | 22 ++++++++++++++++------
osaf/services/saf/immsv/immnd/immnd_evt.c | 3 ++-
osaf/services/saf/immsv/immnd/immnd_main.c | 19 +++++++++++++++----
3 files changed, 33 insertions(+), 11 deletions(-)
Testing Commands:
-----------------
Start/stop opensaf on different node types and read syslog
Testing, Expected Results:
--------------------------
new logs from immd & immnd
Conditions of Submission:
-------------------------
Ack from Anders
Arch Built Started Linux distro
-------------------------------------------
mips n n
mips64 n n
x86 n n
x86_64 y y
powerpc n n
powerpc64 n n
Reviewer Checklist:
-------------------
[Submitters: make sure that your review doesn't trigger any checkmarks!]
Your checkin has not passed review because (see checked entries):
___ Your RR template is generally incomplete; it has too many blank entries
that need proper data filled in.
___ You have failed to nominate the proper persons for review and push.
___ Your patches do not have proper short+long header
___ You have grammar/spelling in your header that is unacceptable.
___ You have exceeded a sensible line length in your headers/comments/text.
___ You have failed to put in a proper Trac Ticket # into your commits.
___ You have incorrectly put/left internal data in your comments/files
(i.e. internal bug tracking tool IDs, product names etc)
___ You have not given any evidence of testing beyond basic build tests.
Demonstrate some level of runtime or other sanity testing.
___ You have ^M present in some of your files. These have to be removed.
___ You have needlessly changed whitespace or added whitespace crimes
like trailing spaces, or spaces before tabs.
___ You have mixed real technical changes with whitespace and other
cosmetic code cleanup changes. These have to be separate commits.
___ You need to refactor your submission into logical chunks; there is
too much content into a single commit.
___ You have extraneous garbage in your review (merge commits etc)
___ You have giant attachments which should never have been sent;
Instead you should place your content in a public tree to be pulled.
___ You have too many commits attached to an e-mail; resend as threaded
commits, or place in a public tree for a pull.
___ You have resent this content multiple times without a clear indication
of what has changed between each re-send.
___ You have failed to adequately and individually address all of the
comments and change requests that were proposed in the initial review.
___ You have a misconfigured ~/.hgrc file (i.e. username, email etc)
___ Your computer have a badly configured date and time; confusing the
the threaded patch review.
___ Your changes affect IPC mechanism, and you don't present any results
for in-service upgradability test.
___ Your changes affect user manual and documentation, your patch series
do not contain the patch that updates the Doxygen manual.
------------------------------------------------------------------------------
Rapidly troubleshoot problems before they affect your business. Most IT
organizations don't have a clear picture of how application performance
affects their revenue. With AppDynamics, you get 100% visibility into your
Java,.NET, & PHP application. Start your 15-day FREE TRIAL of AppDynamics Pro!
http://pubads.g.doubleclick.net/gampad/clk?id=84349831&iu=/4140/ostg.clktrk
_______________________________________________
Opensaf-devel mailing list
Opensaf-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/opensaf-devel
