Hi There are some memory leaks fixed in the patch series that would be applicable to 4.4. I guess I should extract just the leak fixes for the next 4.4 candidate / correction release?
Thanks Gary Quoting Anders Björnerstedt <[email protected]>: > Yes 4.4 window is closed since we have tagg'ed 4.4.FC. > > /AndersBj > > -----Original Message----- > From: Hans Feldt [mailto:[email protected]] > Sent: den 9 januari 2014 13:06 > To: Gary Lee; Hans Nordebäck; [email protected]; > [email protected] > Cc: [email protected] > Subject: Re: [devel] [PATCH 00 of 15] Review Request for AMF: > Coverity issues in amfd/amfnd [#680] > > Is this a patch series for 4.5 or default? > > The ticket is an enhancement, is the 4.4 window closed? > > Thanks, > Hans > > On 01/03/2014 06:51 AM, Gary Lee wrote: >> Summary: AMF: Coverity issues in amfd/amfnd [#680] Review request for >> Trac Ticket(s): 680 Peer Reviewer(s): Hans N, Hans F, Praveen, >> Nagendra Pull request to: >> Affected branch(es): default >> Development branch: default >> >> -------------------------------- >> Impacted area Impact y/n >> -------------------------------- >> Docs n >> Build system n >> RPM/packaging n >> Configuration files n >> Startup scripts n >> SAF services y >> OpenSAF services n >> Core libraries n >> Samples n >> Tests n >> Other n >> >> >> Comments (indicate scope for each "y" above): >> --------------------------------------------- >> This patch set fixes a number of 'issues' in amfd and amfnd >> identified by Coverity. >> A number of 'issues' still remain and will be fixed in a later patch/ticket. >> >> Basic testing and valgrind have been run. >> >> changeset 0b48fcffb4ff4a739e56d33e5780e535cd232d3a >> Author: Gary Lee <[email protected]> >> Date: Fri, 03 Jan 2014 16:26:02 +1100 >> >> amfd: Correct a number of issues identified by Coverity [#680] >> * Unnecessary header file (HFA) >> * Logically dead code (DEADCODE) >> * Dereference null return value (NULL_RETURNS) >> * Uninitialized scalar variable (UNINIT) >> * Unused pointer value (UNUSED_VALUE) >> >> * Also remove check for NULL return value from avd_app_new() as this is >> no >> longer required >> >> changeset f4290079e205f56acd5597253927b384b64765da >> Author: Gary Lee <[email protected]> >> Date: Fri, 03 Jan 2014 16:26:02 +1100 >> >> amfd: Correct a number of issues identified by Coverity [#680] >> * Unnecessary header file (HFA) >> * Logically dead code (DEADCODE) >> * Dereference null return value (NULL_RETURNS) >> * Uninitialized scalar variable (UNINIT) >> * Unused pointer value (UNUSED_VALUE) >> >> changeset b19a672ceb57f418503aeced80da5a452943d16a >> Author: Gary Lee <[email protected]> >> Date: Fri, 03 Jan 2014 16:26:02 +1100 >> >> amfd: Correct a number of issues identified by Coverity [#680] >> * Dereference null return value (NULL_RETURNS) >> * Uninitialized scalar variable (UNINIT) >> * Big parameter passed by value (PASS_BY_VALUE) >> >> * Remove saAmfStgValidSuTypes from AVD_AMF_SG_TYPE, as it appears to be >> a >> typo of saAmfSGtValidSuTypes >> >> changeset 80ff873eb3f034d2ca4ff30953bfb6bb925ac723 >> Author: Gary Lee <[email protected]> >> Date: Fri, 03 Jan 2014 16:26:02 +1100 >> >> amfd: Correct a number of issues identified by Coverity [#680] >> * Unchecked return value (CHECKED_RETURN) >> * Dereference null return value (NULL_RETURNS) >> * Uninitialized scalar variable (UNINIT) >> * Unnecessary header file (HFA) >> * Big parameter passed by value (PASS_BY_VALUE) >> >> changeset 91e108b0576533083ea81dbf4ffebfe5f86e33f0 >> Author: Gary Lee <[email protected]> >> Date: Fri, 03 Jan 2014 16:26:02 +1100 >> >> amfd: Correct a number of issues identified by Coverity [#680] >> * Unchecked return value (CHECKED_RETURN) >> * Dereference null return value (NULL_RETURNS) >> * Logically dead code (DEADCODE) >> * Uninitialized scalar variable (UNINIT) >> * Unnecessary header file (HFA) >> * Big parameter passed by value (PASS_BY_VALUE) >> * Unused pointer value (UNUSED_VALUE) >> >> * Also, replace saAmfStgValidSuTypes with saAmfSGtValidSuTypes in >> sgtype.cc >> >> changeset df1a77bc86b2cdf885cf444280bbef6c9ad90174 >> Author: Gary Lee <[email protected]> >> Date: Fri, 03 Jan 2014 16:26:02 +1100 >> >> amfd: Correct a number of issues identified by Coverity [#680] >> * Unnecessary header file (HFA) >> * Dereference after null check (FORWARD_NULL) >> * Dereference null return value (NULL_RETURNS) >> * Logically dead code (DEADCODE) >> * Big parameter passed by value (PASS_BY_VALUE) >> * Unchecked return value (CHECKED_RETURN) >> * Side effect in assertion (ASSERT_SIDE_EFFECT) >> * Unused pointer value (UNUSED_VALUE) >> >> changeset ea43d2c57d577714d67c849cd2cca74d3a5b9b06 >> Author: Gary Lee <[email protected]> >> Date: Fri, 03 Jan 2014 16:26:02 +1100 >> >> amfd: Correct a number of issues identified by Coverity [#680] >> * Dereference null return value (NULL_RETURNS) >> * Uninitialized scalar variable (UNINIT) >> * Unused pointer value (UNUSED_VALUE) >> * Unnecessary header file (HFA) >> >> changeset ae6184583eff874828c0433f82755881f395c4c4 >> Author: Gary Lee <[email protected]> >> Date: Fri, 03 Jan 2014 16:26:02 +1100 >> >> amfd: Correct a number of issues identified by Coverity [#680] >> * Calling risky function (SECURE_CODING) >> >> replace calls to sprintf with snprintf >> >> changeset 55b8b19a5fe16b66c08fcdfef098e6472605d202 >> Author: Gary Lee <[email protected]> >> Date: Fri, 03 Jan 2014 16:26:02 +1100 >> >> amfd: Correct a number of issues identified by Coverity [#680] >> * use delete[] for variables allocated with new[] >> >> changeset de8f6abe461b425cfc83534c4a111118f29a22cd >> Author: Gary Lee <[email protected]> >> Date: Fri, 03 Jan 2014 16:26:02 +1100 >> >> amfnd: Correct a number of issues identified by Coverity [#680] >> * Unchecked return value (CHECKED_RETURN) >> * Logically dead code (DEADCODE) >> * Dereference null return value (NULL_RETURNS) >> >> changeset bd69c2ca2bf3131f530db00d8bd82abc13b68265 >> Author: Gary Lee <[email protected]> >> Date: Fri, 03 Jan 2014 16:26:02 +1100 >> >> amfnd: Correct a number of issues identified by Coverity [#680] >> * Unnecessary header file (HFA) >> * Unchecked return value (CHECKED_RETURN) >> * Uninitialized scalar variable (UNINIT) >> * Out-of-bounds read (OVERRUN_STATIC) >> * Side effect in assertion (ASSERT_SIDE_EFFECT) >> * Logically dead code (DEADCODE) >> >> changeset d982ed147a5b49c6df2cc74702f68e1b0eca781d >> Author: Gary Lee <[email protected]> >> Date: Fri, 03 Jan 2014 16:26:02 +1100 >> >> amfnd: Correct a number of issues identified by Coverity [#680] >> * Dereference after null check (FORWARD_NULL) >> * Logically dead code (DEADCODE) >> * Uninitialized scalar variable (UNINIT) >> >> changeset 6443cebd8d40aa6b0aae95ba3132b88aeced2852 >> Author: Gary Lee <[email protected]> >> Date: Fri, 03 Jan 2014 16:26:02 +1100 >> >> amfnd: Correct a number of issues identified by Coverity [#680] >> * Dereference before null check (REVERSE_INULL) >> * Logically dead code (DEADCODE) >> * Uninitialized scalar variable (UNINIT) >> * Dereference null return value (NULL_RETURNS) >> * Unnecessary header file (HFA) >> * Side effect in assertion (ASSERT_SIDE_EFFECT) >> * Unchecked return value (CHECKED_RETURN) >> >> In pg.cc, remove "cbk_info = NULL;" statement which causes memory leak. >> >> changeset d3f4b64eeb2003b846439acccca12b51252b9585 >> Author: Gary Lee <[email protected]> >> Date: Fri, 03 Jan 2014 16:26:02 +1100 >> >> amfnd: Correct a number of issues identified by Coverity [#680] >> * Calling risky function (SECURE_CODING) >> >> fix buffer overflow if a string longer than 31 chars is specified for >> "node_type" >> >> changeset ba99ed4683e9988ed1a2e87ce401c5be229d2f9e >> Author: Gary Lee <[email protected]> >> Date: Fri, 03 Jan 2014 16:26:02 +1100 >> >> amfnd: Correct a number of issues identified by Coverity [#680] >> * use delete[] for variables allocated with new[] >> >> >> Complete diffstat: >> ------------------ >> osaf/services/saf/amf/amfd/app.cc | 27 >> ++++++++++++--------------- >> osaf/services/saf/amf/amfd/apptype.cc | 13 ++++--------- >> osaf/services/saf/amf/amfd/cluster.cc | 3 +-- >> osaf/services/saf/amf/amfd/comp.cc | 17 ++++++++++------- >> osaf/services/saf/amf/amfd/compcstype.cc | 10 ++++++++-- >> osaf/services/saf/amf/amfd/comptype.cc | 7 +++++-- >> osaf/services/saf/amf/amfd/csi.cc | 20 ++++++++++++++++++-- >> osaf/services/saf/amf/amfd/csiattr.cc | 2 ++ >> osaf/services/saf/amf/amfd/cstype.cc | 4 +++- >> osaf/services/saf/amf/amfd/ctcstype.cc | 14 +++++--------- >> osaf/services/saf/amf/amfd/hlt.cc | 3 ++- >> osaf/services/saf/amf/amfd/imm.cc | 10 +++++++--- >> osaf/services/saf/amf/amfd/include/ntf.h | 4 ++-- >> osaf/services/saf/amf/amfd/include/sg.h | 1 - >> osaf/services/saf/amf/amfd/include/susi.h | 4 ++-- >> osaf/services/saf/amf/amfd/ndfsm.cc | 4 +++- >> osaf/services/saf/amf/amfd/ndproc.cc | 5 ++++- >> osaf/services/saf/amf/amfd/node.cc | 12 ++++++++---- >> osaf/services/saf/amf/amfd/nodegroup.cc | 18 +++++++++++++++--- >> osaf/services/saf/amf/amfd/nodeswbundle.cc | 2 +- >> osaf/services/saf/amf/amfd/ntf.cc | 6 +++--- >> osaf/services/saf/amf/amfd/role.cc | 6 +++++- >> osaf/services/saf/amf/amfd/sg.cc | 24 >> ++++++++++++++---------- >> osaf/services/saf/amf/amfd/sg_2n_fsm.cc | 1 + >> osaf/services/saf/amf/amfd/sg_nored_fsm.cc | 12 ++++++++---- >> osaf/services/saf/amf/amfd/sg_npm_fsm.cc | 6 +++++- >> osaf/services/saf/amf/amfd/sg_nway_fsm.cc | 14 +++++++------- >> osaf/services/saf/amf/amfd/sg_nwayact_fsm.cc | 4 ++-- >> osaf/services/saf/amf/amfd/sgproc.cc | 7 +++---- >> osaf/services/saf/amf/amfd/sgtype.cc | 10 +++++++--- >> osaf/services/saf/amf/amfd/si.cc | 24 >> ++++++++++++------------ >> osaf/services/saf/amf/amfd/si_dep.cc | 11 ++++++++--- >> osaf/services/saf/amf/amfd/siass.cc | 4 ++-- >> osaf/services/saf/amf/amfd/sirankedsu.cc | 15 ++++++++------- >> osaf/services/saf/amf/amfd/su.cc | 14 ++++++++++++-- >> osaf/services/saf/amf/amfd/sutcomptype.cc | 4 +++- >> osaf/services/saf/amf/amfd/sutype.cc | 12 +++++------- >> osaf/services/saf/amf/amfd/svctype.cc | 6 +++--- >> osaf/services/saf/amf/amfd/svctypecstypes.cc | 6 ++++-- >> osaf/services/saf/amf/amfd/util.cc | 6 +++--- >> osaf/services/saf/amf/amfnd/cbq.cc | 13 ++++++++++--- >> osaf/services/saf/amf/amfnd/chc.cc | 10 +++++++--- >> osaf/services/saf/amf/amfnd/ckpt_updt.cc | 4 ++-- >> osaf/services/saf/amf/amfnd/clc.cc | 11 ++++------- >> osaf/services/saf/amf/amfnd/clm.cc | 11 ++++++----- >> osaf/services/saf/amf/amfnd/comp.cc | 16 ++++++---------- >> osaf/services/saf/amf/amfnd/compdb.cc | 26 >> ++++++++++++-------------- >> osaf/services/saf/amf/amfnd/di.cc | 5 ++++- >> osaf/services/saf/amf/amfnd/hcdb.cc | 3 +-- >> osaf/services/saf/amf/amfnd/main.cc | 6 ++++-- >> osaf/services/saf/amf/amfnd/pg.cc | 5 ++--- >> osaf/services/saf/amf/amfnd/sidb.cc | 14 ++++++++------ >> osaf/services/saf/amf/amfnd/sudb.cc | 4 ++-- >> osaf/services/saf/amf/amfnd/susm.cc | 22 ++++++++++++++++++++-- >> osaf/services/saf/amf/amfnd/term.cc | 2 +- >> 55 files changed, 316 insertions(+), 208 deletions(-) >> >> >> Testing Commands: >> ----------------- >> <<LIST THE COMMAND LINE TOOLS/STEPS TO TEST YOUR CHANGES>> >> >> >> Testing, Expected Results: >> -------------------------- >> <<PASTE COMMAND OUTPUTS / TEST RESULTS>> >> >> >> Conditions of Submission: >> ------------------------- >> <<HOW MANY DAYS BEFORE PUSHING, CONSENSUS ETC>> >> >> >> Arch Built Started Linux distro >> ------------------------------------------- >> mips n n >> mips64 n n >> x86 n n >> x86_64 n n >> powerpc n n >> powerpc64 n n >> >> >> Reviewer Checklist: >> ------------------- >> [Submitters: make sure that your review doesn't trigger any >> checkmarks!] >> >> >> Your checkin has not passed review because (see checked entries): >> >> ___ Your RR template is generally incomplete; it has too many blank entries >> that need proper data filled in. >> >> ___ You have failed to nominate the proper persons for review and push. >> >> ___ Your patches do not have proper short+long header >> >> ___ You have grammar/spelling in your header that is unacceptable. >> >> ___ You have exceeded a sensible line length in your headers/comments/text. >> >> ___ You have failed to put in a proper Trac Ticket # into your commits. >> >> ___ You have incorrectly put/left internal data in your comments/files >> (i.e. internal bug tracking tool IDs, product names etc) >> >> ___ You have not given any evidence of testing beyond basic build tests. >> Demonstrate some level of runtime or other sanity testing. >> >> ___ You have ^M present in some of your files. These have to be removed. >> >> ___ You have needlessly changed whitespace or added whitespace crimes >> like trailing spaces, or spaces before tabs. >> >> ___ You have mixed real technical changes with whitespace and other >> cosmetic code cleanup changes. These have to be separate commits. >> >> ___ You need to refactor your submission into logical chunks; there is >> too much content into a single commit. >> >> ___ You have extraneous garbage in your review (merge commits etc) >> >> ___ You have giant attachments which should never have been sent; >> Instead you should place your content in a public tree to be pulled. >> >> ___ You have too many commits attached to an e-mail; resend as threaded >> commits, or place in a public tree for a pull. >> >> ___ You have resent this content multiple times without a clear indication >> of what has changed between each re-send. >> >> ___ You have failed to adequately and individually address all of the >> comments and change requests that were proposed in the initial review. >> >> ___ You have a misconfigured ~/.hgrc file (i.e. username, email etc) >> >> ___ Your computer have a badly configured date and time; confusing the >> the threaded patch review. >> >> ___ Your changes affect IPC mechanism, and you don't present any results >> for in-service upgradability test. >> >> ___ Your changes affect user manual and documentation, your patch series >> do not contain the patch that updates the Doxygen manual. >> >> > > ------------------------------------------------------------------------------ > CenturyLink Cloud: The Leader in Enterprise Cloud Services. > Learn Why More Businesses Are Choosing CenturyLink Cloud For > Critical Workloads, Development Environments & Everything In Between. > Get a Quote or Start a Free Trial Today. > http://pubads.g.doubleclick.net/gampad/clk?id=119420431&iu=/4140/ostg.clktrk > _______________________________________________ > Opensaf-devel mailing list > [email protected] > https://lists.sourceforge.net/lists/listinfo/opensaf-devel ------------------------------------------------------------------------------ CenturyLink Cloud: The Leader in Enterprise Cloud Services. Learn Why More Businesses Are Choosing CenturyLink Cloud For Critical Workloads, Development Environments & Everything In Between. Get a Quote or Start a Free Trial Today. http://pubads.g.doubleclick.net/gampad/clk?id=119420431&iu=/4140/ostg.clktrk _______________________________________________ Opensaf-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/opensaf-devel
