Summary: AMFD: errors reported in valgrind [#715]
Review request for Trac Ticket(s): 715
Peer Reviewer(s): Hans F, Hans N
Pull request to:
Affected branch(es): default, opensaf-4.4.x
Development branch:
--------------------------------
Impacted area Impact y/n
--------------------------------
Docs n
Build system n
RPM/packaging n
Configuration files n
Startup scripts n
SAF services y
OpenSAF services n
Core libraries n
Samples n
Tests n
Other n
Comments (indicate scope for each "y" above):
---------------------------------------------
Some of the changes will need to be backported to older branches.
This will be done in a new ticket, as the changes are fairly different
(C/C++ allocation differences).
changeset 6024244cfcc20ae49b9c5d65b3e14f5b0770bd2b
Author: Gary Lee <gary....@dektech.com.au>
Date: Mon, 13 Jan 2014 21:50:14 +1100
* remove saAmfStgValidSuTypes from 'struct avd_amf_sg_type_tag' as it
appears to be a typo of saAmfSGtValidSuTypes
* ensure saAmfCSIDependencies is deleted in csi.cc
* ensure saAmfSIActiveWeight, saAmfSIStandbyWeight,
saAmfSvcDefActiveWeight
and saAmfSvcDefStandbyWeight are deleted in si.cc
* fix a few typos where delete is called when delete [] is required
Complete diffstat:
------------------
osaf/services/saf/amf/amfd/csi.cc | 25 ++++++++++++++++++++-----
osaf/services/saf/amf/amfd/include/sg.h | 1 -
osaf/services/saf/amf/amfd/sgtype.cc | 3 ++-
osaf/services/saf/amf/amfd/si.cc | 27 +++++++++++++++++++++++++--
osaf/services/saf/amf/amfd/svctype.cc | 20 ++++++++++++++++++++
osaf/services/saf/amf/amfd/util.cc | 4 ++--
6 files changed, 69 insertions(+), 11 deletions(-)
Testing Commands:
-----------------
<<LIST THE COMMAND LINE TOOLS/STEPS TO TEST YOUR CHANGES>>
Testing, Expected Results:
--------------------------
<<PASTE COMMAND OUTPUTS / TEST RESULTS>>
Conditions of Submission:
-------------------------
<<HOW MANY DAYS BEFORE PUSHING, CONSENSUS ETC>>
Arch Built Started Linux distro
-------------------------------------------
mips n n
mips64 n n
x86 n n
x86_64 y y
powerpc n n
powerpc64 n n
Reviewer Checklist:
-------------------
[Submitters: make sure that your review doesn't trigger any checkmarks!]
Your checkin has not passed review because (see checked entries):
___ Your RR template is generally incomplete; it has too many blank entries
that need proper data filled in.
___ You have failed to nominate the proper persons for review and push.
___ Your patches do not have proper short+long header
___ You have grammar/spelling in your header that is unacceptable.
___ You have exceeded a sensible line length in your headers/comments/text.
___ You have failed to put in a proper Trac Ticket # into your commits.
___ You have incorrectly put/left internal data in your comments/files
(i.e. internal bug tracking tool IDs, product names etc)
___ You have not given any evidence of testing beyond basic build tests.
Demonstrate some level of runtime or other sanity testing.
___ You have ^M present in some of your files. These have to be removed.
___ You have needlessly changed whitespace or added whitespace crimes
like trailing spaces, or spaces before tabs.
___ You have mixed real technical changes with whitespace and other
cosmetic code cleanup changes. These have to be separate commits.
___ You need to refactor your submission into logical chunks; there is
too much content into a single commit.
___ You have extraneous garbage in your review (merge commits etc)
___ You have giant attachments which should never have been sent;
Instead you should place your content in a public tree to be pulled.
___ You have too many commits attached to an e-mail; resend as threaded
commits, or place in a public tree for a pull.
___ You have resent this content multiple times without a clear indication
of what has changed between each re-send.
___ You have failed to adequately and individually address all of the
comments and change requests that were proposed in the initial review.
___ You have a misconfigured ~/.hgrc file (i.e. username, email etc)
___ Your computer have a badly configured date and time; confusing the
the threaded patch review.
___ Your changes affect IPC mechanism, and you don't present any results
for in-service upgradability test.
___ Your changes affect user manual and documentation, your patch series
do not contain the patch that updates the Doxygen manual.
------------------------------------------------------------------------------
CenturyLink Cloud: The Leader in Enterprise Cloud Services.
Learn Why More Businesses Are Choosing CenturyLink Cloud For
Critical Workloads, Development Environments & Everything In Between.
Get a Quote or Start a Free Trial Today.
http://pubads.g.doubleclick.net/gampad/clk?id=119420431&iu=/4140/ostg.clktrk
_______________________________________________
Opensaf-devel mailing list
Opensaf-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/opensaf-devel
