Summary: Refactoring AMF Review request for Trac Ticket(s): #713 Peer Reviewer(s): HansF Pull request to: Affected branch(es): default Development branch: default
-------------------------------- Impacted area Impact y/n -------------------------------- Docs n Build system n RPM/packaging n Configuration files n Startup scripts n SAF services n OpenSAF services y Core libraries n Samples n Tests n Other n Comments (indicate scope for each "y" above): --------------------------------------------- <<EXPLAIN/COMMENT THE PATCH SERIES HERE>> changeset 596ac39867214ff136c31ff62a88a9649074a3ca Author: Hans Nordeback <[email protected]> Date: Thu, 09 Jan 2014 16:55:57 +0100 amfd: use bool instead of SaBoolT [#713] Since bool is a fundamental datatype in C++ let's use it changeset 1fc69cba1a9ff91874336f905779351ddd2d0614 Author: Hans Nordeback <[email protected]> Date: Tue, 14 Jan 2014 10:05:44 +0100 amfnd: use bool instead of SaBoolT [#713] Since bool is a fundamental datatype in C++ let's use it changeset 5608f9a1cbf22ce25717eadfd5f2d715465fff1d Author: Hans Nordeback <[email protected]> Date: Tue, 14 Jan 2014 10:06:59 +0100 amfd: use std::vector to replace realloc [#713] changeset a025b0dc464948d6bba88099e0332bb5268de7f3 Author: Hans Nordeback <[email protected]> Date: Tue, 14 Jan 2014 10:11:54 +0100 amfnd: use std::vector instead of realloc [#713] Added Files: ------------ osaf/services/infrastructure/dtms/scripts/osaf-transport osaf/services/infrastructure/dtms/scripts/osaf-transport-monitor osaf/services/infrastructure/nid/scripts/configure_tipc Complete diffstat: ------------------ osaf/services/infrastructure/dtms/scripts/osaf-transport | 173 +++++++++++++++++++++++++++++++++++++++++++ osaf/services/infrastructure/dtms/scripts/osaf-transport-monitor | 82 ++++++++++++++++++++ osaf/services/infrastructure/nid/scripts/configure_tipc | 211 +++++++++++++++++++++++++++++++++++++++++++++++++++++ osaf/services/saf/amf/amfd/apptype.cc | 6 +- osaf/services/saf/amf/amfd/ckpt_updt.cc | 4 +- osaf/services/saf/amf/amfd/clm.cc | 8 +- osaf/services/saf/amf/amfd/cluster.cc | 2 +- osaf/services/saf/amf/amfd/comp.cc | 20 ++-- osaf/services/saf/amf/amfd/comptype.cc | 8 +- osaf/services/saf/amf/amfd/csi.cc | 18 ++-- osaf/services/saf/amf/amfd/csiattr.cc | 1 - osaf/services/saf/amf/amfd/cstype.cc | 6 +- osaf/services/saf/amf/amfd/dmsg.cc | 2 +- osaf/services/saf/amf/amfd/include/amfd.h | 1 - osaf/services/saf/amf/amfd/include/cb.h | 4 +- osaf/services/saf/amf/amfd/include/ckpt.h | 2 +- osaf/services/saf/amf/amfd/include/comp.h | 2 +- osaf/services/saf/amf/amfd/include/csi.h | 2 +- osaf/services/saf/amf/amfd/include/msg.h | 2 +- osaf/services/saf/amf/amfd/include/node.h | 7 +- osaf/services/saf/amf/amfd/include/sg.h | 10 +- osaf/services/saf/amf/amfd/include/su.h | 2 +- osaf/services/saf/amf/amfd/include/susi.h | 4 +- osaf/services/saf/amf/amfd/include/util.h | 2 - osaf/services/saf/amf/amfd/main.cc | 2 +- osaf/services/saf/amf/amfd/ndfsm.cc | 2 +- osaf/services/saf/amf/amfd/node.cc | 22 ++-- osaf/services/saf/amf/amfd/role.cc | 52 ++++++------ osaf/services/saf/amf/amfd/sg.cc | 26 +++--- osaf/services/saf/amf/amfd/sg_2n_fsm.cc | 22 ++-- osaf/services/saf/amf/amfd/sg_nored_fsm.cc | 12 +- osaf/services/saf/amf/amfd/sg_npm_fsm.cc | 54 ++++++------ osaf/services/saf/amf/amfd/sg_nway_fsm.cc | 24 +++--- osaf/services/saf/amf/amfd/sg_nwayact_fsm.cc | 12 +- osaf/services/saf/amf/amfd/sgproc.cc | 16 ++-- osaf/services/saf/amf/amfd/sgtype.cc | 26 +++--- osaf/services/saf/amf/amfd/si.cc | 2 +- osaf/services/saf/amf/amfd/siass.cc | 2 +- osaf/services/saf/amf/amfd/su.cc | 28 +++--- osaf/services/saf/amf/amfd/sutype.cc | 14 +- osaf/services/saf/amf/amfd/svctype.cc | 6 +- osaf/services/saf/amf/amfnd/clc.cc | 6 +- osaf/services/saf/amf/amfnd/clm.cc | 8 +- osaf/services/saf/amf/amfnd/comp.cc | 4 +- osaf/services/saf/amf/amfnd/compdb.cc | 14 +-- osaf/services/saf/amf/amfnd/di.cc | 2 +- osaf/services/saf/amf/amfnd/err.cc | 4 +- osaf/services/saf/amf/amfnd/include/avnd_cb.h | 2 +- osaf/services/saf/amf/amfnd/include/avnd_comp.h | 2 +- osaf/services/saf/amf/amfnd/susm.cc | 1 - osaf/services/saf/amf/amfnd/term.cc | 2 +- 51 files changed, 700 insertions(+), 246 deletions(-) Testing Commands: ----------------- <<LIST THE COMMAND LINE TOOLS/STEPS TO TEST YOUR CHANGES>> Testing, Expected Results: -------------------------- <<PASTE COMMAND OUTPUTS / TEST RESULTS>> Conditions of Submission: ------------------------- <<HOW MANY DAYS BEFORE PUSHING, CONSENSUS ETC>> Arch Built Started Linux distro ------------------------------------------- mips n n mips64 n n x86 n n x86_64 y n powerpc n n powerpc64 n n Reviewer Checklist: ------------------- [Submitters: make sure that your review doesn't trigger any checkmarks!] Your checkin has not passed review because (see checked entries): ___ Your RR template is generally incomplete; it has too many blank entries that need proper data filled in. ___ You have failed to nominate the proper persons for review and push. ___ Your patches do not have proper short+long header ___ You have grammar/spelling in your header that is unacceptable. ___ You have exceeded a sensible line length in your headers/comments/text. ___ You have failed to put in a proper Trac Ticket # into your commits. ___ You have incorrectly put/left internal data in your comments/files (i.e. internal bug tracking tool IDs, product names etc) ___ You have not given any evidence of testing beyond basic build tests. Demonstrate some level of runtime or other sanity testing. ___ You have ^M present in some of your files. These have to be removed. ___ You have needlessly changed whitespace or added whitespace crimes like trailing spaces, or spaces before tabs. ___ You have mixed real technical changes with whitespace and other cosmetic code cleanup changes. These have to be separate commits. ___ You need to refactor your submission into logical chunks; there is too much content into a single commit. ___ You have extraneous garbage in your review (merge commits etc) ___ You have giant attachments which should never have been sent; Instead you should place your content in a public tree to be pulled. ___ You have too many commits attached to an e-mail; resend as threaded commits, or place in a public tree for a pull. ___ You have resent this content multiple times without a clear indication of what has changed between each re-send. ___ You have failed to adequately and individually address all of the comments and change requests that were proposed in the initial review. ___ You have a misconfigured ~/.hgrc file (i.e. username, email etc) ___ Your computer have a badly configured date and time; confusing the the threaded patch review. ___ Your changes affect IPC mechanism, and you don't present any results for in-service upgradability test. ___ Your changes affect user manual and documentation, your patch series do not contain the patch that updates the Doxygen manual. ------------------------------------------------------------------------------ CenturyLink Cloud: The Leader in Enterprise Cloud Services. Learn Why More Businesses Are Choosing CenturyLink Cloud For Critical Workloads, Development Environments & Everything In Between. Get a Quote or Start a Free Trial Today. http://pubads.g.doubleclick.net/gampad/clk?id=119420431&iu=/4140/ostg.clktrk _______________________________________________ Opensaf-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/opensaf-devel
