Summary: osaf: increase csisetcallback timeout for services using saflog (CLM, NTF)[#720] Review request for Trac Ticket(s): #720 Peer Reviewer(s): praveen, ramesh Pull request to: <<LIST THE PERSON WITH PUSH ACCESS HERE>> Affected branch(es): 4.2, 4.3 Development branch: <<IF ANY GIVE THE REPO URL>>
-------------------------------- Impacted area Impact y/n -------------------------------- Docs n Build system n RPM/packaging n Configuration files n Startup scripts n SAF services y OpenSAF services n Core libraries n Samples n Tests n Other n Comments (indicate scope for each "y" above): --------------------------------------------- See below. This change is not necessary in newer releases because the a separate thread for file operations has been introduced in LGS. changeset 00896f749ea98c70cbe8e1b292992c2609c203e9 Author: Mathivanan N.P.<[email protected]> Date: Fri, 17 Jan 2014 16:07:55 +0530 osaf: increase csisetcallback timeout for services using saflog (CLM, NTF) [#720] It has been observed (in pre 4.4) on field that a client of LOG (in the specific case - CLM, but in general all LOG API users) can get blocked when calling saflog() or LOG() because the LGS was busy doing a file operation. The current MDS API timeout is 10 seconds and the csisetcallback timeout for all(except SMF has about 30 seconds) services is 10 seconds. in the worst case scenario, the saflog() internal utility can take 30 seconds before returning, i.e. saflog internally calls three synchronous apis. This patch changes the csisetcallback timeout to 40 seconds. Complete diffstat: ------------------ osaf/services/saf/clmsv/config/clmsv_objects.xml | 4 ++-- osaf/services/saf/ntfsv/config/ntfsv_objects.xml | 2 +- 2 files changed, 3 insertions(+), 3 deletions(-) Testing Commands: ----------------- Testing, Expected Results: -------------------------- Conditions of Submission: ------------------------- Ack from Praveen(ntfsv) and Ramesh(clm) Arch Built Started Linux distro ------------------------------------------- mips n n mips64 n n x86 n n x86_64 y y powerpc n n powerpc64 n n Reviewer Checklist: ------------------- [Submitters: make sure that your review doesn't trigger any checkmarks!] Your checkin has not passed review because (see checked entries): ___ Your RR template is generally incomplete; it has too many blank entries that need proper data filled in. ___ You have failed to nominate the proper persons for review and push. ___ Your patches do not have proper short+long header ___ You have grammar/spelling in your header that is unacceptable. ___ You have exceeded a sensible line length in your headers/comments/text. ___ You have failed to put in a proper Trac Ticket # into your commits. ___ You have incorrectly put/left internal data in your comments/files (i.e. internal bug tracking tool IDs, product names etc) ___ You have not given any evidence of testing beyond basic build tests. Demonstrate some level of runtime or other sanity testing. ___ You have ^M present in some of your files. These have to be removed. ___ You have needlessly changed whitespace or added whitespace crimes like trailing spaces, or spaces before tabs. ___ You have mixed real technical changes with whitespace and other cosmetic code cleanup changes. These have to be separate commits. ___ You need to refactor your submission into logical chunks; there is too much content into a single commit. ___ You have extraneous garbage in your review (merge commits etc) ___ You have giant attachments which should never have been sent; Instead you should place your content in a public tree to be pulled. ___ You have too many commits attached to an e-mail; resend as threaded commits, or place in a public tree for a pull. ___ You have resent this content multiple times without a clear indication of what has changed between each re-send. ___ You have failed to adequately and individually address all of the comments and change requests that were proposed in the initial review. ___ You have a misconfigured ~/.hgrc file (i.e. username, email etc) ___ Your computer have a badly configured date and time; confusing the the threaded patch review. ___ Your changes affect IPC mechanism, and you don't present any results for in-service upgradability test. ___ Your changes affect user manual and documentation, your patch series do not contain the patch that updates the Doxygen manual. ------------------------------------------------------------------------------ CenturyLink Cloud: The Leader in Enterprise Cloud Services. Learn Why More Businesses Are Choosing CenturyLink Cloud For Critical Workloads, Development Environments & Everything In Between. Get a Quote or Start a Free Trial Today. http://pubads.g.doubleclick.net/gampad/clk?id=119420431&iu=/4140/ostg.clktrk _______________________________________________ Opensaf-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/opensaf-devel
