Fine /Hans > -----Original Message----- > From: Nagendra Kumar [mailto:[email protected]] > Sent: den 22 januari 2014 12:53 > To: Hans Feldt > Cc: Hans Feldt; Hans Nordebäck; Praveen Malviya; > [email protected] > Subject: RE: [devel] [PATCH 1 of 1] amfnd: ignore health check response if > corresponding rec is not found [#732] > > Hi, > My fix is generic in the sense all the conditions whether pres state is > instantiated or restarting. I would pick the comments on > commit message and push it. > > Thanks > -Nagu > > > -----Original Message----- > > From: Hans Feldt [mailto:[email protected]] > > Sent: 22 January 2014 12:39 > > To: Nagendra Kumar > > Cc: Hans Feldt; Hans Nordeback; praveen malviya; opensaf- > > [email protected] > > Subject: Re: [devel] [PATCH 1 of 1] amfnd: ignore health check response if > > corresponding rec is not found [#732] > > > > changelog (commit message) is missing symptom, reason and fix > > > > I think a better slogan would be "amfnd: ignore healthcheck command response > > for terminated component" > > > > avnd_comp_hc_cmd_restart() is used in one place. So should we consider > > putting a guard outside it instead? > > Like: > > if (comp->pres == INSTANTIATED) > > avnd_comp_hc_cmd_restart(comp) > > > > Thanks, > > Hans > > > > On 22 January 2014 07:07, <[email protected]> wrote: > > > osaf/services/saf/amf/amfnd/chc.cc | 5 +++-- > > > 1 files changed, 3 insertions(+), 2 deletions(-) > > > > > > > > > diff --git a/osaf/services/saf/amf/amfnd/chc.cc > > > b/osaf/services/saf/amf/amfnd/chc.cc > > > --- a/osaf/services/saf/amf/amfnd/chc.cc > > > +++ b/osaf/services/saf/amf/amfnd/chc.cc > > > @@ -777,8 +777,9 @@ static AVND_COMP_HC_REC *find_hc_rec(con void > > > avnd_comp_hc_cmd_restart(AVND_COMP *comp) { > > > AVND_COMP_HC_REC *rec = find_hc_rec(comp); > > > - > > > - osafassert(rec); > > > + /* This may come because of script responding after component was > > terminated by lock-in. */ > > > + if(rec == NULL) > > > + return; > > > > > > if (rec->status == AVND_COMP_HC_STATUS_SND_TMR_EXPD) { > > > uint32_t rc = avnd_start_tmr(avnd_cb, &rec->tmr, > > > AVND_TMR_HC, rec->period, rec->opq_hdl); > > > > > > ---------------------------------------------------------------------- > > > -------- CenturyLink Cloud: The Leader in Enterprise Cloud Services. > > > Learn Why More Businesses Are Choosing CenturyLink Cloud For Critical > > > Workloads, Development Environments & Everything In Between. > > > Get a Quote or Start a Free Trial Today. > > > http://pubads.g.doubleclick.net/gampad/clk?id=119420431&iu=/4140/ostg. > > > clktrk _______________________________________________ > > > Opensaf-devel mailing list > > > [email protected] > > > https://lists.sourceforge.net/lists/listinfo/opensaf-devel
------------------------------------------------------------------------------ CenturyLink Cloud: The Leader in Enterprise Cloud Services. Learn Why More Businesses Are Choosing CenturyLink Cloud For Critical Workloads, Development Environments & Everything In Between. Get a Quote or Start a Free Trial Today. http://pubads.g.doubleclick.net/gampad/clk?id=119420431&iu=/4140/ostg.clktrk _______________________________________________ Opensaf-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/opensaf-devel
