Summary: Fix wrong log from amfnd Review request for Trac Ticket(s): 741 Peer Reviewer(s): Praveen Pull request to: <<LIST THE PERSON WITH PUSH ACCESS HERE>> Affected branch(es): All Development branch: <<IF ANY GIVE THE REPO URL>>
-------------------------------- Impacted area Impact y/n -------------------------------- Docs n Build system n RPM/packaging n Configuration files n Startup scripts n SAF services y OpenSAF services n Core libraries n Samples n Tests n Other n Comments (indicate scope for each "y" above): --------------------------------------------- changeset d7da0bd8a6d91410c074a5cdfcfab14194f59ef6 Author: Hans Feldt <[email protected]> Date: Fri, 24 Jan 2014 07:50:04 +0100 amfnd: guard failed state file removal [#741] When SGAutoRepair is enabled and performed the following syslog can be observed: Jan 24 07:41:57 Vostro osafamfnd[17227]: ER cannot unlink failed state file /var/run/opensaf/amf_failed_state: No such file or directory The same happens when repairing an SU in INSTANTIATION-FAILED state. The reason for this that the failed-state file removal is done in all cases. The patch protects the failed-state file removal so that it is only done in the case of the SU being in presence state TERMINATION-FAILED (which is the only state the file can exist in). Complete diffstat: ------------------ osaf/services/saf/amf/amfnd/su.cc | 6 ++++-- 1 files changed, 4 insertions(+), 2 deletions(-) Testing Commands: ----------------- Set default err rec in AMF demo to 3 (comp failover) Start single node cluster and load AppConfig-2N.xml Unlock both SUs kill active demo process Testing, Expected Results: -------------------------- no "cannot unlink failed state" log with patch Conditions of Submission: ------------------------- Ack from Praveen Arch Built Started Linux distro ------------------------------------------- mips n n mips64 n n x86 n n x86_64 y y ubuntu13.10 powerpc n n powerpc64 n n Reviewer Checklist: ------------------- [Submitters: make sure that your review doesn't trigger any checkmarks!] Your checkin has not passed review because (see checked entries): ___ Your RR template is generally incomplete; it has too many blank entries that need proper data filled in. ___ You have failed to nominate the proper persons for review and push. ___ Your patches do not have proper short+long header ___ You have grammar/spelling in your header that is unacceptable. ___ You have exceeded a sensible line length in your headers/comments/text. ___ You have failed to put in a proper Trac Ticket # into your commits. ___ You have incorrectly put/left internal data in your comments/files (i.e. internal bug tracking tool IDs, product names etc) ___ You have not given any evidence of testing beyond basic build tests. Demonstrate some level of runtime or other sanity testing. ___ You have ^M present in some of your files. These have to be removed. ___ You have needlessly changed whitespace or added whitespace crimes like trailing spaces, or spaces before tabs. ___ You have mixed real technical changes with whitespace and other cosmetic code cleanup changes. These have to be separate commits. ___ You need to refactor your submission into logical chunks; there is too much content into a single commit. ___ You have extraneous garbage in your review (merge commits etc) ___ You have giant attachments which should never have been sent; Instead you should place your content in a public tree to be pulled. ___ You have too many commits attached to an e-mail; resend as threaded commits, or place in a public tree for a pull. ___ You have resent this content multiple times without a clear indication of what has changed between each re-send. ___ You have failed to adequately and individually address all of the comments and change requests that were proposed in the initial review. ___ You have a misconfigured ~/.hgrc file (i.e. username, email etc) ___ Your computer have a badly configured date and time; confusing the the threaded patch review. ___ Your changes affect IPC mechanism, and you don't present any results for in-service upgradability test. ___ Your changes affect user manual and documentation, your patch series do not contain the patch that updates the Doxygen manual. ------------------------------------------------------------------------------ CenturyLink Cloud: The Leader in Enterprise Cloud Services. Learn Why More Businesses Are Choosing CenturyLink Cloud For Critical Workloads, Development Environments & Everything In Between. Get a Quote or Start a Free Trial Today. http://pubads.g.doubleclick.net/gampad/clk?id=119420431&iu=/4140/ostg.clktrk _______________________________________________ Opensaf-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/opensaf-devel
