Nack. Applier's Validations are necessary as done in 
ccb_completed_modify_hdlr() of comp.cc.

Thanks
-Nagu

> -----Original Message-----
> From: Hans Feldt [mailto:[email protected]]
> Sent: 07 January 2014 02:25
> To: Nagendra Kumar
> Cc: [email protected]
> Subject: [PATCH 1 of 2] amfd: allow changes to comptype [#539]
> 
>  osaf/services/saf/amf/amfd/comptype.cc |  6 +++++-
>  1 files changed, 5 insertions(+), 1 deletions(-)
> 
> 
> diff --git a/osaf/services/saf/amf/amfd/comptype.cc
> b/osaf/services/saf/amf/amfd/comptype.cc
> --- a/osaf/services/saf/amf/amfd/comptype.cc
> +++ b/osaf/services/saf/amf/amfd/comptype.cc
> @@ -363,6 +363,9 @@ static void comptype_ccb_apply_cb(CcbUti
>       case CCBUTIL_DELETE:
>               comptype_delete(static_cast<AVD_COMP_TYPE*>(opdata-
> >userData));
>               break;
> +     case CCBUTIL_MODIFY:
> +             // values not used, no need to reinitialize type
> +             break;
>       default:
>               osafassert(0);
>               break;
> @@ -387,7 +390,8 @@ static SaAisErrorT comptype_ccb_complete
>                       rc = SA_AIS_OK;
>               break;
>       case CCBUTIL_MODIFY:
> -             report_ccb_validation_error(opdata, "Modification of
> SaAmfCompType not supported");
> +             // modifications are OK, node director re-reads type every now
> and then
> +             rc = SA_AIS_OK;
>               break;
>       case CCBUTIL_DELETE:
>               comp_type = avd_comptype_get(&opdata->objectName);

------------------------------------------------------------------------------
Managing the Performance of Cloud-Based Applications
Take advantage of what the Cloud has to offer - Avoid Common Pitfalls.
Read the Whitepaper.
http://pubads.g.doubleclick.net/gampad/clk?id=121051231&iu=/4140/ostg.clktrk
_______________________________________________
Opensaf-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/opensaf-devel

Reply via email to