Hi,
I shall be pushing the patch today.
Thanks,
Mathi.
-----Original Message-----
From: Mathivanan Naickan Palanivelu
Sent: Monday, February 03, 2014 2:35 PM
To: hans.fe...@ericsson.com; lennart.l...@ericsson.com; Praveen Malviya
Cc: opensaf-devel@lists.sourceforge.net
Subject: [devel] [PATCH 0 of 4] Review Request for osaf: add safloginit routine
and call early during init of clm, ntf - v2.0
Summary: osaf: add new safloginit routine and call early during init of clm,
ntf - v2.0 [#720] Review request for Trac Ticket(s): #720 Peer Reviewer(s):
HansF, Praveen, Lennart Pull request to: <<LIST THE PERSON WITH PUSH ACCESS
HERE>> Affected branch(es): all branches Development branch: <<IF ANY GIVE THE
REPO URL>>
--------------------------------
Impacted area Impact y/n
--------------------------------
Docs n
Build system n
RPM/packaging n
Configuration files n
Startup scripts n
SAF services y
OpenSAF services n
Core libraries n
Samples n
Tests n
Other n
Comments (indicate scope for each "y" above):
---------------------------------------------
changeset 5f5abccad4122898dfba9ae29600b25b644d4b13
Author: mathi.naic...@oracle.com
Date: Mon, 03 Feb 2014 14:28:15 +0530
osaf: add a new safloginit routine [#720] There can be situations during
switchover/failover when clients of LOG can be blocked because LOG is
busy
doing file i/o. One additional reason is that LOG clients use the common
saflog routine that when called for the first time, does an
initialize() and
streamopen() both of which are synchronous calls and if streamopen()
fails,
saflog does a logfinalize() which is also a synchronous calls. So in a
worst
case scenario, when saflog() is called by a standby process that is
becoming
active, then saflog() can get blocked for <=30 seconds before it returns
back to the caller, i.e. mds send timeout of 10 seconds X 3 synchronous
APIs. This patch adds a separate safloginit() routine that can be used
by
saflog() users such that it is called much before during their lifetime
than
during role change.
changeset 3ff012a78dbac108602459aa85d80a4fb391beaf
Author: mathi.naic...@oracle.com
Date: Mon, 03 Feb 2014 14:29:38 +0530
clm: initialize saflog() early during clm init [#720] This is necessary
to
avoid blocking in saflog during role changes.
changeset c6f1c6e4e4cb84632d2324a7473bc31e483494c4
Author: mathi.naic...@oracle.com
Date: Mon, 03 Feb 2014 14:29:49 +0530
ntf: initialize saflog() early during clm init [#720] This is necessary
to
avoid blocking in saflog during role changes.
changeset 234ee4c8a9079546e365230caef8c11ebd7b3014
Author: mathi.naic...@oracle.com
Date: Mon, 03 Feb 2014 14:31:49 +0530
clm and ntf: increase csisetcallback timeout to 40 seconds [#720]
Complete diffstat:
------------------
osaf/services/saf/clmsv/clms/clms_main.c | 6 ++++++
osaf/services/saf/clmsv/config/clmsv_objects.xml | 4 ++--
osaf/services/saf/ntfsv/config/ntfsv_objects.xml | 2 +-
osaf/services/saf/ntfsv/ntfs/Makefile.am | 4 +++-
osaf/services/saf/ntfsv/ntfs/ntfs_main.c | 6 ++++++
osaf/tools/saflog/include/saflog.h | 6 ++++++
osaf/tools/saflog/src/saflog.c | 45
+++++++++++++++++++++++++++++++++++----------
7 files changed, 59 insertions(+), 14 deletions(-)
Testing Commands:
-----------------
Start OpenSAF, loggging shoudl work as usual.
Perform, failover and switchover by simulating file i/o problems.
Testing, Expected Results:
--------------------------
Conditions of Submission:
-------------------------
Ack from Hans or Lennart or Praveen.
Arch Built Started Linux distro
-------------------------------------------
mips n n
mips64 n n
x86 n n
x86_64 n n
powerpc n n
powerpc64 n n
Reviewer Checklist:
-------------------
[Submitters: make sure that your review doesn't trigger any checkmarks!]
Your checkin has not passed review because (see checked entries):
___ Your RR template is generally incomplete; it has too many blank entries
that need proper data filled in.
___ You have failed to nominate the proper persons for review and push.
___ Your patches do not have proper short+long header
___ You have grammar/spelling in your header that is unacceptable.
___ You have exceeded a sensible line length in your headers/comments/text.
___ You have failed to put in a proper Trac Ticket # into your commits.
___ You have incorrectly put/left internal data in your comments/files
(i.e. internal bug tracking tool IDs, product names etc)
___ You have not given any evidence of testing beyond basic build tests.
Demonstrate some level of runtime or other sanity testing.
___ You have ^M present in some of your files. These have to be removed.
___ You have needlessly changed whitespace or added whitespace crimes
like trailing spaces, or spaces before tabs.
___ You have mixed real technical changes with whitespace and other
cosmetic code cleanup changes. These have to be separate commits.
___ You need to refactor your submission into logical chunks; there is
too much content into a single commit.
___ You have extraneous garbage in your review (merge commits etc)
___ You have giant attachments which should never have been sent;
Instead you should place your content in a public tree to be pulled.
___ You have too many commits attached to an e-mail; resend as threaded
commits, or place in a public tree for a pull.
___ You have resent this content multiple times without a clear indication
of what has changed between each re-send.
___ You have failed to adequately and individually address all of the
comments and change requests that were proposed in the initial review.
___ You have a misconfigured ~/.hgrc file (i.e. username, email etc)
___ Your computer have a badly configured date and time; confusing the
the threaded patch review.
___ Your changes affect IPC mechanism, and you don't present any results
for in-service upgradability test.
___ Your changes affect user manual and documentation, your patch series
do not contain the patch that updates the Doxygen manual.
------------------------------------------------------------------------------
Managing the Performance of Cloud-Based Applications Take advantage of what the
Cloud has to offer - Avoid Common Pitfalls.
Read the Whitepaper.
http://pubads.g.doubleclick.net/gampad/clk?id=121051231&iu=/4140/ostg.clktrk
_______________________________________________
Opensaf-devel mailing list
Opensaf-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/opensaf-devel
------------------------------------------------------------------------------
Android apps run on BlackBerry 10
Introducing the new BlackBerry 10.2.1 Runtime for Android apps.
Now with support for Jelly Bean, Bluetooth, Mapview and more.
Get your Android app in front of a whole new audience. Start now.
http://pubads.g.doubleclick.net/gampad/clk?id=124407151&iu=/4140/ostg.clktrk
_______________________________________________
Opensaf-devel mailing list
Opensaf-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/opensaf-devel
