Summary: AMF comp failover correction Review request for Trac Ticket(s): 598 Peer Reviewer(s): Nags Pull request to: <<LIST THE PERSON WITH PUSH ACCESS HERE>> Affected branch(es): 4.4 & default Development branch: default
-------------------------------- Impacted area Impact y/n -------------------------------- Docs n Build system n RPM/packaging n Configuration files n Startup scripts n SAF services y OpenSAF services n Core libraries n Samples n Tests n Other n Comments (indicate scope for each "y" above): --------------------------------------------- The same change already exist in 4.3 but was removed when SU failover support was introduced for 4.4. This patch just reintroduces the same logic. changeset 2d0faab7949461c702c02d75b399dc65a9c8bfbf Author: Hans Feldt <[email protected]> Date: Fri, 14 Feb 2014 13:57:00 +0100 amfnd: report failover after comp cleanup [#598] If a component error is detected and the recovery action is COMPONENT_FAILOVER, it is possible that a standby component gets the active assignment before the erroneous component has been terminated. This can cause a split brain on application level. The reason for this is that when the error is detected amfnd starts two parallel activities, component cleanup and inform director. When the director receives the information it starts the process of failing over the workload of the erroneous component. This patch informs the director after successful termination has been performed. Complete diffstat: ------------------ osaf/services/saf/amf/amfnd/clc.cc | 9 +++++++++ osaf/services/saf/amf/amfnd/di.cc | 2 +- osaf/services/saf/amf/amfnd/err.cc | 9 +++++---- osaf/services/saf/amf/amfnd/include/avnd_di.h | 2 +- 4 files changed, 16 insertions(+), 6 deletions(-) Testing Commands: ----------------- Test comp and SU failover in 2N Testing, Expected Results: -------------------------- Works as expected. Remember it is a timing issue if cleanup is performed before activation of the standby so to actually verify that can be tricky. Conditions of Submission: ------------------------- Ack from Nags Arch Built Started Linux distro ------------------------------------------- mips n n mips64 n n x86 n n x86_64 n n powerpc n n powerpc64 n n Reviewer Checklist: ------------------- [Submitters: make sure that your review doesn't trigger any checkmarks!] Your checkin has not passed review because (see checked entries): ___ Your RR template is generally incomplete; it has too many blank entries that need proper data filled in. ___ You have failed to nominate the proper persons for review and push. ___ Your patches do not have proper short+long header ___ You have grammar/spelling in your header that is unacceptable. ___ You have exceeded a sensible line length in your headers/comments/text. ___ You have failed to put in a proper Trac Ticket # into your commits. ___ You have incorrectly put/left internal data in your comments/files (i.e. internal bug tracking tool IDs, product names etc) ___ You have not given any evidence of testing beyond basic build tests. Demonstrate some level of runtime or other sanity testing. ___ You have ^M present in some of your files. These have to be removed. ___ You have needlessly changed whitespace or added whitespace crimes like trailing spaces, or spaces before tabs. ___ You have mixed real technical changes with whitespace and other cosmetic code cleanup changes. These have to be separate commits. ___ You need to refactor your submission into logical chunks; there is too much content into a single commit. ___ You have extraneous garbage in your review (merge commits etc) ___ You have giant attachments which should never have been sent; Instead you should place your content in a public tree to be pulled. ___ You have too many commits attached to an e-mail; resend as threaded commits, or place in a public tree for a pull. ___ You have resent this content multiple times without a clear indication of what has changed between each re-send. ___ You have failed to adequately and individually address all of the comments and change requests that were proposed in the initial review. ___ You have a misconfigured ~/.hgrc file (i.e. username, email etc) ___ Your computer have a badly configured date and time; confusing the the threaded patch review. ___ Your changes affect IPC mechanism, and you don't present any results for in-service upgradability test. ___ Your changes affect user manual and documentation, your patch series do not contain the patch that updates the Doxygen manual. ------------------------------------------------------------------------------ Android apps run on BlackBerry 10 Introducing the new BlackBerry 10.2.1 Runtime for Android apps. Now with support for Jelly Bean, Bluetooth, Mapview and more. Get your Android app in front of a whole new audience. Start now. http://pubads.g.doubleclick.net/gampad/clk?id=124407151&iu=/4140/ostg.clktrk _______________________________________________ Opensaf-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/opensaf-devel
