Will send a new patch "shortly". I will discriminate on the error code and report "validation error" only if the OI replied with ERR_BAD_OPERATION. For the other valid erro codes NO_RESOURCES and NO_MEMORY I will report "resource error". Asa bonus I will also include the implementer-name.
Timeout and disconnect are not handled in the callback-reply logic. So will let them be as is for now. The final ccb abort printout I will keep as in the current patch, i.e. reduce severity from WArning to NOtice. An aborted CCB is after all no indication of any systemic problem. /AndersBj Anders Bjornerstedt wrote: > I will add the term 'validation error' into the syslog message > stemming from the completed continuation. > Note that according to the spec, the oi can reply on the completed > callback with error codes BAD_OPERATION, > NO_RESOURCES or NO_MEMORY. > Any other error code will be converted to FAILED_OPERATION by the > library. The callback may also fail due to > timeout or because the OI detached. In addition there may be many OIs > involved in the completed phase of a CCB. > But If the reply is received and it is not SA_AIS_OK I will report > 'validation error'. > > The second log message is in the abort logic of he CCB. > You end up with two here because a CCB may get aborted without some or > all callbacks having replied. > > /AndersBj > > > Hans Feldt wrote: >> Now the syslog message looks like this: >> Feb 14 15:26:59 SC-1 osafimmnd[1095]: NO Implementer returned error >> on ccb-completed-callback, Ccb 3 will be aborted >> >> I would like to see the word "validation" in the log which is what is >> used in the specification: >> >> SA_AIS_ERR_BAD_OPERATION - The validation by the implementer process >> of all >> change requests contained in the CCB failed. >> >> And other places. How about " Implementer validation failed in >> ccb-completed-callback, Ccb 3 will be aborted" >> >> /Hans >> >> >>> -----Original Message----- >>> From: Anders Björnerstedt >>> Sent: den 14 februari 2014 15:15 >>> To: [email protected]; Hans Feldt >>> Cc: [email protected] >>> Subject: [PATCH 1 of 1] IMM: Improved logging at CCB validation >>> error [#669] >>> >>> osaf/services/saf/immsv/immnd/ImmModel.cc | 12 +++++------- >>> 1 files changed, 5 insertions(+), 7 deletions(-) >>> >>> >>> diff --git a/osaf/services/saf/immsv/immnd/ImmModel.cc >>> b/osaf/services/saf/immsv/immnd/ImmModel.cc >>> --- a/osaf/services/saf/immsv/immnd/ImmModel.cc >>> +++ b/osaf/services/saf/immsv/immnd/ImmModel.cc >>> @@ -3972,26 +3972,25 @@ ImmModel::ccbAbort(SaUint32T ccbId, Conn >>> case IMM_CCB_READY: >>> break; //OK >>> case IMM_CCB_CREATE_OP: >>> - LOG_WA("Aborting ccb %u while waiting for " >>> + LOG_NO("Aborting ccb %u while waiting for " >>> "reply from implementer on CREATE-OP", ccbId); >>> *client = ccb->mOriginatingConn; >>> break; >>> >>> case IMM_CCB_MODIFY_OP: >>> - LOG_WA("Aborting ccb %u while waiting for " >>> + LOG_NO("Aborting ccb %u while waiting for " >>> "reply from implementers on MODIFY-OP", ccbId); >>> *client = ccb->mOriginatingConn; >>> break; >>> >>> case IMM_CCB_DELETE_OP: >>> - LOG_WA("Aborting ccb %u while waiting for " >>> + LOG_NO("Aborting ccb %u while waiting for " >>> "replies from implementers on DELETE-OP", ccbId); >>> *client = ccb->mOriginatingConn; >>> break; >>> >>> case IMM_CCB_PREPARE: >>> - LOG_WA("Aborting ccb %u while waiting for " >>> - "replies from implementers on COMPLETED", ccbId); >>> + LOG_NO("Ccb %u aborted in COMPLETED processing", ccbId); >>> *client = ccb->mOriginatingConn; >>> break; >>> >>> @@ -6719,8 +6718,7 @@ ImmModel::ccbCompletedContinuation(immsv >>> >>> if(rsp->result != SA_AIS_OK) { >>> if(ccb->mVeto == SA_AIS_OK) { >>> - LOG_IN("implementer returned error, Ccb aborted >>> with error: %u", >>> - rsp->result); >>> + LOG_NO("Implementer returned error on >>> ccb-completed-callback, Ccb %u will be aborted", ccbId); >>> ccb->mVeto = SA_AIS_ERR_FAILED_OPERATION; >>> } >>> >>> > > > ------------------------------------------------------------------------------ Android apps run on BlackBerry 10 Introducing the new BlackBerry 10.2.1 Runtime for Android apps. Now with support for Jelly Bean, Bluetooth, Mapview and more. Get your Android app in front of a whole new audience. Start now. http://pubads.g.doubleclick.net/gampad/clk?id=124407151&iu=/4140/ostg.clktrk _______________________________________________ Opensaf-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/opensaf-devel
