Summary: amfd: Ensure HA state notification is sent when a SI is first assigned
to a SU [#544]
Review request for Trac Ticket(s): 544
Peer Reviewer(s): Hans F, Hans N, Nagendra
Pull request to:
Affected branch(es): default
Development branch: default
--------------------------------
Impacted area Impact y/n
--------------------------------
Docs n
Build system n
RPM/packaging n
Configuration files n
Startup scripts n
SAF services y
OpenSAF services n
Core libraries n
Samples n
Tests n
Other n
Comments (indicate scope for each "y" above):
---------------------------------------------
changeset c5e9c0567f4236a809d38eee8d6a822dc9c53008
Author: Gary Lee <gary....@dektech.com.au>
Date: Fri, 28 Feb 2014 15:12:13 +1100
amfd: Ensure HA state notification is sent when a SI is first assigned
to a
SU [#544]
Complete diffstat:
------------------
osaf/services/saf/amf/amfd/siass.cc | 1 +
1 files changed, 1 insertions(+), 0 deletions(-)
Testing Commands:
-----------------
Run ntfsubscribe
Run amf_demo
Testing, Expected Results:
--------------------------
Ensure HA state notifications are sent when SI is first assigned to a SU
=== Feb 28 5:16:31 - State Change ===
eventType = SA_NTF_OBJECT_STATE_CHANGE
notificationObject = "safSu=SU1,safSg=AmfDemo,safApp=AmfDemo1"
notifyingObject = "safApp=safAmfService"
notificationClassId = SA_NTF_VENDOR_ID_SAF.SA_SVC_AMF.110 (0x6e)
additionalText = "The HA state of SI safSi=AmfDemo,safApp=AmfDemo1 assigned to
SU safSu=SU1,safSg=AmfDemo,safApp=AmfDemo1 changed"
- additionalInfo: 0 -
infoId = 2
infoType = 10
infoValue = "safSi=AmfDemo,safApp=AmfDemo1"
sourceIndicator = SA_NTF_OBJECT_OPERATION
State ID = SA_AMF_HA_STATE
New State: SA_AMF_HA_ACTIVE
=== Feb 28 5:16:31 - State Change ===
eventType = SA_NTF_OBJECT_STATE_CHANGE
notificationObject = "safSu=SU2,safSg=AmfDemo,safApp=AmfDemo1"
notifyingObject = "safApp=safAmfService"
notificationClassId = SA_NTF_VENDOR_ID_SAF.SA_SVC_AMF.110 (0x6e)
additionalText = "The HA state of SI safSi=AmfDemo,safApp=AmfDemo1 assigned to
SU safSu=SU2,safSg=AmfDemo,safApp=AmfDemo1 changed"
- additionalInfo: 0 -
infoId = 2
infoType = 10
infoValue = "safSi=AmfDemo,safApp=AmfDemo1"
sourceIndicator = SA_NTF_OBJECT_OPERATION
State ID = SA_AMF_HA_STATE
New State: SA_AMF_HA_STANDBY
Conditions of Submission:
-------------------------
<<HOW MANY DAYS BEFORE PUSHING, CONSENSUS ETC>>
Arch Built Started Linux distro
-------------------------------------------
mips n n
mips64 n n
x86 n n
x86_64 y y
powerpc n n
powerpc64 n n
Reviewer Checklist:
-------------------
[Submitters: make sure that your review doesn't trigger any checkmarks!]
Your checkin has not passed review because (see checked entries):
___ Your RR template is generally incomplete; it has too many blank entries
that need proper data filled in.
___ You have failed to nominate the proper persons for review and push.
___ Your patches do not have proper short+long header
___ You have grammar/spelling in your header that is unacceptable.
___ You have exceeded a sensible line length in your headers/comments/text.
___ You have failed to put in a proper Trac Ticket # into your commits.
___ You have incorrectly put/left internal data in your comments/files
(i.e. internal bug tracking tool IDs, product names etc)
___ You have not given any evidence of testing beyond basic build tests.
Demonstrate some level of runtime or other sanity testing.
___ You have ^M present in some of your files. These have to be removed.
___ You have needlessly changed whitespace or added whitespace crimes
like trailing spaces, or spaces before tabs.
___ You have mixed real technical changes with whitespace and other
cosmetic code cleanup changes. These have to be separate commits.
___ You need to refactor your submission into logical chunks; there is
too much content into a single commit.
___ You have extraneous garbage in your review (merge commits etc)
___ You have giant attachments which should never have been sent;
Instead you should place your content in a public tree to be pulled.
___ You have too many commits attached to an e-mail; resend as threaded
commits, or place in a public tree for a pull.
___ You have resent this content multiple times without a clear indication
of what has changed between each re-send.
___ You have failed to adequately and individually address all of the
comments and change requests that were proposed in the initial review.
___ You have a misconfigured ~/.hgrc file (i.e. username, email etc)
___ Your computer have a badly configured date and time; confusing the
the threaded patch review.
___ Your changes affect IPC mechanism, and you don't present any results
for in-service upgradability test.
___ Your changes affect user manual and documentation, your patch series
do not contain the patch that updates the Doxygen manual.
------------------------------------------------------------------------------
Flow-based real-time traffic analytics software. Cisco certified tool.
Monitor traffic, SLAs, QoS, Medianet, WAAS etc. with NetFlow Analyzer
Customize your own dashboards, set traffic alerts and generate reports.
Network behavioral analysis & security monitoring. All-in-one tool.
http://pubads.g.doubleclick.net/gampad/clk?id=126839071&iu=/4140/ostg.clktrk
_______________________________________________
Opensaf-devel mailing list
Opensaf-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/opensaf-devel
