I forgot to update the new OI-callbacks to follow the same pattern, replacing SaNameT* with SaConstStringT.
I will send out a new version of the patch with this corrected. /AndersBj -----Original Message----- From: Anders Bjornerstedt [mailto:[email protected]] Sent: den 12 mars 2014 11:59 To: [email protected]; [email protected] Cc: [email protected] Subject: [devel] [PATCH 0 of 1] Review Request for IMM: OM/OI Replace SaNameT with SaStringT (interface patch) (#643) Summary: IMM: OM/OI Replace SaNameT with SaStringT (interface patch) (#643) Review request for Trac Ticket(s): 642 Peer Reviewer(s): Mathi, Neel Pull request to: Affected branch(es): default(4.5) Development branch: -------------------------------- Impacted area Impact y/n -------------------------------- Docs n Build system n RPM/packaging n Configuration files n Startup scripts n SAF services y OpenSAF services n Core libraries n Samples n Tests n Other n Comments (indicate scope for each "y" above): --------------------------------------------- changeset 69367fc0e7f73a6f87fde79ec5b2857a84b058d7 Author: Anders Bjornerstedt <[email protected]> Date: Wed, 12 Mar 2014 11:42:54 +0100 IMM: OM/OI Replace SaNameT with SaStringT (interface patch) (#643) This patch only contains the new interface (new include files) and stubbed implementations for that new interface, in imma_m_api.c and and imma_oi_api.c. Implementation of the new interface will be provided in a separate patch for this same ticket. The interface patch should compile , but needs the patch for #625 (osaf: Support constant strings in SAF APIs) to be applied first. Added Files: ------------ osaf/libs/saf/include/saImmOi_A_2_14.h osaf/libs/saf/include/saImmOm_A_2_14.h Complete diffstat: ------------------ osaf/libs/agents/saf/imma/imma_oi_api.c | 39 +++++++++++++++++++++++++++++++- osaf/libs/agents/saf/imma/imma_om_api.c | 113 ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++- osaf/libs/saf/include/saImmOi_A_2_11.h | 2 + osaf/libs/saf/include/saImmOi_A_2_14.h | 122 +++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ osaf/libs/saf/include/saImmOm_A_2_13.h | 2 + osaf/libs/saf/include/saImmOm_A_2_14.h | 166 ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ 6 files changed, 441 insertions(+), 3 deletions(-) Testing Commands: ----------------- Not a full implementation of the new interface. The implementation should be trivial and should only impact the library code. This review request is intended to allow review of the interface as such. Testing, Expected Results: -------------------------- To compile it needs to be pushed on top of the patch for #625 saf: Support constant strings in SAF APIs. That patch is currently also out on review. Version checking for A.02.14 has not been included in the stubbed implementation. Conditions of Submission: ------------------------- Prior ack on the patch for #625. Ack from Neel or Mathi for this patch. No objections from other OpenSAF developers. This interface patch will not be pushed on ack. Ack instead means we will go ahead and do the implementation. Then send the implementation out for a separate regular review. When/if the implementation gets an ack on that future review, then both the interface and the implementation patches will be pushed. Arch Built Started Linux distro ------------------------------------------- mips n n mips64 n n x86 n n x86_64 n n powerpc n n powerpc64 n n Reviewer Checklist: ------------------- [Submitters: make sure that your review doesn't trigger any checkmarks!] Your checkin has not passed review because (see checked entries): ___ Your RR template is generally incomplete; it has too many blank entries that need proper data filled in. ___ You have failed to nominate the proper persons for review and push. ___ Your patches do not have proper short+long header ___ You have grammar/spelling in your header that is unacceptable. ___ You have exceeded a sensible line length in your headers/comments/text. ___ You have failed to put in a proper Trac Ticket # into your commits. ___ You have incorrectly put/left internal data in your comments/files (i.e. internal bug tracking tool IDs, product names etc) ___ You have not given any evidence of testing beyond basic build tests. Demonstrate some level of runtime or other sanity testing. ___ You have ^M present in some of your files. These have to be removed. ___ You have needlessly changed whitespace or added whitespace crimes like trailing spaces, or spaces before tabs. ___ You have mixed real technical changes with whitespace and other cosmetic code cleanup changes. These have to be separate commits. ___ You need to refactor your submission into logical chunks; there is too much content into a single commit. ___ You have extraneous garbage in your review (merge commits etc) ___ You have giant attachments which should never have been sent; Instead you should place your content in a public tree to be pulled. ___ You have too many commits attached to an e-mail; resend as threaded commits, or place in a public tree for a pull. ___ You have resent this content multiple times without a clear indication of what has changed between each re-send. ___ You have failed to adequately and individually address all of the comments and change requests that were proposed in the initial review. ___ You have a misconfigured ~/.hgrc file (i.e. username, email etc) ___ Your computer have a badly configured date and time; confusing the the threaded patch review. ___ Your changes affect IPC mechanism, and you don't present any results for in-service upgradability test. ___ Your changes affect user manual and documentation, your patch series do not contain the patch that updates the Doxygen manual. ------------------------------------------------------------------------------ Learn Graph Databases - Download FREE O'Reilly Book "Graph Databases" is the definitive new guide to graph databases and their applications. Written by three acclaimed leaders in the field, this first edition is now available. Download your free book today! http://p.sf.net/sfu/13534_NeoTech _______________________________________________ Opensaf-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/opensaf-devel ------------------------------------------------------------------------------ Learn Graph Databases - Download FREE O'Reilly Book "Graph Databases" is the definitive new guide to graph databases and their applications. Written by three acclaimed leaders in the field, this first edition is now available. Download your free book today! http://p.sf.net/sfu/13534_NeoTech _______________________________________________ Opensaf-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/opensaf-devel
