Summary: amfd: use job queue for IMM admin response [#817]
Review request for Trac Ticket(s): 817
Peer Reviewer(s): Hans F, Hans N, Nagendra
Pull request to:
Affected branch(es): default
Development branch: default
--------------------------------
Impacted area Impact y/n
--------------------------------
Docs n
Build system n
RPM/packaging n
Configuration files n
Startup scripts n
SAF services y
OpenSAF services n
Core libraries n
Samples n
Tests n
Other n
Comments (indicate scope for each "y" above):
---------------------------------------------
changeset cd039d9f162b401419b1b0665190ceec20169846
Author: Gary Lee <gary....@dektech.com.au>
Date: Mon, 31 Mar 2014 14:57:48 +1100
amfd: use job queue for IMM admin response [#817]
Currently, admin operation responses from amfd are not synchronised
with IMM
changes that may be performed as part of the admin operation. That is,
an
admin operation may return before the corresponding IMM changes have
been
performed. IMM changes by amfd are typically placed into a FIFO queue
to be
done at a later time.
This patch puts admin operation responses into the same queue. Therefore
guaranteeing that when an admin operation returns, the corresponding IMM
changes have already been done.
changeset 84a63fdf1247eb6173b197da324431df529608fe
Author: Gary Lee <gary....@dektech.com.au>
Date: Mon, 31 Mar 2014 14:58:19 +1100
amfd: Remove unnecessary traces [#817]
Complete diffstat:
------------------
osaf/services/saf/amf/amfd/imm.cc | 66
+++++++++++++++++++++++++++++++++---------------------------------
osaf/services/saf/amf/amfd/include/imm.h | 18 +++++++++++++++++-
2 files changed, 50 insertions(+), 34 deletions(-)
Testing Commands:
-----------------
<<LIST THE COMMAND LINE TOOLS/STEPS TO TEST YOUR CHANGES>>
Testing, Expected Results:
--------------------------
<<PASTE COMMAND OUTPUTS / TEST RESULTS>>
Conditions of Submission:
-------------------------
<<HOW MANY DAYS BEFORE PUSHING, CONSENSUS ETC>>
Arch Built Started Linux distro
-------------------------------------------
mips n n
mips64 n n
x86 n n
x86_64 y y
powerpc n n
powerpc64 n n
Reviewer Checklist:
-------------------
[Submitters: make sure that your review doesn't trigger any checkmarks!]
Your checkin has not passed review because (see checked entries):
___ Your RR template is generally incomplete; it has too many blank entries
that need proper data filled in.
___ You have failed to nominate the proper persons for review and push.
___ Your patches do not have proper short+long header
___ You have grammar/spelling in your header that is unacceptable.
___ You have exceeded a sensible line length in your headers/comments/text.
___ You have failed to put in a proper Trac Ticket # into your commits.
___ You have incorrectly put/left internal data in your comments/files
(i.e. internal bug tracking tool IDs, product names etc)
___ You have not given any evidence of testing beyond basic build tests.
Demonstrate some level of runtime or other sanity testing.
___ You have ^M present in some of your files. These have to be removed.
___ You have needlessly changed whitespace or added whitespace crimes
like trailing spaces, or spaces before tabs.
___ You have mixed real technical changes with whitespace and other
cosmetic code cleanup changes. These have to be separate commits.
___ You need to refactor your submission into logical chunks; there is
too much content into a single commit.
___ You have extraneous garbage in your review (merge commits etc)
___ You have giant attachments which should never have been sent;
Instead you should place your content in a public tree to be pulled.
___ You have too many commits attached to an e-mail; resend as threaded
commits, or place in a public tree for a pull.
___ You have resent this content multiple times without a clear indication
of what has changed between each re-send.
___ You have failed to adequately and individually address all of the
comments and change requests that were proposed in the initial review.
___ You have a misconfigured ~/.hgrc file (i.e. username, email etc)
___ Your computer have a badly configured date and time; confusing the
the threaded patch review.
___ Your changes affect IPC mechanism, and you don't present any results
for in-service upgradability test.
___ Your changes affect user manual and documentation, your patch series
do not contain the patch that updates the Doxygen manual.
------------------------------------------------------------------------------
_______________________________________________
Opensaf-devel mailing list
Opensaf-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/opensaf-devel
