Summary: remove casts
Review request for Trac Ticket(s): 713
Peer Reviewer(s): Hans
Pull request to: <<LIST THE PERSON WITH PUSH ACCESS HERE>>
Affected branch(es): <<LIST ALL AFFECTED BRANCH(ES)>>
Development branch: <<IF ANY GIVE THE REPO URL>>
--------------------------------
Impacted area Impact y/n
--------------------------------
Docs n
Build system n
RPM/packaging n
Configuration files n
Startup scripts n
SAF services n
OpenSAF services n
Core libraries n
Samples n
Tests n
Other n
Comments (indicate scope for each "y" above):
---------------------------------------------
changeset 2387cfedffc26dfc86be3c9abaf5d8b485128888
Author: Hans Feldt <hans.fe...@ericsson.com>
Date: Wed, 02 Apr 2014 06:57:28 +0200
amfd: remove cast from avd_class_impl_set [#713]
changeset a2956add9c05c5bc86b8cb4b1045b61d58b98dc4
Author: Hans Feldt <hans.fe...@ericsson.com>
Date: Wed, 02 Apr 2014 06:57:51 +0200
amfd: remove cast from avd_saImmOiRtObjectUpdate [#713]
changeset 1060e570b0e1793c8fa0aacba5bb8c5dbc5a9b11
Author: Hans Feldt <hans.fe...@ericsson.com>
Date: Wed, 02 Apr 2014 06:58:00 +0200
amfd: remove cast from avd_saImmOiRtObjectCreate [#713]
Complete diffstat:
------------------
osaf/services/saf/amf/amfd/app.cc | 2 +-
osaf/services/saf/amf/amfd/apptype.cc | 6 ++++--
osaf/services/saf/amf/amfd/cluster.cc | 2 +-
osaf/services/saf/amf/amfd/comp.cc | 25 ++++++++++++-------------
osaf/services/saf/amf/amfd/compcstype.cc | 2 +-
osaf/services/saf/amf/amfd/comptype.cc | 8 +++++---
osaf/services/saf/amf/amfd/csi.cc | 6 +++---
osaf/services/saf/amf/amfd/csiattr.cc | 3 ++-
osaf/services/saf/amf/amfd/cstype.cc | 6 ++++--
osaf/services/saf/amf/amfd/ctcstype.cc | 3 ++-
osaf/services/saf/amf/amfd/hlt.cc | 3 ++-
osaf/services/saf/amf/amfd/hlttype.cc | 4 ++--
osaf/services/saf/amf/amfd/imm.cc | 122
++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++--------------------------------------------------------------
osaf/services/saf/amf/amfd/include/imm.h | 6 +++---
osaf/services/saf/amf/amfd/node.cc | 15 ++++++++-------
osaf/services/saf/amf/amfd/nodegroup.cc | 3 ++-
osaf/services/saf/amf/amfd/nodeswbundle.cc | 4 ++--
osaf/services/saf/amf/amfd/sg.cc | 3 ++-
osaf/services/saf/amf/amfd/sgtype.cc | 6 ++++--
osaf/services/saf/amf/amfd/si.cc | 11 ++++++-----
osaf/services/saf/amf/amfd/si_dep.cc | 3 ++-
osaf/services/saf/amf/amfd/siass.cc | 9 +++++----
osaf/services/saf/amf/amfd/sirankedsu.cc | 9 +++++----
osaf/services/saf/amf/amfd/su.cc | 27 ++++++++++++++-------------
osaf/services/saf/amf/amfd/sutcomptype.cc | 3 ++-
osaf/services/saf/amf/amfd/sutype.cc | 6 ++++--
osaf/services/saf/amf/amfd/svctype.cc | 6 ++++--
osaf/services/saf/amf/amfd/svctypecstypes.cc | 3 ++-
28 files changed, 164 insertions(+), 142 deletions(-)
Testing Commands:
-----------------
Build opensaf
Testing, Expected Results:
--------------------------
<<PASTE COMMAND OUTPUTS / TEST RESULTS>>
Conditions of Submission:
-------------------------
<<HOW MANY DAYS BEFORE PUSHING, CONSENSUS ETC>>
Arch Built Started Linux distro
-------------------------------------------
mips n n
mips64 n n
x86 n n
x86_64 n n
powerpc n n
powerpc64 n n
Reviewer Checklist:
-------------------
[Submitters: make sure that your review doesn't trigger any checkmarks!]
Your checkin has not passed review because (see checked entries):
___ Your RR template is generally incomplete; it has too many blank entries
that need proper data filled in.
___ You have failed to nominate the proper persons for review and push.
___ Your patches do not have proper short+long header
___ You have grammar/spelling in your header that is unacceptable.
___ You have exceeded a sensible line length in your headers/comments/text.
___ You have failed to put in a proper Trac Ticket # into your commits.
___ You have incorrectly put/left internal data in your comments/files
(i.e. internal bug tracking tool IDs, product names etc)
___ You have not given any evidence of testing beyond basic build tests.
Demonstrate some level of runtime or other sanity testing.
___ You have ^M present in some of your files. These have to be removed.
___ You have needlessly changed whitespace or added whitespace crimes
like trailing spaces, or spaces before tabs.
___ You have mixed real technical changes with whitespace and other
cosmetic code cleanup changes. These have to be separate commits.
___ You need to refactor your submission into logical chunks; there is
too much content into a single commit.
___ You have extraneous garbage in your review (merge commits etc)
___ You have giant attachments which should never have been sent;
Instead you should place your content in a public tree to be pulled.
___ You have too many commits attached to an e-mail; resend as threaded
commits, or place in a public tree for a pull.
___ You have resent this content multiple times without a clear indication
of what has changed between each re-send.
___ You have failed to adequately and individually address all of the
comments and change requests that were proposed in the initial review.
___ You have a misconfigured ~/.hgrc file (i.e. username, email etc)
___ Your computer have a badly configured date and time; confusing the
the threaded patch review.
___ Your changes affect IPC mechanism, and you don't present any results
for in-service upgradability test.
___ Your changes affect user manual and documentation, your patch series
do not contain the patch that updates the Doxygen manual.
------------------------------------------------------------------------------
_______________________________________________
Opensaf-devel mailing list
Opensaf-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/opensaf-devel
