Summary: AMF: support immediate effect when changing comp/hc-type attributes V1
[#819]
Review request for Trac Ticket(s): [#819]
Peer Reviewer(s): HansF, Nagu, Praveen
Pull request to:
Affected branch(es): default
Development branch: default
--------------------------------
Impacted area Impact y/n
--------------------------------
Docs n
Build system n
RPM/packaging n
Configuration files n
Startup scripts n
SAF services n
OpenSAF services y
Core libraries n
Samples n
Tests n
Other n
Comments (indicate scope for each "y" above):
---------------------------------------------
<<EXPLAIN/COMMENT THE PATCH SERIES HERE>>
changeset b50cfbb869bee1bb32a47ba2b943c8abcbdfc0b9
Author: Hans Nordeback <hans.nordeb...@ericsson.com>
Date: Thu, 10 Apr 2014 13:19:53 +0200
AMF: support immediate effect when changing comp/hc-type attributes V1
[#819]
Complete diffstat:
------------------
osaf/libs/common/amf/include/amf_defs.h | 7 +++
osaf/services/saf/amf/amfd/hlttype.cc | 70
+++++++++++++++++++++++++++++++++-
osaf/services/saf/amf/amfnd/di.cc | 3 +
osaf/services/saf/amf/amfnd/hcdb.cc | 161
+++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
osaf/services/saf/amf/amfnd/include/avnd_hc.h | 1 +
5 files changed, 241 insertions(+), 1 deletions(-)
Testing Commands:
-----------------
using amfdemo application:
1)
amf-adm unlock-in safSu=SU1,safSg=AmfDemo,safApp=AmfDemo1
amf-adm unlock safSu=SU1,safSg=AmfDemo,safApp=AmfDemo1
amf-adm unlock-in safSu=SU21,safSg=AmfDemo,safApp=AmfDemo1
amf-adm unlock safSu=SU21,safSg=AmfDemo,safApp=AmfDemo1
2)
immlist safHealthcheckKey=AmfDemo,safVersion=1,safCompType=AmfDemo1
verify saAmfHctDefPeriod and saAmfHctDefMaxDuration
3)
change e.g saAmfHctDefPeriod to 20 seconds:
immcfg -a saAmfHctDefPeriod=20000000000
safHealthcheckKey=AmfDemo,safVersion=1,safCompType=AmfDemo1
or e.g. saAmfHctDefMaxDuration to 30 seconds
immcfg -a saAmfHctDefMaxDuration=30000000000
safHealthcheckKey=AmfDemo,safVersion=1,safCompType=AmfDemo1
4)
immlist safHealthcheckKey=AmfDemo,safVersion=1,safCompType=AmfDemo1
verify saAmfHctDefPeriod and saAmfHctDefMaxDuration
5)
check syslog that period has changed and taken effect:
tail -f /var/log/message
SC1:
Apr 10 13:02:48 SC-1 user.debug amf_demo[657]: Health check 19 <=== 10 sec
interval
Apr 10 13:02:58 SC-1 user.debug amf_demo[657]: Health check 20
Apr 10 13:03:00 SC-1 local0.notice osafimmnd[408]: NO Ccb 2 COMMITTED
(immcfg_SC-1_934)
Apr 10 13:03:08 SC-1 user.debug amf_demo[657]: Health check 21
Apr 10 13:03:28 SC-1 user.debug amf_demo[657]: Health check 22 <=== Now 20
sec interval
Apr 10 13:03:48 SC-1 user.debug amf_demo[657]: Health check 23
Apr 10 13:04:08 SC-1 user.debug amf_demo[657]: Health check 24
Apr 10 13:04:28 SC-1 user.debug amf_demo[657]: Health check 25
SC2:
Apr 10 13:02:53 SC-2 user.debug amf_demo[639]: Health check 20
Apr 10 13:03:00 SC-2 local0.notice osafimmnd[408]: NO Ccb 2 COMMITTED
(immcfg_SC-1_934)
Apr 10 13:03:03 SC-2 user.debug amf_demo[639]: Health check 21
Apr 10 13:03:24 SC-2 user.debug amf_demo[639]: Health check 22
Apr 10 13:03:44 SC-2 user.debug amf_demo[639]: Health check 23
Apr 10 13:04:04 SC-2 user.debug amf_demo[639]: Health check 24
Apr 10 13:04:24 SC-2 user.debug amf_demo[639]: Health check 25
Testing, Expected Results:
--------------------------
<<PASTE COMMAND OUTPUTS / TEST RESULTS>>
Conditions of Submission:
-------------------------
<<HOW MANY DAYS BEFORE PUSHING, CONSENSUS ETC>>
Arch Built Started Linux distro
-------------------------------------------
mips n n
mips64 n n
x86 n n
x86_64 y y
powerpc n n
powerpc64 n n
Reviewer Checklist:
-------------------
[Submitters: make sure that your review doesn't trigger any checkmarks!]
Your checkin has not passed review because (see checked entries):
___ Your RR template is generally incomplete; it has too many blank entries
that need proper data filled in.
___ You have failed to nominate the proper persons for review and push.
___ Your patches do not have proper short+long header
___ You have grammar/spelling in your header that is unacceptable.
___ You have exceeded a sensible line length in your headers/comments/text.
___ You have failed to put in a proper Trac Ticket # into your commits.
___ You have incorrectly put/left internal data in your comments/files
(i.e. internal bug tracking tool IDs, product names etc)
___ You have not given any evidence of testing beyond basic build tests.
Demonstrate some level of runtime or other sanity testing.
___ You have ^M present in some of your files. These have to be removed.
___ You have needlessly changed whitespace or added whitespace crimes
like trailing spaces, or spaces before tabs.
___ You have mixed real technical changes with whitespace and other
cosmetic code cleanup changes. These have to be separate commits.
___ You need to refactor your submission into logical chunks; there is
too much content into a single commit.
___ You have extraneous garbage in your review (merge commits etc)
___ You have giant attachments which should never have been sent;
Instead you should place your content in a public tree to be pulled.
___ You have too many commits attached to an e-mail; resend as threaded
commits, or place in a public tree for a pull.
___ You have resent this content multiple times without a clear indication
of what has changed between each re-send.
___ You have failed to adequately and individually address all of the
comments and change requests that were proposed in the initial review.
___ You have a misconfigured ~/.hgrc file (i.e. username, email etc)
___ Your computer have a badly configured date and time; confusing the
the threaded patch review.
___ Your changes affect IPC mechanism, and you don't present any results
for in-service upgradability test.
___ Your changes affect user manual and documentation, your patch series
do not contain the patch that updates the Doxygen manual.
------------------------------------------------------------------------------
Put Bad Developers to Shame
Dominate Development with Jenkins Continuous Integration
Continuously Automate Build, Test & Deployment
Start a new project now. Try Jenkins in the cloud.
http://p.sf.net/sfu/13600_Cloudbees
_______________________________________________
Opensaf-devel mailing list
Opensaf-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/opensaf-devel
