Summary: smfd: no duplicate nodes in single step nodelist after cluster reboot
Review request for Trac Ticket(s): 846
Peer Reviewer(s): bertil
Pull request to:
Affected branch(es): default, 4.4.x, 4.3.x
Development branch: default
--------------------------------
Impacted area Impact y/n
--------------------------------
Docs n
Build system n
RPM/packaging n
Configuration files n
Startup scripts n
SAF services n
OpenSAF services y
Core libraries n
Samples n
Tests n
Other n
Comments (indicate scope for each "y" above):
---------------------------------------------
smfd: no duplicate nodes in single step nodelist after cluster reboot
changeset 6027ed1c8c4ba6f06e49aee62c7215959e716bd6
Author: Ingvar Bergstrom <ingvar.bergst...@ericsson.com>
Date: Fri, 11 Apr 2014 07:38:28 +0200
smfd: no duplicate nodes in single step nodelist after cluster reboot
[#846]
A single step containing bundles which need reboot to install and/or
remove,
will initiate a cluster reboot within the step. When the campaign is
resumed, data about the current step is read from saved SMF imm objects.
Without this patch the routine can save duplicate entries in the step
node
list which causes online remove commands (if they exists) to be executed
several times.
Complete diffstat:
------------------
osaf/services/saf/smfsv/smfd/SmfUpgradeProcedure.cc | 9 ++++++++-
osaf/services/saf/smfsv/smfd/SmfUpgradeStep.cc | 10 ++++++++++
osaf/services/saf/smfsv/smfd/SmfUpgradeStep.hh | 7 +++++++
3 files changed, 25 insertions(+), 1 deletions(-)
Testing Commands:
-----------------
Testing, Expected Results:
--------------------------
Conditions of Submission:
-------------------------
Arch Built Started Linux distro
-------------------------------------------
mips n n
mips64 n n
x86 n n
x86_64 y y
powerpc n n
powerpc64 n n
Reviewer Checklist:
-------------------
[Submitters: make sure that your review doesn't trigger any checkmarks!]
Your checkin has not passed review because (see checked entries):
___ Your RR template is generally incomplete; it has too many blank entries
that need proper data filled in.
___ You have failed to nominate the proper persons for review and push.
___ Your patches do not have proper short+long header
___ You have grammar/spelling in your header that is unacceptable.
___ You have exceeded a sensible line length in your headers/comments/text.
___ You have failed to put in a proper Trac Ticket # into your commits.
___ You have incorrectly put/left internal data in your comments/files
(i.e. internal bug tracking tool IDs, product names etc)
___ You have not given any evidence of testing beyond basic build tests.
Demonstrate some level of runtime or other sanity testing.
___ You have ^M present in some of your files. These have to be removed.
___ You have needlessly changed whitespace or added whitespace crimes
like trailing spaces, or spaces before tabs.
___ You have mixed real technical changes with whitespace and other
cosmetic code cleanup changes. These have to be separate commits.
___ You need to refactor your submission into logical chunks; there is
too much content into a single commit.
___ You have extraneous garbage in your review (merge commits etc)
___ You have giant attachments which should never have been sent;
Instead you should place your content in a public tree to be pulled.
___ You have too many commits attached to an e-mail; resend as threaded
commits, or place in a public tree for a pull.
___ You have resent this content multiple times without a clear indication
of what has changed between each re-send.
___ You have failed to adequately and individually address all of the
comments and change requests that were proposed in the initial review.
___ You have a misconfigured ~/.hgrc file (i.e. username, email etc)
___ Your computer have a badly configured date and time; confusing the
the threaded patch review.
___ Your changes affect IPC mechanism, and you don't present any results
for in-service upgradability test.
___ Your changes affect user manual and documentation, your patch series
do not contain the patch that updates the Doxygen manual.
------------------------------------------------------------------------------
Put Bad Developers to Shame
Dominate Development with Jenkins Continuous Integration
Continuously Automate Build, Test & Deployment
Start a new project now. Try Jenkins in the cloud.
http://p.sf.net/sfu/13600_Cloudbees
_______________________________________________
Opensaf-devel mailing list
Opensaf-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/opensaf-devel
