Ack. SA_AIS_ERR_EXIST is not even a valid return of saImmOiRtObjectUpdate_2().
Thanks -Nagu > -----Original Message----- > From: Hans Feldt [mailto:osafde...@gmail.com] > Sent: 22 April 2014 19:37 > To: Nagendra Kumar > Cc: opensaf-devel@lists.sourceforge.net > Subject: [PATCH 1 of 1] amfd: fix imm job update [#868] > > osaf/services/saf/avsv/avd/avd_imm.c | 2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > > > Ugly logs from amfd like: > Apr 19 19:55:18 SC-1 osafamfd[469]: ER exec: update FAILED 12 > > When an IMM update job is executed and for some reason the object does not > exist, > the job remains in the queue. Reason is because the wrong error code is > checked. > > By correcting the check, the job is removed and no logging appears. > > diff --git a/osaf/services/saf/avsv/avd/avd_imm.c > b/osaf/services/saf/avsv/avd/avd_imm.c > --- a/osaf/services/saf/avsv/avd/avd_imm.c > +++ b/osaf/services/saf/avsv/avd/avd_imm.c > @@ -1529,7 +1529,7 @@ static AvdJobDequeueResultT job_exec_imm > > rc = saImmOiRtObjectUpdate_2(immOiHandle, &objupdate->dn, > attrMods); > > - if ((rc == SA_AIS_OK) || (rc == SA_AIS_ERR_EXIST)) { > + if ((rc == SA_AIS_OK) || (rc == SA_AIS_ERR_NOT_EXIST)) { > free(objupdate->attributeName); > free(objupdate->value); > free(fifo_dequeue()); ------------------------------------------------------------------------------ Start Your Social Network Today - Download eXo Platform Build your Enterprise Intranet with eXo Platform Software Java Based Open Source Intranet - Social, Extensible, Cloud Ready Get Started Now And Turn Your Intranet Into A Collaboration Platform http://p.sf.net/sfu/ExoPlatform _______________________________________________ Opensaf-devel mailing list Opensaf-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/opensaf-devel
