Summary: Make system changes for ETFs and CLMD ETF Review request for Trac Ticket(s): 848 Peer Reviewer(s): Mathi & Bertil Pull request to: <<LIST THE PERSON WITH PUSH ACCESS HERE>> Affected branch(es): default Development branch: default
-------------------------------- Impacted area Impact y/n -------------------------------- Docs n Build system n RPM/packaging n Configuration files y Startup scripts n SAF services n OpenSAF services n Core libraries n Samples n Tests n Other n Comments (indicate scope for each "y" above): --------------------------------------------- Patches for each AMF component to come. This is a RFC of the infrastructure. Note there is no functional impact with this patch. changeset 96658bf396dfcf82fbfec89c1693abe01fd6b0f9 Author: Hans Feldt <[email protected]> Date: Thu, 24 Apr 2014 15:31:41 +0200 osaf: add make system support for etf xmls [#848] New make system variable for pkgetfxml added to make it possible to install template ETF xml files. Such files will be installed by default in: /usr[/local]/share/opensaf/etfxml/services If the string xxCLCCLIDIRxx is used in the ETF it will be replaced after install with the real CLCCLIDIR (typically /usr/lib/opensaf/clc-cli) This is the same pattern as for IMM xml files. changeset 5d44319885d2d2033708503412f96e4187b40c71 Author: Hans Feldt <[email protected]> Date: Thu, 24 Apr 2014 15:33:24 +0200 clm: add ETF file for CLMD [#848] Add an ETF file for CLMD. The contents corresponds to what we have in the IMM XML file. Added Files: ------------ osaf/services/saf/clmsv/config/ETF-CLMD.xml Complete diffstat: ------------------ Makefile.am | 5 +++++ Makefile.common | 2 ++ osaf/services/saf/clmsv/config/ETF-CLMD.xml | 35 +++++++++++++++++++++++++++++++++++ osaf/services/saf/clmsv/config/Makefile.am | 2 ++ 4 files changed, 44 insertions(+), 0 deletions(-) Testing Commands: ----------------- Build and install opensaf Testing, Expected Results: -------------------------- ETF for CLMD installed and patched with real absolute path to CLC-CLI command Conditions of Submission: ------------------------- Ack from Mathi and Bertil Arch Built Started Linux distro ------------------------------------------- mips n n mips64 n n x86 n n x86_64 n n powerpc n n powerpc64 n n Reviewer Checklist: ------------------- [Submitters: make sure that your review doesn't trigger any checkmarks!] Your checkin has not passed review because (see checked entries): ___ Your RR template is generally incomplete; it has too many blank entries that need proper data filled in. ___ You have failed to nominate the proper persons for review and push. ___ Your patches do not have proper short+long header ___ You have grammar/spelling in your header that is unacceptable. ___ You have exceeded a sensible line length in your headers/comments/text. ___ You have failed to put in a proper Trac Ticket # into your commits. ___ You have incorrectly put/left internal data in your comments/files (i.e. internal bug tracking tool IDs, product names etc) ___ You have not given any evidence of testing beyond basic build tests. Demonstrate some level of runtime or other sanity testing. ___ You have ^M present in some of your files. These have to be removed. ___ You have needlessly changed whitespace or added whitespace crimes like trailing spaces, or spaces before tabs. ___ You have mixed real technical changes with whitespace and other cosmetic code cleanup changes. These have to be separate commits. ___ You need to refactor your submission into logical chunks; there is too much content into a single commit. ___ You have extraneous garbage in your review (merge commits etc) ___ You have giant attachments which should never have been sent; Instead you should place your content in a public tree to be pulled. ___ You have too many commits attached to an e-mail; resend as threaded commits, or place in a public tree for a pull. ___ You have resent this content multiple times without a clear indication of what has changed between each re-send. ___ You have failed to adequately and individually address all of the comments and change requests that were proposed in the initial review. ___ You have a misconfigured ~/.hgrc file (i.e. username, email etc) ___ Your computer have a badly configured date and time; confusing the the threaded patch review. ___ Your changes affect IPC mechanism, and you don't present any results for in-service upgradability test. ___ Your changes affect user manual and documentation, your patch series do not contain the patch that updates the Doxygen manual. ------------------------------------------------------------------------------ Start Your Social Network Today - Download eXo Platform Build your Enterprise Intranet with eXo Platform Software Java Based Open Source Intranet - Social, Extensible, Cloud Ready Get Started Now And Turn Your Intranet Into A Collaboration Platform http://p.sf.net/sfu/ExoPlatform _______________________________________________ Opensaf-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/opensaf-devel
