Friendly remainder. /Hans On 04/22/2014 12:58 PM, Hans Feldt wrote: > Summary: amfd SU refactoring > Review request for Trac Ticket(s): 713 > Peer Reviewer(s): AMF developers > Pull request to: <<LIST THE PERSON WITH PUSH ACCESS HERE>> > Affected branch(es): default > Development branch: <<IF ANY GIVE THE REPO URL>> > > -------------------------------- > Impacted area Impact y/n > -------------------------------- > Docs n > Build system n > RPM/packaging n > Configuration files n > Startup scripts n > SAF services y > OpenSAF services n > Core libraries n > Samples n > Tests n > Other n > > > Comments (indicate scope for each "y" above): > --------------------------------------------- > > changeset 89d505f5680924bcf384ff6a4130658751184923 > Author: Hans Feldt <hans.fe...@ericsson.com> > Date: Tue, 22 Apr 2014 12:53:56 +0200 > > amfd: cleanup SU [#713] > > su_act_state is not used thus can be made a dummy (not removed because > of > EDU usage). The corresponding enum AVD_SU_STATE removed. Checkpointing > of > su_act_state kept for backwards compatibility but reduced to a minimum. > > The use of "this->" is removed from some setters. > > Some non existing function signatures removed from the header file. > > changeset e81dc53b0733dee2b2bbe4d2ec1e3aa6d9dd9ca8 > Author: Hans Feldt <hans.fe...@ericsson.com> > Date: Tue, 22 Apr 2014 12:53:57 +0200 > > amfd: add and use SU method set_pres_state [#713] > > changeset 87d7fb15e249c363b2531f43df18d94fa1fa60fe > Author: Hans Feldt <hans.fe...@ericsson.com> > Date: Tue, 22 Apr 2014 12:53:57 +0200 > > amfd: add and use SU method set_admin_state [#713] > > changeset d2c7b29d6113153841ddaaa3ec4ae70784f89ac3 > Author: Hans Feldt <hans.fe...@ericsson.com> > Date: Tue, 22 Apr 2014 12:53:58 +0200 > > amfd: add and use SU methods add_comp/remove_comp [#713] > > changeset 4d6d0708b6923a306b9a5ae44be2ddda2cc016a9 > Author: Hans Feldt <hans.fe...@ericsson.com> > Date: Tue, 22 Apr 2014 12:54:00 +0200 > > amfd: add and use SU method no_assignments_of_hastate [#713] > > > Complete diffstat: > ------------------ > osaf/services/saf/amf/amfd/ckpt_dec.cc | 28 > +------------------------ > osaf/services/saf/amf/amfd/ckpt_updt.cc | 1 - > osaf/services/saf/amf/amfd/comp.cc | 11 +++++---- > osaf/services/saf/amf/amfd/include/su.h | 53 > ++++++++++++++------------------------------------ > osaf/services/saf/amf/amfd/ndproc.cc | 2 +- > osaf/services/saf/amf/amfd/sg_2n_fsm.cc | 14 ++++++------ > osaf/services/saf/amf/amfd/sg_nored_fsm.cc | 16 +++++++------- > osaf/services/saf/amf/amfd/sg_npm_fsm.cc | 16 +++++++------- > osaf/services/saf/amf/amfd/sg_nway_fsm.cc | 22 ++++++++++---------- > osaf/services/saf/amf/amfd/sg_nwayact_fsm.cc | 16 +++++++------- > osaf/services/saf/amf/amfd/sgproc.cc | 4 +- > osaf/services/saf/amf/amfd/su.cc | 140 > +++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++--------------------------------------------------------------------- > osaf/services/saf/amf/amfd/util.cc | 1 - > 13 files changed, 135 insertions(+), 189 deletions(-) > > > Testing Commands: > ----------------- > Build and start > > > Testing, Expected Results: > -------------------------- > <<PASTE COMMAND OUTPUTS / TEST RESULTS>> > > > Conditions of Submission: > ------------------------- > <<HOW MANY DAYS BEFORE PUSHING, CONSENSUS ETC>> > > > Arch Built Started Linux distro > ------------------------------------------- > mips n n > mips64 n n > x86 n n > x86_64 n n > powerpc n n > powerpc64 n n > > > Reviewer Checklist: > ------------------- > [Submitters: make sure that your review doesn't trigger any checkmarks!] > > > Your checkin has not passed review because (see checked entries): > > ___ Your RR template is generally incomplete; it has too many blank entries > that need proper data filled in. > > ___ You have failed to nominate the proper persons for review and push. > > ___ Your patches do not have proper short+long header > > ___ You have grammar/spelling in your header that is unacceptable. > > ___ You have exceeded a sensible line length in your headers/comments/text. > > ___ You have failed to put in a proper Trac Ticket # into your commits. > > ___ You have incorrectly put/left internal data in your comments/files > (i.e. internal bug tracking tool IDs, product names etc) > > ___ You have not given any evidence of testing beyond basic build tests. > Demonstrate some level of runtime or other sanity testing. > > ___ You have ^M present in some of your files. These have to be removed. > > ___ You have needlessly changed whitespace or added whitespace crimes > like trailing spaces, or spaces before tabs. > > ___ You have mixed real technical changes with whitespace and other > cosmetic code cleanup changes. These have to be separate commits. > > ___ You need to refactor your submission into logical chunks; there is > too much content into a single commit. > > ___ You have extraneous garbage in your review (merge commits etc) > > ___ You have giant attachments which should never have been sent; > Instead you should place your content in a public tree to be pulled. > > ___ You have too many commits attached to an e-mail; resend as threaded > commits, or place in a public tree for a pull. > > ___ You have resent this content multiple times without a clear indication > of what has changed between each re-send. > > ___ You have failed to adequately and individually address all of the > comments and change requests that were proposed in the initial review. > > ___ You have a misconfigured ~/.hgrc file (i.e. username, email etc) > > ___ Your computer have a badly configured date and time; confusing the > the threaded patch review. > > ___ Your changes affect IPC mechanism, and you don't present any results > for in-service upgradability test. > > ___ Your changes affect user manual and documentation, your patch series > do not contain the patch that updates the Doxygen manual. > > > ------------------------------------------------------------------------------ > Start Your Social Network Today - Download eXo Platform > Build your Enterprise Intranet with eXo Platform Software > Java Based Open Source Intranet - Social, Extensible, Cloud Ready > Get Started Now And Turn Your Intranet Into A Collaboration Platform > http://p.sf.net/sfu/ExoPlatform > _______________________________________________ > Opensaf-devel mailing list > Opensaf-devel@lists.sourceforge.net > https://lists.sourceforge.net/lists/listinfo/opensaf-devel > >
------------------------------------------------------------------------------ "Accelerate Dev Cycles with Automated Cross-Browser Testing - For FREE Instantly run your Selenium tests across 300+ browser/OS combos. Get unparalleled scalability from the best Selenium testing platform available. Simple to use. Nothing to install. Get started now for free." http://p.sf.net/sfu/SauceLabs _______________________________________________ Opensaf-devel mailing list Opensaf-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/opensaf-devel
