Summary:mds: TCP performance improvements [#654] Review request for Trac Ticket(s): #654 Peer Reviewer(s): Hans/Mathi Pull request to: Affected branch(es):default Development branch: default
-------------------------------- Impacted area Impact y/n -------------------------------- Docs n Build system n RPM/packaging n Configuration files n Startup scripts n SAF services n OpenSAF services n Core libraries y Samples n Tests n Other n Comments (indicate scope for each "y" above): --------------------------------------------- changeset 2b5a57118a102cbfebfbdca33e7b7f1fd4703a33 Author: A V Mahesh <[email protected]> Date: Tue, 29 Apr 2014 11:42:10 +0530 mds: TCP performance improvements [#654] This path is on top of Hans Feldt published on 4/29/2014 10:58 AM 1) Their is NO issue with MDS TCP in-service Upgrade ,The value of SO_RCVBUF & SO_SNDBUF of TCP sockets was set to 64000 (MDS_SND_RCV_SIZE) using setsockopt() ,the kernel doubles this value ,and this doubled value is returned by getsockopt(). So MDS_DIRECT_BUF_MAXSIZE size is used to send for for both previous & current versions of Opensaf nodes which are using MDS TCP as transport 2) Made DTM-TCP inter-node & intra-node socket SO_SNDBUF and SO_RCVBUF buffer in bytes configurable . The kernel doubles this value (to allow space for bookkeeping over-head) when it is set using setsockopt(),and this doubled value is returned by getsockopt(). The default value is set to DTM_SOCK_SND_RCV_BUF_SIZE=126976 3) Made TCP_NODELAY configurable to specifi whether MDS TCP transport should follow the Nagle algorithm for deciding when to send data.By default, TCP will follow the Nagle algorithm is disable this behavior , can be configured to TRUE(1) or FALSE(0) Complete diffstat: ------------------ osaf/libs/core/mds/include/mds_dt_tcp_disc.h | 1 - osaf/libs/core/mds/mds_dt_tcp.c | 20 ++++++++++++++++++-- osaf/libs/core/mds/mds_dt_trans.c | 12 ++++++------ osaf/services/infrastructure/dtms/config/dtmd.conf | 23 +++++++++++++++++++++++ osaf/services/infrastructure/dtms/dtm/dtm_intra.c | 13 ++++++------- osaf/services/infrastructure/dtms/dtm/dtm_node_sockets.c | 44 +++++++++++++++++++++----------------------- osaf/services/infrastructure/dtms/dtm/dtm_read_config.c | 30 ++++++++++++++++++++++++++++++ osaf/services/infrastructure/dtms/include/dtm.h | 2 ++ osaf/services/infrastructure/dtms/include/dtm_cb.h | 3 +++ osaf/services/infrastructure/dtms/include/dtm_intra_disc.h | 2 -- 10 files changed, 109 insertions(+), 41 deletions(-) Testing Commands: ----------------- <<LIST THE COMMAND LINE TOOLS/STEPS TO TEST YOUR CHANGES>> Testing, Expected Results: -------------------------- <<PASTE COMMAND OUTPUTS / TEST RESULTS>> Conditions of Submission: ------------------------- <<HOW MANY DAYS BEFORE PUSHING, CONSENSUS ETC>> Arch Built Started Linux distro ------------------------------------------- mips n n mips64 n n x86 n n x86_64 y y powerpc n n powerpc64 n n Reviewer Checklist: ------------------- [Submitters: make sure that your review doesn't trigger any checkmarks!] Your checkin has not passed review because (see checked entries): ___ Your RR template is generally incomplete; it has too many blank entries that need proper data filled in. ___ You have failed to nominate the proper persons for review and push. ___ Your patches do not have proper short+long header ___ You have grammar/spelling in your header that is unacceptable. ___ You have exceeded a sensible line length in your headers/comments/text. ___ You have failed to put in a proper Trac Ticket # into your commits. ___ You have incorrectly put/left internal data in your comments/files (i.e. internal bug tracking tool IDs, product names etc) ___ You have not given any evidence of testing beyond basic build tests. Demonstrate some level of runtime or other sanity testing. ___ You have ^M present in some of your files. These have to be removed. ___ You have needlessly changed whitespace or added whitespace crimes like trailing spaces, or spaces before tabs. ___ You have mixed real technical changes with whitespace and other cosmetic code cleanup changes. These have to be separate commits. ___ You need to refactor your submission into logical chunks; there is too much content into a single commit. ___ You have extraneous garbage in your review (merge commits etc) ___ You have giant attachments which should never have been sent; Instead you should place your content in a public tree to be pulled. ___ You have too many commits attached to an e-mail; resend as threaded commits, or place in a public tree for a pull. ___ You have resent this content multiple times without a clear indication of what has changed between each re-send. ___ You have failed to adequately and individually address all of the comments and change requests that were proposed in the initial review. ___ You have a misconfigured ~/.hgrc file (i.e. username, email etc) ___ Your computer have a badly configured date and time; confusing the the threaded patch review. ___ Your changes affect IPC mechanism, and you don't present any results for in-service upgradability test. ___ Your changes affect user manual and documentation, your patch series do not contain the patch that updates the Doxygen manual. ------------------------------------------------------------------------------ "Accelerate Dev Cycles with Automated Cross-Browser Testing - For FREE Instantly run your Selenium tests across 300+ browser/OS combos. Get unparalleled scalability from the best Selenium testing platform available. Simple to use. Nothing to install. Get started now for free." http://p.sf.net/sfu/SauceLabs _______________________________________________ Opensaf-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/opensaf-devel
