Comments inline: Thanks, Mathi. ----- [email protected] wrote:
> See inline > > Thanks, > > Hans > > > > > > > > > From: Mathivanan Naickan Palanivelu [mailto:[email protected]] > Sent: den 25 april 2014 12:08 > To: Hans Feldt; Bertil Engelholm > Cc: [email protected] > Subject: RE: [PATCH 2 of 2] clm: add ETF file for CLMD [#848] > > > > Nice start. > > > > Like Bertil commented, yes CLMNA should also be part of the same ETF > for the CLM ‘software’! > > [Hans] sure this was just an RFC, the same or another file? > I don't know which is better, i.e. ETF per middleware service or ETF per middleware component. I'm inclining towards ETF per middleware service! The SMF spec talks of "ETF w.r.t software bundles", not sure if it should be seen as ETF 'per' software bundle! To quote: "When a software vendor provides a new software bundle, an entity types file describ- ing the content of the software bundle shall be supplied with the bundle." ..."One entity types file may refer to multiple software bundles, each of which must be identified according to the XML schema...." > And, > > > > What about the below, will they be part of some OpenSAF common ETF? > > +<xs:element name="SUType">++---------------- > > +<xs:element name="SGType">-+--------------- > > +<xs:element name="AppType">++---- > > +<xs:element name="CSType">++-------- > > +<xs:element name="ServiceType"> > > [Hans] I currently don’t see any need for that. > > The SMF spec/schema already defines which elements should be mandatory element, optional or alternative. We could use that as the guideline! > > And did you not think of the need for defining any appropriate item > from below? > > [Hans] Sorry I don’t get this list, what exactly is missing from this > ETF to generate the same imm.xml as today > While there is a rule/guideline from the SMF spec, it also depends on the scope for the tool that is going to use this ETF file. I'm not sure about the scope of this activity(patch request)!? You could weigh all your comments below w.r.t the guideline for ETF from the SMF spec. > > > -<xs:element name="swBundle" maxOccurs="unbounded" minOccurs="0"> > > +<xs:element name="removal">++---------- > > +<xs:element name="installation">-+-------- </xs:sequence> > > [Hans] I currently don’t see a need for the bundle part > > > > +<xs:element name="quiescingComplete" type="BoundedTimeT">- > > [Hans] already in there > > +<xs:element name="numInstances" type="UnsignedInt32T">- > > +<xs:element name="numMaxStandbyCsi" type="BoundedUInt32T">- > > [Hans] could add that > > +<xs:element name="instantiateCmd">-- > > [Hans] already in there > > +<xs:element name="numMaxActiveCsi" type="BoundedUInt32T">- > > [Hans] could add that > > +<xs:attributeGroup name="valueRange">- > > +<xs:complexType name="UnsignedInt32T">- > > +<xs:complexType name="BoundedUInt32T">- > > +<xs:complexType name="BoundedTimeT">- > > +<xs:complexType name="callbackOptionsT">---------- > > +<xs:complexType name="ProbationT">- > > +<xs:simpleType name="SaTimeT">- > > +<xs:simpleType name="SaStringT">- > > +<xs:simpleType name="VersionT">-- > > +<xs:simpleType name="SwBundleNameT">-- > > +<xs:simpleType name="CompTypeNameT">-- > > +<xs:simpleType name="SUTypeNameT">-- > > +<xs:simpleType name="SGTypeNameT">-- > > +<xs:simpleType name="AppTypeNameT">-- > > +<xs:simpleType name="CSTypeNameT">-- > > +<xs:simpleType name="SrvTypeNameT">-- > > +<xs:simpleType name="RecommendedRecoveryT">-- > > [Hans] already in there > > +<xs:simpleType name="HealthcheckVariantT">-- > > +<xs:simpleType name="RedModelT">-- > > +<xs:group name="CompCapability">-------------------- > > +<xs:group name="CompCallbackTimeouts">---------- > > +<xs:group name="CliParameters">------ > > +<xs:group name="CommonCompAttributes">----------------- > > [Hans] yes the relevant ones are configured > > +<xs:group name="ScopeOfImpact"> > > > > > > Thanks, > > Mathi. > > > > > > >-----Original Message----- > > >From: Hans Feldt [ mailto:[email protected] ] > > >Sent: Thursday, April 24, 2014 7:10 PM > > >To: [email protected] ; Mathivanan Naickan Palanivelu > > >Cc: [email protected] > > >Subject: [PATCH 2 of 2] clm: add ETF file for CLMD [#848] > > > > > > osaf/services/saf/clmsv/config/ETF-CLMD.xml | 35 > > >+++++++++++++++++++++++++++++ > > > osaf/services/saf/clmsv/config/Makefile.am | 2 + > > > 2 files changed, 37 insertions(+), 0 deletions(-) > > > > > > > > >Add an ETF file for CLMD. The contents corresponds to what we have in > the > > >IMM XML file. > > > > > >diff --git a/osaf/services/saf/clmsv/config/ETF-CLMD.xml > > >b/osaf/services/saf/clmsv/config/ETF-CLMD.xml > > >new file mode 100644 > > >--- /dev/null > > >+++ b/osaf/services/saf/clmsv/config/ETF-CLMD.xml > > >@@ -0,0 +1,35 @@ > > >+<?xml version="1.0" encoding="utf-8"?> > > >+<entityTypesFile xmlns:xsi=" http://www.w3.org/2001/XMLSchema- > > >instance " name="CLMD" provider="OSAF"> > > >+ <AmfEntityType> > > >+ <CompType name="safCompType=OSAF-CLMD" > > >version="safVersion=1"> > > >+ <providesCSType name="safCSType=OSAF-CLMD" > > >version="safVersion=1"> > > >+ <oneactiveoronestandby/> > > >+ </providesCSType> > > >+ <saAware> > > >+ <healthCheck > > >key="safHealthcheckKey=Default"> > > >+ <period lowerBound="240000000000" > > >default="240000000000"/> > > >+ <maxDuration > > >lowerBound="180000000000"/> > > >+ </healthCheck> > > >+ <quiescingComplete > > >lowerBound="10000000000" default="10000000000"/> > > >+ <independent> > > >+ <instantiateCmd> > > >+ > > > <command>xxCLCCLIDIRxx/osaf-clmd</command> > > >+ <args>instantiate</args> > > >+ </instantiateCmd> > > >+ <cleanupCmd> > > >+ > > > <command>xxCLCCLIDIRxx/osaf-clmd</command> > > >+ <args>cleanup</args> > > >+ </cleanupCmd> > > >+ </independent> > > >+ </saAware> > > >+ <disableRestart>true</disableRestart> > > >+ > > > <recoveryOnError>SA_AMF_NODE_FAILFAST</recoveryOnError> > > >+ <defaultClcCliTimeOut lowerBound="10000000000"/> > > >+ <defaultCallbackTimeOut > > >lowerBound="40000000000"/> > > >+ <bundleReference name="safSmfBundle=OSAF"/> > > >+ </CompType> > > >+ </AmfEntityType> > > >+ <AmfEntityType> > > >+ <CSType name="safCSType=OSAF-CLMD" > > >version="safVersion=1" /> > > >+ </AmfEntityType> > > >+</entityTypesFile> > > >diff --git a/osaf/services/saf/clmsv/config/Makefile.am > > >b/osaf/services/saf/clmsv/config/Makefile.am > > >--- a/osaf/services/saf/clmsv/config/Makefile.am > > >+++ b/osaf/services/saf/clmsv/config/Makefile.am > > >@@ -38,6 +38,8 @@ dist_pkgimmxml_svc_DATA += \ > > > clmsv_pl_template.xml > > > endif > > > > > >+dist_pkgetfxml_svc_DATA = \ > > >+ ETF-CLMD.xml > > > endif > > > > > > install-data-hook: ------------------------------------------------------------------------------ "Accelerate Dev Cycles with Automated Cross-Browser Testing - For FREE Instantly run your Selenium tests across 300+ browser/OS combos. Get unparalleled scalability from the best Selenium testing platform available. Simple to use. Nothing to install. Get started now for free." http://p.sf.net/sfu/SauceLabs _______________________________________________ Opensaf-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/opensaf-devel
