Summary: AMF SU refactoring
Review request for Trac Ticket(s): 713
Peer Reviewer(s): Hans, Praveen, Nags
Pull request to: <<LIST THE PERSON WITH PUSH ACCESS HERE>>
Affected branch(es): default
Development branch: <<IF ANY GIVE THE REPO URL>>
--------------------------------
Impacted area Impact y/n
--------------------------------
Docs n
Build system n
RPM/packaging n
Configuration files n
Startup scripts n
SAF services n
OpenSAF services n
Core libraries n
Samples n
Tests n
Other n
Comments (indicate scope for each "y" above):
---------------------------------------------
changeset 5e2b7fc25c625513f60d72f8cb17afec0031fac4
Author: Hans Feldt <hans.fe...@ericsson.com>
Date: Wed, 30 Apr 2014 06:29:25 +0200
amfd: add and use SU assignment count methods [#713]
changeset 1cecd1a4b444dde4961fc56d671944a66d637686
Author: Hans Feldt <hans.fe...@ericsson.com>
Date: Wed, 30 Apr 2014 06:29:26 +0200
amfd: add and use set_su_failover [#713]
changeset 4cb397232bcb51f439c1fcad870d38498d8992e1
Author: Hans Feldt <hans.fe...@ericsson.com>
Date: Wed, 30 Apr 2014 06:29:26 +0200
amfd: add and use SU method set_term_state [#713]
changeset 82163d3aa68df5e9d723cf90eb82ea6c3569dd74
Author: Hans Feldt <hans.fe...@ericsson.com>
Date: Wed, 30 Apr 2014 06:29:26 +0200
amfd: add SU constr/destr [#713]
changeset 7c7e70b6dcacfd314b08648e9da7a419ea5f863f
Author: Hans Feldt <hans.fe...@ericsson.com>
Date: Wed, 30 Apr 2014 06:29:27 +0200
amfd: add and use set_su_switch [#713]
changeset 6693ca090a9a155933f33b2af1099995596eb0a2
Author: Hans Feldt <hans.fe...@ericsson.com>
Date: Wed, 30 Apr 2014 06:29:28 +0200
amfd: add and use SU get_node_ptr [#713]
changeset 47c134295b3137fe5c36f91707cfdb17c3c1884c
Author: Hans Feldt <hans.fe...@ericsson.com>
Date: Wed, 30 Apr 2014 06:29:29 +0200
amfd: add and use SU is_in_service [#713]
Complete diffstat:
------------------
osaf/services/saf/amf/amfd/clm.cc | 2 +-
osaf/services/saf/amf/amfd/comp.cc | 7 ++--
osaf/services/saf/amf/amfd/include/su.h | 57
+++++++++++------------------------------
osaf/services/saf/amf/amfd/node.cc | 10 ++----
osaf/services/saf/amf/amfd/role.cc | 2 +-
osaf/services/saf/amf/amfd/sg.cc | 12 +++-----
osaf/services/saf/amf/amfd/sg_2n_fsm.cc | 42
++++++++++++++++--------------
osaf/services/saf/amf/amfd/sg_nored_fsm.cc | 16 +++++-----
osaf/services/saf/amf/amfd/sg_npm_fsm.cc | 14 +++++-----
osaf/services/saf/amf/amfd/sg_nway_fsm.cc | 19 ++++++-------
osaf/services/saf/amf/amfd/sg_nwayact_fsm.cc | 16 +++++-----
osaf/services/saf/amf/amfd/sgproc.cc | 24 ++++-------------
osaf/services/saf/amf/amfd/siass.cc | 29 +++++++++++---------
osaf/services/saf/amf/amfd/su.cc | 194
++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++--------------------------------------------------------------
osaf/services/saf/amf/amfd/sutype.cc | 5 +--
osaf/services/saf/amf/amfd/util.cc | 25 ++++++-----------
16 files changed, 227 insertions(+), 247 deletions(-)
Testing Commands:
-----------------
Build and start
Testing, Expected Results:
--------------------------
<<PASTE COMMAND OUTPUTS / TEST RESULTS>>
Conditions of Submission:
-------------------------
<<HOW MANY DAYS BEFORE PUSHING, CONSENSUS ETC>>
Arch Built Started Linux distro
-------------------------------------------
mips n n
mips64 n n
x86 n n
x86_64 n n
powerpc n n
powerpc64 n n
Reviewer Checklist:
-------------------
[Submitters: make sure that your review doesn't trigger any checkmarks!]
Your checkin has not passed review because (see checked entries):
___ Your RR template is generally incomplete; it has too many blank entries
that need proper data filled in.
___ You have failed to nominate the proper persons for review and push.
___ Your patches do not have proper short+long header
___ You have grammar/spelling in your header that is unacceptable.
___ You have exceeded a sensible line length in your headers/comments/text.
___ You have failed to put in a proper Trac Ticket # into your commits.
___ You have incorrectly put/left internal data in your comments/files
(i.e. internal bug tracking tool IDs, product names etc)
___ You have not given any evidence of testing beyond basic build tests.
Demonstrate some level of runtime or other sanity testing.
___ You have ^M present in some of your files. These have to be removed.
___ You have needlessly changed whitespace or added whitespace crimes
like trailing spaces, or spaces before tabs.
___ You have mixed real technical changes with whitespace and other
cosmetic code cleanup changes. These have to be separate commits.
___ You need to refactor your submission into logical chunks; there is
too much content into a single commit.
___ You have extraneous garbage in your review (merge commits etc)
___ You have giant attachments which should never have been sent;
Instead you should place your content in a public tree to be pulled.
___ You have too many commits attached to an e-mail; resend as threaded
commits, or place in a public tree for a pull.
___ You have resent this content multiple times without a clear indication
of what has changed between each re-send.
___ You have failed to adequately and individually address all of the
comments and change requests that were proposed in the initial review.
___ You have a misconfigured ~/.hgrc file (i.e. username, email etc)
___ Your computer have a badly configured date and time; confusing the
the threaded patch review.
___ Your changes affect IPC mechanism, and you don't present any results
for in-service upgradability test.
___ Your changes affect user manual and documentation, your patch series
do not contain the patch that updates the Doxygen manual.
------------------------------------------------------------------------------
"Accelerate Dev Cycles with Automated Cross-Browser Testing - For FREE
Instantly run your Selenium tests across 300+ browser/OS combos. Get
unparalleled scalability from the best Selenium testing platform available.
Simple to use. Nothing to install. Get started now for free."
http://p.sf.net/sfu/SauceLabs
_______________________________________________
Opensaf-devel mailing list
Opensaf-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/opensaf-devel
