Summary: v2 amfd SU constr/destr
Review request for Trac Ticket(s): 713
Peer Reviewer(s): Nags & Hans
Pull request to: <<LIST THE PERSON WITH PUSH ACCESS HERE>>
Affected branch(es): default
Development branch: default
--------------------------------
Impacted area Impact y/n
--------------------------------
Docs n
Build system n
RPM/packaging n
Configuration files n
Startup scripts n
SAF services y
OpenSAF services n
Core libraries n
Samples n
Tests n
Other n
Comments (indicate scope for each "y" above):
---------------------------------------------
Updated patch separating out logic from destructor into new method
"remove_from_model" that has to be explicitly called for an SU that previously
has been added to the model. The problem was due to the SU destructor executed
in checkpoint context:
#6 0x000000000046d15d in AVD_SU::~AVD_SU (this=0x7fbfd191a0,
__in_chrg=<optimized out>) at su.cc:64
#7 0x00000000004125ff in dec_cs_oper_su (cb=cb@entry=0x6a54c0
<_control_block>, dec=dec@entry=0x7fbfd19938) at ckpt_dec.cc:3340
changeset e16016867b0deb4b66a50dfd2f530f01e23d96ae
Author: Hans Feldt <hans.fe...@ericsson.com>
Date: Fri, 02 May 2014 14:56:22 +0200
V2 (4/7) amfd: add SU constr/destr [#713]
Complete diffstat:
------------------
osaf/services/saf/amf/amfd/include/su.h | 22 ++++++++--------------
osaf/services/saf/amf/amfd/su.cc | 80
++++++++++++++++++++++++++++++++++++++------------------------------------------
2 files changed, 46 insertions(+), 56 deletions(-)
Testing Commands:
-----------------
Start 2 node uml cluster, failover controller
Testing, Expected Results:
--------------------------
works
Conditions of Submission:
-------------------------
<<HOW MANY DAYS BEFORE PUSHING, CONSENSUS ETC>>
Arch Built Started Linux distro
-------------------------------------------
mips n n
mips64 n n
x86 n n
x86_64 n n
powerpc n n
powerpc64 n n
Reviewer Checklist:
-------------------
[Submitters: make sure that your review doesn't trigger any checkmarks!]
Your checkin has not passed review because (see checked entries):
___ Your RR template is generally incomplete; it has too many blank entries
that need proper data filled in.
___ You have failed to nominate the proper persons for review and push.
___ Your patches do not have proper short+long header
___ You have grammar/spelling in your header that is unacceptable.
___ You have exceeded a sensible line length in your headers/comments/text.
___ You have failed to put in a proper Trac Ticket # into your commits.
___ You have incorrectly put/left internal data in your comments/files
(i.e. internal bug tracking tool IDs, product names etc)
___ You have not given any evidence of testing beyond basic build tests.
Demonstrate some level of runtime or other sanity testing.
___ You have ^M present in some of your files. These have to be removed.
___ You have needlessly changed whitespace or added whitespace crimes
like trailing spaces, or spaces before tabs.
___ You have mixed real technical changes with whitespace and other
cosmetic code cleanup changes. These have to be separate commits.
___ You need to refactor your submission into logical chunks; there is
too much content into a single commit.
___ You have extraneous garbage in your review (merge commits etc)
___ You have giant attachments which should never have been sent;
Instead you should place your content in a public tree to be pulled.
___ You have too many commits attached to an e-mail; resend as threaded
commits, or place in a public tree for a pull.
___ You have resent this content multiple times without a clear indication
of what has changed between each re-send.
___ You have failed to adequately and individually address all of the
comments and change requests that were proposed in the initial review.
___ You have a misconfigured ~/.hgrc file (i.e. username, email etc)
___ Your computer have a badly configured date and time; confusing the
the threaded patch review.
___ Your changes affect IPC mechanism, and you don't present any results
for in-service upgradability test.
___ Your changes affect user manual and documentation, your patch series
do not contain the patch that updates the Doxygen manual.
------------------------------------------------------------------------------
"Accelerate Dev Cycles with Automated Cross-Browser Testing - For FREE
Instantly run your Selenium tests across 300+ browser/OS combos. Get
unparalleled scalability from the best Selenium testing platform available.
Simple to use. Nothing to install. Get started now for free."
http://p.sf.net/sfu/SauceLabs
_______________________________________________
Opensaf-devel mailing list
Opensaf-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/opensaf-devel
