Summary: MDS TIPC receive buffer v2 (1/4) Review request for Trac Ticket(s): 654 Peer Reviewer(s): Mahesh Pull request to: <<LIST THE PERSON WITH PUSH ACCESS HERE>> Affected branch(es): default Development branch: default
-------------------------------- Impacted area Impact y/n -------------------------------- Docs n Build system n RPM/packaging n Configuration files n Startup scripts n SAF services n OpenSAF services n Core libraries y Samples n Tests n Other n Comments (indicate scope for each "y" above): --------------------------------------------- changeset 3e018874bf1ae8a832f9ed9796a2ec744e2ddad7 Author: Hans Feldt <[email protected]> Date: Wed, 07 May 2014 08:29:10 +0200 mds: use TIPC defined max msg size for rec buffer [#654] Using connection-less TIPC messaging the largest message that can be sent and received is 66000 defined by the constant TIPC_MAX_USER_MSG_SIZE defined in tipc.h The patch change the MDS TIPC code to use the TIPC constant instead of defining its own lower limit (for no reason). Use of m_NCS_TASK_START and m_NCS_TASK_STOP are removed since they anyway are just nops. Error handling of m_NCS_TASK_START would have needed a free() call for the new recv buffer which seemed unneccessary to add. No functional change. Just preparation for other changes. Complete diffstat: ------------------ osaf/libs/core/mds/include/mds_dt.h | 3 --- osaf/libs/core/mds/mds_dt_tipc.c | 45 +++++++++++++++++---------------------------- 2 files changed, 17 insertions(+), 31 deletions(-) Testing Commands: ----------------- Build and start opensaf Testing, Expected Results: -------------------------- starts Conditions of Submission: ------------------------- Ack from Mahesh Arch Built Started Linux distro ------------------------------------------- mips n n mips64 n n x86 n n x86_64 n n powerpc n n powerpc64 n n Reviewer Checklist: ------------------- [Submitters: make sure that your review doesn't trigger any checkmarks!] Your checkin has not passed review because (see checked entries): ___ Your RR template is generally incomplete; it has too many blank entries that need proper data filled in. ___ You have failed to nominate the proper persons for review and push. ___ Your patches do not have proper short+long header ___ You have grammar/spelling in your header that is unacceptable. ___ You have exceeded a sensible line length in your headers/comments/text. ___ You have failed to put in a proper Trac Ticket # into your commits. ___ You have incorrectly put/left internal data in your comments/files (i.e. internal bug tracking tool IDs, product names etc) ___ You have not given any evidence of testing beyond basic build tests. Demonstrate some level of runtime or other sanity testing. ___ You have ^M present in some of your files. These have to be removed. ___ You have needlessly changed whitespace or added whitespace crimes like trailing spaces, or spaces before tabs. ___ You have mixed real technical changes with whitespace and other cosmetic code cleanup changes. These have to be separate commits. ___ You need to refactor your submission into logical chunks; there is too much content into a single commit. ___ You have extraneous garbage in your review (merge commits etc) ___ You have giant attachments which should never have been sent; Instead you should place your content in a public tree to be pulled. ___ You have too many commits attached to an e-mail; resend as threaded commits, or place in a public tree for a pull. ___ You have resent this content multiple times without a clear indication of what has changed between each re-send. ___ You have failed to adequately and individually address all of the comments and change requests that were proposed in the initial review. ___ You have a misconfigured ~/.hgrc file (i.e. username, email etc) ___ Your computer have a badly configured date and time; confusing the the threaded patch review. ___ Your changes affect IPC mechanism, and you don't present any results for in-service upgradability test. ___ Your changes affect user manual and documentation, your patch series do not contain the patch that updates the Doxygen manual. ------------------------------------------------------------------------------ Is your legacy SCM system holding you back? Join Perforce May 7 to find out: • 3 signs your SCM is hindering your productivity • Requirements for releasing software faster • Expert tips and advice for migrating your SCM now http://p.sf.net/sfu/perforce _______________________________________________ Opensaf-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/opensaf-devel
