Ack on these patches with the following comments:
---------------
1)
In the imma client you have added:
+#define IMMSV_OI_CALLBACK_WAIT_TIME 6 /* Default wait time for OI
callback to reply in seconds => 6 sec*/
This default timeout is set in the client if the client has not explicitly
defined IMMA_OI_CALLBACK_TIMEOUT.
But this is redundant since the default is defined in the server (even before
this fix).
Another thing is that we want to be able in principle to change the default by
changing it in ONE place.
The natural place is the original place in the server, possibly at some point
replaced by the configuration
attribute in the existing SAF imm object mentionend in the ticket. The config
attribute would then only
control the default value and qould not override explicit client settings.
WE dont want different clients getting different defaults depending on
when they where compiled.
IF the client has not explicitly defined IMMA_OI_CALLBACK_TIMEOUT then the
implementer set
should use the value 0 for the timeout in the message to the server and let the
server do
the defaulting according to todays (pre #16 fix) behavior. That is the behavior
you still
get when sending IMMND_EVT_A2ND_OI_IMPL_SET instead of
IMMND_EVT_A2ND_OI_IMPL_SET_2.
-----------------------
2) I will update the immsv/README with a description of the new
IMMA_OI_CALLBACK_TIMEOUT
provided as an additional patch to this ticket.
Tested with the new immoitest which is slooower since it is testing the
oi-timeout setting mechanism.
/AndersBj
-----Original Message-----
From: Zoran Milinkovic [mailto:[email protected]]
Sent: den 8 maj 2014 13:46
To: [email protected]
Cc: [email protected]
Subject: [devel] [PATCH 0 of 3] Review Request for imm: add support for
configurable OI callback timeout [#16]
Summary: imm: add support for configurable OI callback timeout [#16] Review
request for Trac Ticket(s): 16 Peer Reviewer(s): Neelakanta, Anders Pull
request to: Zoran Affected branch(es): default(4.5) Development branch:
default(4.5)
--------------------------------
Impacted area Impact y/n
--------------------------------
Docs n
Build system n
RPM/packaging n
Configuration files n
Startup scripts n
SAF services y
OpenSAF services n
Core libraries n
Samples n
Tests n
Other n
Comments (indicate scope for each "y" above):
---------------------------------------------
changeset da62b083125842a8e6b1437fdc6224b3f1e6720e
Author: Zoran Milinkovic <[email protected]>
Date: Thu, 08 May 2014 13:40:11 +0200
imm: add support for configurable OI callback timeout [#16]
When an implementer is set, the configurable timeout is sent to IMM
service.
The configurable timeout is used for calculating timeouts for OI
callbacks
and waiting on search replies from RTA update callback.
changeset bcd50a218ba95178ea86735ff322b722bdf577f7
Author: Zoran Milinkovic <[email protected]>
Date: Thu, 08 May 2014 13:27:07 +0200
imm: use IMMA_OI_CALLBACK_TIMEOUT for setting OI callback timeout [#16]
IMMA uses IMMA_OI_CALLBACK_TIMEOUT for sending OI timeout to IMM service
using implementer set operations.
changeset d11cb26e44f7554d6b22476d874086044d22d624
Author: Zoran Milinkovic <[email protected]>
Date: Thu, 08 May 2014 13:41:57 +0200
immtests: add test cases for OI callback timeout [#16]
Test cases cover OI callback timeout and timeout on searching for an
object
with RTA
Complete diffstat:
------------------
osaf/libs/agents/saf/imma/imma_cb.h | 1 +
osaf/libs/agents/saf/imma/imma_def.h | 1 +
osaf/libs/agents/saf/imma/imma_oi_api.c | 23 +++++++++++-
osaf/libs/common/immsv/immsv_evt.c | 56
++++++++++++++++++++++++++++-
osaf/libs/common/immsv/include/immsv_evt.h | 4 ++
osaf/libs/common/immsv/include/immsv_evt_model.h | 1 +
osaf/services/saf/immsv/immd/immd_evt.c | 9 ++++-
osaf/services/saf/immsv/immnd/ImmModel.cc | 89
+++++++++++++++++++++++++++++++++++----------
osaf/services/saf/immsv/immnd/ImmModel.hh | 6 ++-
osaf/services/saf/immsv/immnd/immnd_evt.c | 38 ++++++++++++++++---
osaf/services/saf/immsv/immnd/immnd_init.h | 8 ++-
tests/immsv/implementer/test_cleanup.c | 1 +
tests/immsv/implementer/test_saImmOiImplementerSet.c | 287
++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
13 files changed, 487 insertions(+), 37 deletions(-)
Testing Commands:
-----------------
immoitest
Testing, Expected Results:
--------------------------
immoitest must pass all tests
Conditions of Submission:
-------------------------
Ack from Neelakanta and Anders
Arch Built Started Linux distro
-------------------------------------------
mips n n
mips64 n n
x86 n n
x86_64 n n
powerpc n n
powerpc64 n n
Reviewer Checklist:
-------------------
[Submitters: make sure that your review doesn't trigger any checkmarks!]
Your checkin has not passed review because (see checked entries):
___ Your RR template is generally incomplete; it has too many blank entries
that need proper data filled in.
___ You have failed to nominate the proper persons for review and push.
___ Your patches do not have proper short+long header
___ You have grammar/spelling in your header that is unacceptable.
___ You have exceeded a sensible line length in your headers/comments/text.
___ You have failed to put in a proper Trac Ticket # into your commits.
___ You have incorrectly put/left internal data in your comments/files
(i.e. internal bug tracking tool IDs, product names etc)
___ You have not given any evidence of testing beyond basic build tests.
Demonstrate some level of runtime or other sanity testing.
___ You have ^M present in some of your files. These have to be removed.
___ You have needlessly changed whitespace or added whitespace crimes
like trailing spaces, or spaces before tabs.
___ You have mixed real technical changes with whitespace and other
cosmetic code cleanup changes. These have to be separate commits.
___ You need to refactor your submission into logical chunks; there is
too much content into a single commit.
___ You have extraneous garbage in your review (merge commits etc)
___ You have giant attachments which should never have been sent;
Instead you should place your content in a public tree to be pulled.
___ You have too many commits attached to an e-mail; resend as threaded
commits, or place in a public tree for a pull.
___ You have resent this content multiple times without a clear indication
of what has changed between each re-send.
___ You have failed to adequately and individually address all of the
comments and change requests that were proposed in the initial review.
___ You have a misconfigured ~/.hgrc file (i.e. username, email etc)
___ Your computer have a badly configured date and time; confusing the
the threaded patch review.
___ Your changes affect IPC mechanism, and you don't present any results
for in-service upgradability test.
___ Your changes affect user manual and documentation, your patch series
do not contain the patch that updates the Doxygen manual.
------------------------------------------------------------------------------
Is your legacy SCM system holding you back? Join Perforce May 7 to find out:
• 3 signs your SCM is hindering your productivity • Requirements for
releasing software faster • Expert tips and advice for migrating your SCM
now http://p.sf.net/sfu/perforce _______________________________________________
Opensaf-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/opensaf-devel
------------------------------------------------------------------------------
Is your legacy SCM system holding you back? Join Perforce May 7 to find out:
• 3 signs your SCM is hindering your productivity
• Requirements for releasing software faster
• Expert tips and advice for migrating your SCM now
http://p.sf.net/sfu/perforce
_______________________________________________
Opensaf-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/opensaf-devel
