Summary: amfd SU refactoring
Review request for Trac Ticket(s): 713
Peer Reviewer(s): Hans N, Nags
Pull request to: <<LIST THE PERSON WITH PUSH ACCESS HERE>>
Affected branch(es): default
Development branch: <<IF ANY GIVE THE REPO URL>>

--------------------------------
Impacted area       Impact y/n
--------------------------------
 Docs                    n
 Build system            n
 RPM/packaging           n
 Configuration files     n
 Startup scripts         n
 SAF services            y
 OpenSAF services        n
 Core libraries          n
 Samples                 n
 Tests                   n
 Other                   n


Comments (indicate scope for each "y" above):
---------------------------------------------

changeset 1ff45efdaa43ccb8311c1b07735692180b83d400
Author: Hans Feldt <hans.fe...@ericsson.com>
Date:   Tue, 13 May 2014 07:48:19 +0200

        amfd: create sutcomptype header file [#713]

        Moving sgtype things from sg.h into its own header.

changeset 8b777eb7404a947754d4e36482237469f7d69e9f
Author: Hans Feldt <hans.fe...@ericsson.com>
Date:   Tue, 13 May 2014 07:48:21 +0200

        amfd: add comp_is_preinstantiable [#713]

        Removes some code duplication.

changeset d89ace847745bc996a70a0a9e80d7f8c47c1a0e1
Author: Hans Feldt <hans.fe...@ericsson.com>
Date:   Tue, 13 May 2014 07:48:22 +0200

        amfd: move supreinst logic from comp to su [#713]

        Comp was directly manipulating SU data, this is now moved to SU.

changeset aad3b93eaded2acd45cc7bd2773d237394f6e6ad
Author: Hans Feldt <hans.fe...@ericsson.com>
Date:   Tue, 13 May 2014 07:48:22 +0200

        amfd: add SU::reset_all_comps_assign_flag [#713]

        Add and use a method for the task of resetting the assign flag of all 
the
        components of an SU. Preparing for later changing the comp_list
        implementation. Removes some code duplication.

changeset afa9835e11bf3f03ea190911d32445b186126b4b
Author: Hans Feldt <hans.fe...@ericsson.com>
Date:   Tue, 13 May 2014 07:48:23 +0200

        amfd: add SU::find_unassigned_comp_that_provides_cstype [#713]

        Add and use a method for the task of finding an unassigned component 
that
        can provide a specified CSType. Preparing for later changing the 
comp_list
        implementation. Removes some code duplication.


Added Files:
------------
 osaf/services/saf/amf/amfd/include/sutcomptype.h


Complete diffstat:
------------------
 osaf/services/saf/amf/amfd/comp.cc               |  83 
+++++++++++++++++------------------------------------------------------------------
 osaf/services/saf/amf/amfd/csi.cc                |  49 
+++++++++++++------------------------------------
 osaf/services/saf/amf/amfd/include/Makefile.am   |   1 +
 osaf/services/saf/amf/amfd/include/comp.h        |   1 +
 osaf/services/saf/amf/amfd/include/sg.h          |   1 +
 osaf/services/saf/amf/amfd/include/su.h          |  36 
+++---------------------------------
 osaf/services/saf/amf/amfd/include/sutcomptype.h |  44 
++++++++++++++++++++++++++++++++++++++++++++
 osaf/services/saf/amf/amfd/main.cc               |   3 ++-
 osaf/services/saf/amf/amfd/sgproc.cc             |  19 +++----------------
 osaf/services/saf/amf/amfd/su.cc                 |  70 
+++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++---
 osaf/services/saf/amf/amfd/sutcomptype.cc        |   3 +--
 osaf/services/saf/amf/amfd/sutype.cc             |   1 +
 12 files changed, 154 insertions(+), 157 deletions(-)


Testing Commands:
-----------------
 Build and start opensaf, start demo


Testing, Expected Results:
--------------------------
 works


Conditions of Submission:
-------------------------
 <<HOW MANY DAYS BEFORE PUSHING, CONSENSUS ETC>>


Arch      Built     Started    Linux distro
-------------------------------------------
mips        n          n
mips64      n          n
x86         n          n
x86_64      n          n
powerpc     n          n
powerpc64   n          n


Reviewer Checklist:
-------------------
[Submitters: make sure that your review doesn't trigger any checkmarks!]


Your checkin has not passed review because (see checked entries):

___ Your RR template is generally incomplete; it has too many blank entries
    that need proper data filled in.

___ You have failed to nominate the proper persons for review and push.

___ Your patches do not have proper short+long header

___ You have grammar/spelling in your header that is unacceptable.

___ You have exceeded a sensible line length in your headers/comments/text.

___ You have failed to put in a proper Trac Ticket # into your commits.

___ You have incorrectly put/left internal data in your comments/files
    (i.e. internal bug tracking tool IDs, product names etc)

___ You have not given any evidence of testing beyond basic build tests.
    Demonstrate some level of runtime or other sanity testing.

___ You have ^M present in some of your files. These have to be removed.

___ You have needlessly changed whitespace or added whitespace crimes
    like trailing spaces, or spaces before tabs.

___ You have mixed real technical changes with whitespace and other
    cosmetic code cleanup changes. These have to be separate commits.

___ You need to refactor your submission into logical chunks; there is
    too much content into a single commit.

___ You have extraneous garbage in your review (merge commits etc)

___ You have giant attachments which should never have been sent;
    Instead you should place your content in a public tree to be pulled.

___ You have too many commits attached to an e-mail; resend as threaded
    commits, or place in a public tree for a pull.

___ You have resent this content multiple times without a clear indication
    of what has changed between each re-send.

___ You have failed to adequately and individually address all of the
    comments and change requests that were proposed in the initial review.

___ You have a misconfigured ~/.hgrc file (i.e. username, email etc)

___ Your computer have a badly configured date and time; confusing the
    the threaded patch review.

___ Your changes affect IPC mechanism, and you don't present any results
    for in-service upgradability test.

___ Your changes affect user manual and documentation, your patch series
    do not contain the patch that updates the Doxygen manual.


------------------------------------------------------------------------------
"Accelerate Dev Cycles with Automated Cross-Browser Testing - For FREE
Instantly run your Selenium tests across 300+ browser/OS combos.
Get unparalleled scalability from the best Selenium testing platform available
Simple to use. Nothing to install. Get started now for free."
http://p.sf.net/sfu/SauceLabs
_______________________________________________
Opensaf-devel mailing list
Opensaf-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/opensaf-devel

Reply via email to