Summary: amfnd: Not all npi-components are restarted during SuRestart
escalation [#885]
Review request for Trac Ticket(s): 885
Peer Reviewer(s): Hans F, Hans N, Nagendra, Praveen
Pull request to:
Affected branch(es): default
Development branch: default
--------------------------------
Impacted area Impact y/n
--------------------------------
Docs n
Build system n
RPM/packaging n
Configuration files n
Startup scripts n
SAF services y
OpenSAF services n
Core libraries n
Samples n
Tests n
Other n
Comments (indicate scope for each "y" above):
---------------------------------------------
<<EXPLAIN/COMMENT THE PATCH SERIES HERE>>
changeset 06851db87ea919eb1b0b3b781202a04e5a64f6a7
Author: Minh Hon Chau <minh.c...@dektech.com.au>
Date: Tue, 13 May 2014 17:23:35 +1000
amfnd: Not all npi-components are restarted during SuRestart escalation
[#885]
Problem: In case of npi su restart recovery, the condition to change su
presence state is not sufficient. If the component of the last csi in
csi_list has been restarted first due to componentRestart (before
suRestart), amfnd can not find any next csi and changes the su presence
state to INSTANTIATED, this will miss the restart for the rest of
components.
Change: Mark all components are FAILED during suRestart, and su presence
state is changed only if all components are unmarked FAILED.
Complete diffstat:
------------------
osaf/services/saf/amf/amfnd/err.cc | 13 ++++++++++---
osaf/services/saf/amf/amfnd/susm.cc | 24 ++++++++++++++++++------
2 files changed, 28 insertions(+), 9 deletions(-)
Testing Commands:
-----------------
Deploy amf_demo as attached files in sourceforge ticket
Unlock-in/Unlock all SU1, SU2
pkill amf_demo on PL-3
Testing, Expected Results:
--------------------------
15 amf_demo(s) are restarted
Conditions of Submission:
-------------------------
<<HOW MANY DAYS BEFORE PUSHING, CONSENSUS ETC>>
Arch Built Started Linux distro
-------------------------------------------
mips n n
mips64 n n
x86 n n
x86_64 y n
powerpc n n
powerpc64 n n
Reviewer Checklist:
-------------------
[Submitters: make sure that your review doesn't trigger any checkmarks!]
Your checkin has not passed review because (see checked entries):
___ Your RR template is generally incomplete; it has too many blank entries
that need proper data filled in.
___ You have failed to nominate the proper persons for review and push.
___ Your patches do not have proper short+long header
___ You have grammar/spelling in your header that is unacceptable.
___ You have exceeded a sensible line length in your headers/comments/text.
___ You have failed to put in a proper Trac Ticket # into your commits.
___ You have incorrectly put/left internal data in your comments/files
(i.e. internal bug tracking tool IDs, product names etc)
___ You have not given any evidence of testing beyond basic build tests.
Demonstrate some level of runtime or other sanity testing.
___ You have ^M present in some of your files. These have to be removed.
___ You have needlessly changed whitespace or added whitespace crimes
like trailing spaces, or spaces before tabs.
___ You have mixed real technical changes with whitespace and other
cosmetic code cleanup changes. These have to be separate commits.
___ You need to refactor your submission into logical chunks; there is
too much content into a single commit.
___ You have extraneous garbage in your review (merge commits etc)
___ You have giant attachments which should never have been sent;
Instead you should place your content in a public tree to be pulled.
___ You have too many commits attached to an e-mail; resend as threaded
commits, or place in a public tree for a pull.
___ You have resent this content multiple times without a clear indication
of what has changed between each re-send.
___ You have failed to adequately and individually address all of the
comments and change requests that were proposed in the initial review.
___ You have a misconfigured ~/.hgrc file (i.e. username, email etc)
___ Your computer have a badly configured date and time; confusing the
the threaded patch review.
___ Your changes affect IPC mechanism, and you don't present any results
for in-service upgradability test.
___ Your changes affect user manual and documentation, your patch series
do not contain the patch that updates the Doxygen manual.
------------------------------------------------------------------------------
"Accelerate Dev Cycles with Automated Cross-Browser Testing - For FREE
Instantly run your Selenium tests across 300+ browser/OS combos.
Get unparalleled scalability from the best Selenium testing platform available
Simple to use. Nothing to install. Get started now for free."
http://p.sf.net/sfu/SauceLabs
_______________________________________________
Opensaf-devel mailing list
Opensaf-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/opensaf-devel
