Summary: replace particia tree in svctypecstype, svctype, cstype and ctcstype
[#713]
Review request for Trac Ticket(s): #713
Peer Reviewer(s):AMF contributors
Pull request to: <<LIST THE PERSON WITH PUSH ACCESS HERE>>
Affected branch(es):default
Development branch: <<IF ANY GIVE THE REPO URL>>
--------------------------------
Impacted area Impact y/n
--------------------------------
Docs n
Build system n
RPM/packaging n
Configuration files n
Startup scripts n
SAF services y
OpenSAF services n
Core libraries n
Samples n
Tests n
Other n
Comments (indicate scope for each "y" above):
---------------------------------------------
changeset 34b541f210e22177398cfb4621403972a657c0d5
Author: praveen.malv...@oracle.com
Date: Fri, 23 May 2014 14:34:56 +0530
amfd: use db_template to replace patricia tree in AVD_SVC_TYPE_CS_TYPE
[#713]
changeset 183ab6de0c288f7eb3f68e4efbc25f0953f2efd8
Author: praveen.malv...@oracle.com
Date: Fri, 23 May 2014 14:36:13 +0530
amfd: use db_template to replace patricia tree in AVD_SVC_TYPE [#713]
changeset c641d2f357a3c5d9af5099e8ef892e629b58e278
Author: praveen.malv...@oracle.com
Date: Fri, 23 May 2014 14:37:10 +0530
amfd: use db_template to replace patricia tree in avd_cstype_t [#713]
changeset 8a64a189b1f942fa852b77bbacf718cb19fdaf44
Author: praveen.malv...@oracle.com
Date: Fri, 23 May 2014 14:37:54 +0530
amfd: use db_template to replace patricia tree in AVD_CTCS_TYPE [#713]
Complete diffstat:
------------------
osaf/services/saf/amf/amfd/compcstype.cc | 4 ++--
osaf/services/saf/amf/amfd/csi.cc | 8 ++++----
osaf/services/saf/amf/amfd/cstype.cc | 35
++++++-----------------------------
osaf/services/saf/amf/amfd/ctcstype.cc | 37
+++++++++----------------------------
osaf/services/saf/amf/amfd/include/comp.h | 5 +++--
osaf/services/saf/amf/amfd/include/csi.h | 3 ++-
osaf/services/saf/amf/amfd/include/si.h | 6 ++----
osaf/services/saf/amf/amfd/si.cc | 5 ++---
osaf/services/saf/amf/amfd/svctype.cc | 27 ++++++---------------------
osaf/services/saf/amf/amfd/svctypecstypes.cc | 40
+++++++++++-----------------------------
osaf/services/saf/amf/amfd/util.cc | 2 +-
11 files changed, 48 insertions(+), 124 deletions(-)
Testing Commands:
-----------------
Bring up one controller.
Add AMF application.
Bring it up.
Bring down application.
Delete application.
Testing, Expected Results:
--------------------------
Pass.
Conditions of Submission:
-------------------------
Ack from atleast one reviewer.
Arch Built Started Linux distro
-------------------------------------------
mips n n
mips64 n n
x86 n n
x86_64 y y
powerpc n n
powerpc64 n n
Reviewer Checklist:
-------------------
[Submitters: make sure that your review doesn't trigger any checkmarks!]
Your checkin has not passed review because (see checked entries):
___ Your RR template is generally incomplete; it has too many blank entries
that need proper data filled in.
___ You have failed to nominate the proper persons for review and push.
___ Your patches do not have proper short+long header
___ You have grammar/spelling in your header that is unacceptable.
___ You have exceeded a sensible line length in your headers/comments/text.
___ You have failed to put in a proper Trac Ticket # into your commits.
___ You have incorrectly put/left internal data in your comments/files
(i.e. internal bug tracking tool IDs, product names etc)
___ You have not given any evidence of testing beyond basic build tests.
Demonstrate some level of runtime or other sanity testing.
___ You have ^M present in some of your files. These have to be removed.
___ You have needlessly changed whitespace or added whitespace crimes
like trailing spaces, or spaces before tabs.
___ You have mixed real technical changes with whitespace and other
cosmetic code cleanup changes. These have to be separate commits.
___ You need to refactor your submission into logical chunks; there is
too much content into a single commit.
___ You have extraneous garbage in your review (merge commits etc)
___ You have giant attachments which should never have been sent;
Instead you should place your content in a public tree to be pulled.
___ You have too many commits attached to an e-mail; resend as threaded
commits, or place in a public tree for a pull.
___ You have resent this content multiple times without a clear indication
of what has changed between each re-send.
___ You have failed to adequately and individually address all of the
comments and change requests that were proposed in the initial review.
___ You have a misconfigured ~/.hgrc file (i.e. username, email etc)
___ Your computer have a badly configured date and time; confusing the
the threaded patch review.
___ Your changes affect IPC mechanism, and you don't present any results
for in-service upgradability test.
___ Your changes affect user manual and documentation, your patch series
do not contain the patch that updates the Doxygen manual.
------------------------------------------------------------------------------
"Accelerate Dev Cycles with Automated Cross-Browser Testing - For FREE
Instantly run your Selenium tests across 300+ browser/OS combos.
Get unparalleled scalability from the best Selenium testing platform available
Simple to use. Nothing to install. Get started now for free."
http://p.sf.net/sfu/SauceLabs
_______________________________________________
Opensaf-devel mailing list
Opensaf-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/opensaf-devel
