Summary: amfnd: V2 Improve logging for error escalation decisions [#870] Review request for Trac Ticket(s): 870 Peer Reviewer(s): Hans F, Hans N, Nagendra, Praveen Pull request to: Affected branch(es): default Development branch: default
-------------------------------- Impacted area Impact y/n -------------------------------- Docs n Build system n RPM/packaging n Configuration files n Startup scripts n SAF services y OpenSAF services n Core libraries n Samples n Tests n Other n Comments (indicate scope for each "y" above): --------------------------------------------- This is V2. changeset 24c1b4c093478d6b4b0933e52f9809f60fefa228 Author: Gary Lee <gary....@dektech.com.au> Date: Wed, 28 May 2014 17:25:36 +1000 amfnd: Improve logging for error escalation decisions [#870] * log when SU restart/failover limits have been reached * log each time a SU restart/failover occurs * add a log entry when error escalation is changed * log each time a component is restarted, or when restart limits have been reached changeset 06168dad3288b8cdcdb3010dc63d2998a8cc6f6d Author: Gary Lee <gary....@dektech.com.au> Date: Wed, 28 May 2014 17:25:36 +1000 amfnd: Fix spelling mistakes [#870] Complete diffstat: ------------------ osaf/services/saf/amf/amfnd/err.cc | 83 +++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++---------- osaf/services/saf/amf/amfnd/include/avnd_cb.h | 2 ++ osaf/services/saf/amf/amfnd/include/avnd_su.h | 3 +++ osaf/services/saf/amf/amfnd/su.cc | 23 +++++++++++++++++++++++ 4 files changed, 101 insertions(+), 10 deletions(-) Testing Commands: ----------------- <<LIST THE COMMAND LINE TOOLS/STEPS TO TEST YOUR CHANGES>> Testing, Expected Results: -------------------------- <<PASTE COMMAND OUTPUTS / TEST RESULTS>> Conditions of Submission: ------------------------- <<HOW MANY DAYS BEFORE PUSHING, CONSENSUS ETC>> Arch Built Started Linux distro ------------------------------------------- mips n n mips64 n n x86 n n x86_64 y y powerpc n n powerpc64 n n Reviewer Checklist: ------------------- [Submitters: make sure that your review doesn't trigger any checkmarks!] Your checkin has not passed review because (see checked entries): ___ Your RR template is generally incomplete; it has too many blank entries that need proper data filled in. ___ You have failed to nominate the proper persons for review and push. ___ Your patches do not have proper short+long header ___ You have grammar/spelling in your header that is unacceptable. ___ You have exceeded a sensible line length in your headers/comments/text. ___ You have failed to put in a proper Trac Ticket # into your commits. ___ You have incorrectly put/left internal data in your comments/files (i.e. internal bug tracking tool IDs, product names etc) ___ You have not given any evidence of testing beyond basic build tests. Demonstrate some level of runtime or other sanity testing. ___ You have ^M present in some of your files. These have to be removed. ___ You have needlessly changed whitespace or added whitespace crimes like trailing spaces, or spaces before tabs. ___ You have mixed real technical changes with whitespace and other cosmetic code cleanup changes. These have to be separate commits. ___ You need to refactor your submission into logical chunks; there is too much content into a single commit. ___ You have extraneous garbage in your review (merge commits etc) ___ You have giant attachments which should never have been sent; Instead you should place your content in a public tree to be pulled. ___ You have too many commits attached to an e-mail; resend as threaded commits, or place in a public tree for a pull. ___ You have resent this content multiple times without a clear indication of what has changed between each re-send. ___ You have failed to adequately and individually address all of the comments and change requests that were proposed in the initial review. ___ You have a misconfigured ~/.hgrc file (i.e. username, email etc) ___ Your computer have a badly configured date and time; confusing the the threaded patch review. ___ Your changes affect IPC mechanism, and you don't present any results for in-service upgradability test. ___ Your changes affect user manual and documentation, your patch series do not contain the patch that updates the Doxygen manual. ------------------------------------------------------------------------------ Time is money. Stop wasting it! Get your web API in 5 minutes. www.restlet.com/download http://p.sf.net/sfu/restlet _______________________________________________ Opensaf-devel mailing list Opensaf-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/opensaf-devel