Summary: amfd: add support for different key types in db_template v2
Review request for Trac Ticket(s): #713
Peer Reviewer(s): HansF, Nagu, Praveen
Pull request to:
Affected branch(es): default
Development branch: default
--------------------------------
Impacted area Impact y/n
--------------------------------
Docs n
Build system n
RPM/packaging n
Configuration files n
Startup scripts n
SAF services y
OpenSAF services n
Core libraries n
Samples n
Tests n
Other n
Comments (indicate scope for each "y" above):
---------------------------------------------
<<EXPLAIN/COMMENT THE PATCH SERIES HERE>>
changeset 4e27c41850ed921768c48e06dfdd60dc0736f6b4
Author: Hans Nordeback <hans.nordeb...@ericsson.com>
Date: Mon, 02 Jun 2014 13:44:07 +0200
amfd: add support for different key types in db_template v4 [#713]
changeset 18bd26d00abfea1a110b591a5a0ae4028fc2e714
Author: Hans Nordeback <hans.nordeb...@ericsson.com>
Date: Mon, 02 Jun 2014 13:44:10 +0200
amfd: use new db_template for app v2 [#713]
changeset 53f87cf4a624b1f6ff471445fee8e3361dd9ae19
Author: Hans Nordeback <hans.nordeb...@ericsson.com>
Date: Mon, 02 Jun 2014 13:44:10 +0200
amfd: use new db_template for su v1 [#713]
changeset 4ed5ba2b35b5afe19e788da72c803e20c79d5705
Author: Hans Nordeback <hans.nordeb...@ericsson.com>
Date: Mon, 02 Jun 2014 13:44:10 +0200
amfd: use new db_template for si v1 [#713]
changeset f3fe76c0e1492f3c3f16084202300dd0f4f8e312
Author: Hans Nordeback <hans.nordeb...@ericsson.com>
Date: Mon, 02 Jun 2014 13:44:10 +0200
amfd: use new db_template for app_type v1 [#713]
changeset 3a0476bd2f4a8646da98679567f6b270f5f4df1c
Author: Hans Nordeback <hans.nordeb...@ericsson.com>
Date: Mon, 02 Jun 2014 13:44:10 +0200
amfd: use new db_template for nodegroup v1 [#713]
changeset e1d65c11f8a6139df8a63719b7af081cf767ae48
Author: Hans Nordeback <hans.nordeb...@ericsson.com>
Date: Mon, 02 Jun 2014 13:44:10 +0200
amfd: use new db_template for sg v1 [#713]
Complete diffstat:
------------------
osaf/services/saf/amf/amfd/app.cc | 18 +++++++++---------
osaf/services/saf/amf/amfd/include/app.h | 2 +-
osaf/services/saf/amf/amfd/include/db_template.h | 51
++++++++++++++++++++++++++++-----------------------
osaf/services/saf/amf/amfd/include/util.h | 6 +++++-
osaf/services/saf/amf/amfd/util.cc | 5 +++++
5 files changed, 48 insertions(+), 34 deletions(-)
Testing Commands:
-----------------
<<LIST THE COMMAND LINE TOOLS/STEPS TO TEST YOUR CHANGES>>
Testing, Expected Results:
--------------------------
<<PASTE COMMAND OUTPUTS / TEST RESULTS>>
Conditions of Submission:
-------------------------
<<HOW MANY DAYS BEFORE PUSHING, CONSENSUS ETC>>
Arch Built Started Linux distro
-------------------------------------------
mips n n
mips64 n n
x86 n n
x86_64 y y
powerpc n n
powerpc64 n n
Reviewer Checklist:
-------------------
[Submitters: make sure that your review doesn't trigger any checkmarks!]
Your checkin has not passed review because (see checked entries):
___ Your RR template is generally incomplete; it has too many blank entries
that need proper data filled in.
___ You have failed to nominate the proper persons for review and push.
___ Your patches do not have proper short+long header
___ You have grammar/spelling in your header that is unacceptable.
___ You have exceeded a sensible line length in your headers/comments/text.
___ You have failed to put in a proper Trac Ticket # into your commits.
___ You have incorrectly put/left internal data in your comments/files
(i.e. internal bug tracking tool IDs, product names etc)
___ You have not given any evidence of testing beyond basic build tests.
Demonstrate some level of runtime or other sanity testing.
___ You have ^M present in some of your files. These have to be removed.
___ You have needlessly changed whitespace or added whitespace crimes
like trailing spaces, or spaces before tabs.
___ You have mixed real technical changes with whitespace and other
cosmetic code cleanup changes. These have to be separate commits.
___ You need to refactor your submission into logical chunks; there is
too much content into a single commit.
___ You have extraneous garbage in your review (merge commits etc)
___ You have giant attachments which should never have been sent;
Instead you should place your content in a public tree to be pulled.
___ You have too many commits attached to an e-mail; resend as threaded
commits, or place in a public tree for a pull.
___ You have resent this content multiple times without a clear indication
of what has changed between each re-send.
___ You have failed to adequately and individually address all of the
comments and change requests that were proposed in the initial review.
___ You have a misconfigured ~/.hgrc file (i.e. username, email etc)
___ Your computer have a badly configured date and time; confusing the
the threaded patch review.
___ Your changes affect IPC mechanism, and you don't present any results
for in-service upgradability test.
___ Your changes affect user manual and documentation, your patch series
do not contain the patch that updates the Doxygen manual.
------------------------------------------------------------------------------
Learn Graph Databases - Download FREE O'Reilly Book
"Graph Databases" is the definitive new guide to graph databases and their
applications. Written by three acclaimed leaders in the field,
this first edition is now available. Download your free book today!
http://p.sf.net/sfu/NeoTech
_______________________________________________
Opensaf-devel mailing list
Opensaf-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/opensaf-devel
