Summary: AMF SU refactoring
Review request for Trac Ticket(s): 713
Peer Reviewer(s): AMF developers
Pull request to: <<LIST THE PERSON WITH PUSH ACCESS HERE>>
Affected branch(es): default
Development branch: <<IF ANY GIVE THE REPO URL>>
--------------------------------
Impacted area Impact y/n
--------------------------------
Docs n
Build system n
RPM/packaging n
Configuration files n
Startup scripts n
SAF services y
OpenSAF services n
Core libraries n
Samples n
Tests n
Other n
Comments (indicate scope for each "y" above):
---------------------------------------------
changeset 4069cbdbf1b767fa0359c2933f8e516ca7550f13
Author: Hans Feldt <hans.fe...@ericsson.com>
Date: Tue, 03 Jun 2014 06:22:25 +0200
amfd: remove mds copy support [#713]
This support is no longer needed. Was used when avd and avnd was
collocated
in the same process (ncs_scap).
changeset 283d69e5782be5d0857585d4faa56be558cacb7f
Author: Hans Feldt <hans.fe...@ericsson.com>
Date: Tue, 03 Jun 2014 06:26:48 +0200
amfd: turn function su_disable_comps into a method [#713]
changeset 9017b5cc82498646e9c46e3faffa8cc9db20b6ac
Author: Hans Feldt <hans.fe...@ericsson.com>
Date: Tue, 03 Jun 2014 06:26:56 +0200
amfd: turn function su_complete_admin_op into a method [#713]
changeset 7670204193f8dd56c4eb6655b861f38e0e316ae8
Author: Hans Feldt <hans.fe...@ericsson.com>
Date: Tue, 03 Jun 2014 07:21:46 +0200
amfd: break out admin ops into own methods [#713]
complexity of su.cc dropped pretty good:
$ pmccabe su.cc | sort -nr | head -2 73 78 154 865 337 su.cc(865):
su_admin_op_cb 38 38 101 230 201 su.cc(230): is_config_valid
$ pmccabe su.cc | sort -nr | head -2 38 38 101 230 201 su.cc(230):
is_config_valid 35 40 56 1104 133 su.cc(1104): su_admin_op_cb
Complete diffstat:
------------------
osaf/libs/common/amf/d2nmsg.c | 184
---------------------------------------
osaf/libs/common/amf/include/amf_d2nmsg.h | 1 -
osaf/services/saf/amf/amfd/include/mds.h | 1 -
osaf/services/saf/amf/amfd/include/msg.h | 1 -
osaf/services/saf/amf/amfd/include/su.h | 12 ++
osaf/services/saf/amf/amfd/mds.cc | 175
++++++++++++++++---------------------
osaf/services/saf/amf/amfd/ndmsg.cc | 35 -------
osaf/services/saf/amf/amfd/sgproc.cc | 66 ++-----------
osaf/services/saf/amf/amfd/su.cc | 497
++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++---------------------------------------------
9 files changed, 385 insertions(+), 587 deletions(-)
Testing Commands:
-----------------
Build and start opensaf
Testing, Expected Results:
--------------------------
<<PASTE COMMAND OUTPUTS / TEST RESULTS>>
Conditions of Submission:
-------------------------
<<HOW MANY DAYS BEFORE PUSHING, CONSENSUS ETC>>
Arch Built Started Linux distro
-------------------------------------------
mips n n
mips64 n n
x86 n n
x86_64 n n
powerpc n n
powerpc64 n n
Reviewer Checklist:
-------------------
[Submitters: make sure that your review doesn't trigger any checkmarks!]
Your checkin has not passed review because (see checked entries):
___ Your RR template is generally incomplete; it has too many blank entries
that need proper data filled in.
___ You have failed to nominate the proper persons for review and push.
___ Your patches do not have proper short+long header
___ You have grammar/spelling in your header that is unacceptable.
___ You have exceeded a sensible line length in your headers/comments/text.
___ You have failed to put in a proper Trac Ticket # into your commits.
___ You have incorrectly put/left internal data in your comments/files
(i.e. internal bug tracking tool IDs, product names etc)
___ You have not given any evidence of testing beyond basic build tests.
Demonstrate some level of runtime or other sanity testing.
___ You have ^M present in some of your files. These have to be removed.
___ You have needlessly changed whitespace or added whitespace crimes
like trailing spaces, or spaces before tabs.
___ You have mixed real technical changes with whitespace and other
cosmetic code cleanup changes. These have to be separate commits.
___ You need to refactor your submission into logical chunks; there is
too much content into a single commit.
___ You have extraneous garbage in your review (merge commits etc)
___ You have giant attachments which should never have been sent;
Instead you should place your content in a public tree to be pulled.
___ You have too many commits attached to an e-mail; resend as threaded
commits, or place in a public tree for a pull.
___ You have resent this content multiple times without a clear indication
of what has changed between each re-send.
___ You have failed to adequately and individually address all of the
comments and change requests that were proposed in the initial review.
___ You have a misconfigured ~/.hgrc file (i.e. username, email etc)
___ Your computer have a badly configured date and time; confusing the
the threaded patch review.
___ Your changes affect IPC mechanism, and you don't present any results
for in-service upgradability test.
___ Your changes affect user manual and documentation, your patch series
do not contain the patch that updates the Doxygen manual.
------------------------------------------------------------------------------
Learn Graph Databases - Download FREE O'Reilly Book
"Graph Databases" is the definitive new guide to graph databases and their
applications. Written by three acclaimed leaders in the field,
this first edition is now available. Download your free book today!
http://p.sf.net/sfu/NeoTech
_______________________________________________
Opensaf-devel mailing list
Opensaf-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/opensaf-devel
