Ack from me. I will create an enhancement ticket for makeing the imm-oi (mainly implemented by the PBE) be more cooperative in allowing changes to opensafImmSyncBatchSize.
/AndesBj -----Original Message----- From: mahesh.va...@oracle.com [mailto:mahesh.va...@oracle.com] Sent: den 27 maj 2014 06:11 To: Anders Björnerstedt; Zoran Milinkovic Cc: opensaf-devel@lists.sourceforge.net Subject: [PATCH 0 of 1] Review Request for imm: adjust imm constants for bigger MDS message [#862] Summary:imm: adjust imm constants for bigger MDS message [#862] Review request for Trac Ticket(s): #862 Peer Reviewer(s): Anders/Zoran Pull request to: <<LIST THE PERSON WITH PUSH ACCESS HERE>> Affected branch(es): default Development branch: <<IF ANY GIVE THE REPO URL>> -------------------------------- Impacted area Impact y/n -------------------------------- Docs n Build system n RPM/packaging n Configuration files n Startup scripts n SAF services y OpenSAF services n Core libraries n Samples n Tests n Other n Comments (indicate scope for each "y" above): --------------------------------------------- changeset 8525ca706261f2233e4d953eed54280e34ae7e91 Author: A V Mahesh <mahesh.va...@oracle.com> Date: Tue, 27 May 2014 09:34:27 +0530 imm: adjust imm constants for bigger MDS message [#862] No functional changes. Adjust the default values to utilize new MDS_DIRECT_BUF_MAXSIZE of 65479. After this changes you will observed considerable improvement in Node Sync Measurements. I tested with 300k Objects with single PBE ( loading imm.db) It use to take 77 sec previously , after this changes it is taking 14 sec only. IMP Note : You need to prepare fresh/NEW with 300k Objects and then file to see the improvement ( opensafImmSyncBatchSize size will be 65479). If you are using old imm.db ,you will NOT see the advantage in sync performance ,even after new binaries are installed ( opensafImmSyncBatchSize size with 4096 ) Some how I failed to modif opensafImmSyncBatchSize value from 4096 to new value 65479 of object at run-time. (immcfg -a opensafImmSyncBatchSize=65479 opensafImm=opensafImm,safApp=safImmService) Complete diffstat: ------------------ osaf/libs/common/immsv/include/immsv_api.h | 6 +++--- osaf/services/saf/immsv/immloadd/imm_loader.cc | 1 + osaf/services/saf/immsv/immnd/immnd_evt.c | 10 +++++----- 3 files changed, 9 insertions(+), 8 deletions(-) Testing Commands: ----------------- Prepare fresh/NEW with 300k Objects and do Node Sync Measurements with single PBE ( loading imm.db) ( opensafImmSyncBatchSize size will be 65479) Testing, Expected Results: -------------------------- <<PASTE COMMAND OUTPUTS / TEST RESULTS>> Conditions of Submission: ------------------------- <<HOW MANY DAYS BEFORE PUSHING, CONSENSUS ETC>> Arch Built Started Linux distro ------------------------------------------- mips n n mips64 n n x86 n n x86_64 y y powerpc n n powerpc64 n n Reviewer Checklist: ------------------- [Submitters: make sure that your review doesn't trigger any checkmarks!] Your checkin has not passed review because (see checked entries): ___ Your RR template is generally incomplete; it has too many blank entries that need proper data filled in. ___ You have failed to nominate the proper persons for review and push. ___ Your patches do not have proper short+long header ___ You have grammar/spelling in your header that is unacceptable. ___ You have exceeded a sensible line length in your headers/comments/text. ___ You have failed to put in a proper Trac Ticket # into your commits. ___ You have incorrectly put/left internal data in your comments/files (i.e. internal bug tracking tool IDs, product names etc) ___ You have not given any evidence of testing beyond basic build tests. Demonstrate some level of runtime or other sanity testing. ___ You have ^M present in some of your files. These have to be removed. ___ You have needlessly changed whitespace or added whitespace crimes like trailing spaces, or spaces before tabs. ___ You have mixed real technical changes with whitespace and other cosmetic code cleanup changes. These have to be separate commits. ___ You need to refactor your submission into logical chunks; there is too much content into a single commit. ___ You have extraneous garbage in your review (merge commits etc) ___ You have giant attachments which should never have been sent; Instead you should place your content in a public tree to be pulled. ___ You have too many commits attached to an e-mail; resend as threaded commits, or place in a public tree for a pull. ___ You have resent this content multiple times without a clear indication of what has changed between each re-send. ___ You have failed to adequately and individually address all of the comments and change requests that were proposed in the initial review. ___ You have a misconfigured ~/.hgrc file (i.e. username, email etc) ___ Your computer have a badly configured date and time; confusing the the threaded patch review. ___ Your changes affect IPC mechanism, and you don't present any results for in-service upgradability test. ___ Your changes affect user manual and documentation, your patch series do not contain the patch that updates the Doxygen manual. ------------------------------------------------------------------------------ Learn Graph Databases - Download FREE O'Reilly Book "Graph Databases" is the definitive new guide to graph databases and their applications. Written by three acclaimed leaders in the field, this first edition is now available. Download your free book today! http://p.sf.net/sfu/NeoTech _______________________________________________ Opensaf-devel mailing list Opensaf-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/opensaf-devel
