On 6/11/2014 12:07 PM, Hans Feldt wrote: > tools/devel/review/00-README > > It is impossible from just reading the patch to understand what this is about The ticket explains the problem and i thought the fix is simple. But i do agree that more explanation could have been added, i would take care from next time.
-AVM > /Hans > >> -----Original Message----- >> From: Hans Feldt [mailto:hans.fe...@ericsson.com] >> Sent: den 11 juni 2014 08:28 >> To: ramesh.bet...@oracle.com; mahesh.va...@oracle.com >> Cc: opensaf-devel@lists.sourceforge.net >> Subject: Re: [devel] [PATCH 1 of 1] cpsv: set dtaBuff to NULL and readSize >> to zero in TrackCallback [#733] >> >> Not a proper commit message >> /Hans >> >> Skickat från min Sony XperiaT-smartphone >> >> >> ---- mahesh.va...@oracle.com skrev ---- >> >> osaf/libs/agents/saf/cpa/cpa_proc.c | 2 +- >> osaf/services/saf/cpsv/cpnd/cpnd_proc.c | 2 ++ >> 2 files changed, 3 insertions(+), 1 deletions(-) >> >> >> Now in the TrackCallback() the ioVector dtaBuff is set to NULL and readSize >> set to zero >> >> diff --git a/osaf/libs/agents/saf/cpa/cpa_proc.c >> b/osaf/libs/agents/saf/cpa/cpa_proc.c >> --- a/osaf/libs/agents/saf/cpa/cpa_proc.c >> +++ b/osaf/libs/agents/saf/cpa/cpa_proc.c >> @@ -542,7 +542,7 @@ static void cpa_proc_ckpt_arrival_ntfy(C >> >> callback->ioVector[i].sectionId = ckpt_data->sec_id; >> >> >> callback->ioVector[i].dataBuffer = NULL; >> - /* >> callback->ioVector[i].dataBuffer = ckpt_data->data; */ >> + >> callback->ioVector[i].readSize = 0; >> >> callback->ioVector[i].dataSize = ckpt_data->dataSize; >> >> callback->ioVector[i].dataOffset = ckpt_data->dataOffset; >> ckpt_data = >> ckpt_data->next; >> diff --git a/osaf/services/saf/cpsv/cpnd/cpnd_proc.c >> b/osaf/services/saf/cpsv/cpnd/cpnd_proc.c >> --- a/osaf/services/saf/cpsv/cpnd/cpnd_proc.c >> +++ b/osaf/services/saf/cpsv/cpnd/cpnd_proc.c >> @@ -269,6 +269,8 @@ uint32_t cpnd_proc_ckpt_arrival_info_ntf >> send_evt.info.cpa.info.arr_msg.mdest = >> in_evt->agent_mdest; >> send_evt.info.cpa.info.arr_msg.num_of_elmts = >> in_evt->num_of_elmts; >> send_evt.info.cpa.info.arr_msg.ckpt_data = >> in_evt->data; >> + send_evt.info.cpa.info.arr_msg.ckpt_data->data = >> NULL; >> + send_evt.info.cpa.info.arr_msg.ckpt_data->readSize = >> 0; >> >> rc = cpnd_mds_msg_send(cb, NCSMDS_SVC_ID_CPA, >> ptr_cl_node->cnode->agent_mds_dest, &send_evt); >> } >> >> ------------------------------------------------------------------------------ >> HPCC Systems Open Source Big Data Platform from LexisNexis Risk Solutions >> Find What Matters Most in Your Big Data with HPCC Systems >> Open Source. Fast. Scalable. Simple. Ideal for Dirty Data. >> Leverages Graph Analysis for Fast Processing & Easy Data Exploration >> http://p.sf.net/sfu/hpccsystems >> _______________________________________________ >> Opensaf-devel mailing list >> Opensaf-devel@lists.sourceforge.net >> https://lists.sourceforge.net/lists/listinfo/opensaf-devel >> ------------------------------------------------------------------------------ >> HPCC Systems Open Source Big Data Platform from LexisNexis Risk Solutions >> Find What Matters Most in Your Big Data with HPCC Systems >> Open Source. Fast. Scalable. Simple. Ideal for Dirty Data. >> Leverages Graph Analysis for Fast Processing & Easy Data Exploration >> http://p.sf.net/sfu/hpccsystems >> _______________________________________________ >> Opensaf-devel mailing list >> Opensaf-devel@lists.sourceforge.net >> https://lists.sourceforge.net/lists/listinfo/opensaf-devel ------------------------------------------------------------------------------ HPCC Systems Open Source Big Data Platform from LexisNexis Risk Solutions Find What Matters Most in Your Big Data with HPCC Systems Open Source. Fast. Scalable. Simple. Ideal for Dirty Data. Leverages Graph Analysis for Fast Processing & Easy Data Exploration http://p.sf.net/sfu/hpccsystems _______________________________________________ Opensaf-devel mailing list Opensaf-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/opensaf-devel
