Summary: amfd: SI refactoring part 3 [#713] Review request for Trac Ticket(s): 713 Peer Reviewer(s): AMF maintainers Pull request to: Affected branch(es): default Development branch: default
-------------------------------- Impacted area Impact y/n -------------------------------- Docs n Build system n RPM/packaging n Configuration files n Startup scripts n SAF services y OpenSAF services n Core libraries n Samples n Tests n Other n Comments (indicate scope for each "y" above): --------------------------------------------- This is patch set #3. Patch sets #1 and #2 should be applied first. This patch set continues to convert static C functions and macros to C++ member functions. changeset 9bb32621e9c373564255301ff4f947b4ec0ee8c4 Author: Gary Lee <[email protected]> Date: Thu, 12 Jun 2014 16:20:45 +1000 amfd: Convert avd_si_admin_state_set to a AVD_SI member function [#713] changeset db9c8cf7379d55823d989644183315bb20b99e33 Author: Gary Lee <[email protected]> Date: Thu, 12 Jun 2014 16:20:45 +1000 amfd: Fix whitespace problems in AVD_SI::set_admin_state [#713] changeset 5b65c3992f215e63ca77fac0a727efa7effcc545 Author: Gary Lee <[email protected]> Date: Thu, 12 Jun 2014 16:20:45 +1000 amfd: Convert add_rankedsu and remove_rankedsu to member functions [#713] changeset db7b41855667d4f8857c7afa8410ad3975a1e0cb Author: Gary Lee <[email protected]> Date: Thu, 12 Jun 2014 16:20:45 +1000 amfd: Convert set_si_switch from a macro to member function [#713] Complete diffstat: ------------------ osaf/services/saf/amf/amfd/include/si.h | 15 +++++++-------- osaf/services/saf/amf/amfd/sg_2n_fsm.cc | 19 ++++++++++--------- osaf/services/saf/amf/amfd/sg_nored_fsm.cc | 14 +++++++------- osaf/services/saf/amf/amfd/sg_npm_fsm.cc | 48 ++++++++++++++++++++++++------------------------ osaf/services/saf/amf/amfd/sg_nway_fsm.cc | 38 +++++++++++++++++++------------------- osaf/services/saf/amf/amfd/sg_nwayact_fsm.cc | 32 ++++++++++++++++---------------- osaf/services/saf/amf/amfd/si.cc | 55 ++++++++++++++++++++++++++++++------------------------- osaf/services/saf/amf/amfd/sirankedsu.cc | 4 ++-- 8 files changed, 115 insertions(+), 110 deletions(-) Testing Commands: ----------------- <<LIST THE COMMAND LINE TOOLS/STEPS TO TEST YOUR CHANGES>> Testing, Expected Results: -------------------------- <<PASTE COMMAND OUTPUTS / TEST RESULTS>> Conditions of Submission: ------------------------- <<HOW MANY DAYS BEFORE PUSHING, CONSENSUS ETC>> Arch Built Started Linux distro ------------------------------------------- mips n n mips64 n n x86 n n x86_64 y y powerpc n n powerpc64 n n Reviewer Checklist: ------------------- [Submitters: make sure that your review doesn't trigger any checkmarks!] Your checkin has not passed review because (see checked entries): ___ Your RR template is generally incomplete; it has too many blank entries that need proper data filled in. ___ You have failed to nominate the proper persons for review and push. ___ Your patches do not have proper short+long header ___ You have grammar/spelling in your header that is unacceptable. ___ You have exceeded a sensible line length in your headers/comments/text. ___ You have failed to put in a proper Trac Ticket # into your commits. ___ You have incorrectly put/left internal data in your comments/files (i.e. internal bug tracking tool IDs, product names etc) ___ You have not given any evidence of testing beyond basic build tests. Demonstrate some level of runtime or other sanity testing. ___ You have ^M present in some of your files. These have to be removed. ___ You have needlessly changed whitespace or added whitespace crimes like trailing spaces, or spaces before tabs. ___ You have mixed real technical changes with whitespace and other cosmetic code cleanup changes. These have to be separate commits. ___ You need to refactor your submission into logical chunks; there is too much content into a single commit. ___ You have extraneous garbage in your review (merge commits etc) ___ You have giant attachments which should never have been sent; Instead you should place your content in a public tree to be pulled. ___ You have too many commits attached to an e-mail; resend as threaded commits, or place in a public tree for a pull. ___ You have resent this content multiple times without a clear indication of what has changed between each re-send. ___ You have failed to adequately and individually address all of the comments and change requests that were proposed in the initial review. ___ You have a misconfigured ~/.hgrc file (i.e. username, email etc) ___ Your computer have a badly configured date and time; confusing the the threaded patch review. ___ Your changes affect IPC mechanism, and you don't present any results for in-service upgradability test. ___ Your changes affect user manual and documentation, your patch series do not contain the patch that updates the Doxygen manual. ------------------------------------------------------------------------------ HPCC Systems Open Source Big Data Platform from LexisNexis Risk Solutions Find What Matters Most in Your Big Data with HPCC Systems Open Source. Fast. Scalable. Simple. Ideal for Dirty Data. Leverages Graph Analysis for Fast Processing & Easy Data Exploration http://p.sf.net/sfu/hpccsystems _______________________________________________ Opensaf-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/opensaf-devel
