Summary:amfd : use of db_template in si_dep.cc [#713] Review request for Trac Ticket(s): #713 Peer Reviewer(s): AMF developers. Pull request to: <<LIST THE PERSON WITH PUSH ACCESS HERE>> Affected branch(es): Default Development branch: <<IF ANY GIVE THE REPO URL>>
-------------------------------- Impacted area Impact y/n -------------------------------- Docs n Build system n RPM/packaging n Configuration files n Startup scripts n SAF services y OpenSAF services n Core libraries n Samples n Tests n Other n Comments (indicate scope for each "y" above): --------------------------------------------- changeset 9fe2851f7bb47d56bea8193a88abb852dff9dfd5 Author: [email protected] Date: Mon, 16 Jun 2014 10:33:11 +0530 amfd : use of db_template in si_dep.cc [#713] Following changes have been done: 1)Replaced patricia tree using db_template. 2)Instead of AVD_SI_SI_DEP_INDX and AVD_SI_SI_DEP, now there is a class AVD_SI_DEP. 3)Earlier there were two separate databases, one had sponsor as primary key and dependent as secondary key and other database had vice versa. This has been replaced by a single database of AVD_SI_DEP. TODO:Use of methods and other proposed changes as per #713. Complete diffstat: ------------------ osaf/services/saf/amf/amfd/include/cb.h | 7 - osaf/services/saf/amf/amfd/include/si_dep.h | 53 +--- osaf/services/saf/amf/amfd/include/timer.h | 4 +- osaf/services/saf/amf/amfd/si_dep.cc | 709 ++++++++++++++++++------------------------------------------- osaf/services/saf/amf/amfd/siass.cc | 32 +-- 5 files changed, 233 insertions(+), 572 deletions(-) Testing Commands: ----------------- Performed some basic operations like lock on SG, SI etc on SI dependency enabled configuration. Testing, Expected Results: -------------------------- PASSED Conditions of Submission: ------------------------- Ack from reviewers. Arch Built Started Linux distro ------------------------------------------- mips n n mips64 n n x86 n n x86_64 y y powerpc n n powerpc64 n n Reviewer Checklist: ------------------- [Submitters: make sure that your review doesn't trigger any checkmarks!] Your checkin has not passed review because (see checked entries): ___ Your RR template is generally incomplete; it has too many blank entries that need proper data filled in. ___ You have failed to nominate the proper persons for review and push. ___ Your patches do not have proper short+long header ___ You have grammar/spelling in your header that is unacceptable. ___ You have exceeded a sensible line length in your headers/comments/text. ___ You have failed to put in a proper Trac Ticket # into your commits. ___ You have incorrectly put/left internal data in your comments/files (i.e. internal bug tracking tool IDs, product names etc) ___ You have not given any evidence of testing beyond basic build tests. Demonstrate some level of runtime or other sanity testing. ___ You have ^M present in some of your files. These have to be removed. ___ You have needlessly changed whitespace or added whitespace crimes like trailing spaces, or spaces before tabs. ___ You have mixed real technical changes with whitespace and other cosmetic code cleanup changes. These have to be separate commits. ___ You need to refactor your submission into logical chunks; there is too much content into a single commit. ___ You have extraneous garbage in your review (merge commits etc) ___ You have giant attachments which should never have been sent; Instead you should place your content in a public tree to be pulled. ___ You have too many commits attached to an e-mail; resend as threaded commits, or place in a public tree for a pull. ___ You have resent this content multiple times without a clear indication of what has changed between each re-send. ___ You have failed to adequately and individually address all of the comments and change requests that were proposed in the initial review. ___ You have a misconfigured ~/.hgrc file (i.e. username, email etc) ___ Your computer have a badly configured date and time; confusing the the threaded patch review. ___ Your changes affect IPC mechanism, and you don't present any results for in-service upgradability test. ___ Your changes affect user manual and documentation, your patch series do not contain the patch that updates the Doxygen manual. ------------------------------------------------------------------------------ HPCC Systems Open Source Big Data Platform from LexisNexis Risk Solutions Find What Matters Most in Your Big Data with HPCC Systems Open Source. Fast. Scalable. Simple. Ideal for Dirty Data. Leverages Graph Analysis for Fast Processing & Easy Data Exploration http://p.sf.net/sfu/hpccsystems _______________________________________________ Opensaf-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/opensaf-devel
