Summary: Convert remaining SG function ptrs to methods
Review request for Trac Ticket(s): 713
Peer Reviewer(s): Hans, Praveen
Pull request to: <<LIST THE PERSON WITH PUSH ACCESS HERE>>
Affected branch(es): default
Development branch: <<IF ANY GIVE THE REPO URL>>
--------------------------------
Impacted area Impact y/n
--------------------------------
Docs n
Build system n
RPM/packaging n
Configuration files n
Startup scripts n
SAF services y
OpenSAF services n
Core libraries n
Samples n
Tests n
Other n
Comments (indicate scope for each "y" above):
---------------------------------------------
changeset a286a6bca7ddbf60107c3b937b73621b1d9a7ae6
Author: Hans Feldt <hans.fe...@ericsson.com>
Date: Thu, 19 Jun 2014 07:48:41 +0200
amfd: change SG func ptr si_func to method si_assign [#713]
changeset a3bbfdea564e844361837c32657dc88f250046cc
Author: Hans Feldt <hans.fe...@ericsson.com>
Date: Thu, 19 Jun 2014 07:49:19 +0200
amfd: change SG si_admin_down function ptr to method [#713]
changeset 607b89048b7541f735fe5f49b4e885dcbefd361d
Author: Hans Feldt <hans.fe...@ericsson.com>
Date: Thu, 19 Jun 2014 07:49:57 +0200
amfd: change SG si_swap function ptr to method [#713]
changeset d8c8b3859f4b609848493ad807c77f2b1ccf7333
Author: Hans Feldt <hans.fe...@ericsson.com>
Date: Thu, 19 Jun 2014 07:50:31 +0200
amfd: change SG sg_admin_down function ptr to method [#713]
changeset 23d341591fdfcd7dbee66d8e7705af4bd6a08b80
Author: Hans Feldt <hans.fe...@ericsson.com>
Date: Thu, 19 Jun 2014 07:51:11 +0200
amfd: change SG su_insvc function ptr to method [#713]
changeset d678346056203212e4b29e4ba32ff0a7bd6d75e8
Author: Hans Feldt <hans.fe...@ericsson.com>
Date: Thu, 19 Jun 2014 07:51:44 +0200
amfd: change SG su_fault function ptr to method [#713]
changeset 5b42270066ef49c65c1973009ed3249524486fd6
Author: Hans Feldt <hans.fe...@ericsson.com>
Date: Thu, 19 Jun 2014 07:52:06 +0200
amfd: change SG su_admin_down function ptr to method [#713]
changeset 388fb2f1a5d6e148bfd8845f39b97f83577296ed
Author: Hans Feldt <hans.fe...@ericsson.com>
Date: Thu, 19 Jun 2014 07:52:28 +0200
amfd: change SG susi_success function ptr to method [#713]
changeset 4285c733caf4ae4a66393864283fdf4d00fc2238
Author: Hans Feldt <hans.fe...@ericsson.com>
Date: Thu, 19 Jun 2014 07:53:42 +0200
amfd: change SG susi_failed function ptr to method [#713]
changeset c761b418a85fd5001e9df2f4d362678aeb239d6f
Author: Hans Feldt <hans.fe...@ericsson.com>
Date: Thu, 19 Jun 2014 07:53:57 +0200
amfd: remove SG red model specific init [#713]
changeset 2f8fa723675fa5413582cca6cc94a7a35e427841
Author: Hans Feldt <hans.fe...@ericsson.com>
Date: Thu, 19 Jun 2014 07:55:36 +0200
amfd: add SG methods similar to existing macros [#713]
Macros are supposed to be replaced by calls to these methods eventually.
Complete diffstat:
------------------
osaf/services/saf/amf/amfd/csi.cc | 2 +-
osaf/services/saf/amf/amfd/include/proc.h | 74
-----------------------------------
osaf/services/saf/amf/amfd/include/sg.h | 198
++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++---------
osaf/services/saf/amf/amfd/sg.cc | 92
++++++++++++++++++++++++++++++++++++++-----
osaf/services/saf/amf/amfd/sg_2n_fsm.cc | 225
+++++-----------------------------------------------------------------------------------------------------
osaf/services/saf/amf/amfd/sg_nored_fsm.cc | 211
++++-----------------------------------------------------------------------------------------------
osaf/services/saf/amf/amfd/sg_npm_fsm.cc | 209
++++----------------------------------------------------------------------------------------------
osaf/services/saf/amf/amfd/sg_nway_fsm.cc | 186
++++-----------------------------------------------------------------------------------
osaf/services/saf/amf/amfd/sg_nwayact_fsm.cc | 211
++++-----------------------------------------------------------------------------------------------
osaf/services/saf/amf/amfd/si.cc | 21 +++------
osaf/services/saf/amf/amfd/si_dep.cc | 2 +-
11 files changed, 318 insertions(+), 1113 deletions(-)
Testing Commands:
-----------------
Build and start opensaf
Testing, Expected Results:
--------------------------
Starts opensaf
Conditions of Submission:
-------------------------
<<HOW MANY DAYS BEFORE PUSHING, CONSENSUS ETC>>
Arch Built Started Linux distro
-------------------------------------------
mips n n
mips64 n n
x86 n n
x86_64 y y
powerpc n n
powerpc64 n n
Reviewer Checklist:
-------------------
[Submitters: make sure that your review doesn't trigger any checkmarks!]
Your checkin has not passed review because (see checked entries):
___ Your RR template is generally incomplete; it has too many blank entries
that need proper data filled in.
___ You have failed to nominate the proper persons for review and push.
___ Your patches do not have proper short+long header
___ You have grammar/spelling in your header that is unacceptable.
___ You have exceeded a sensible line length in your headers/comments/text.
___ You have failed to put in a proper Trac Ticket # into your commits.
___ You have incorrectly put/left internal data in your comments/files
(i.e. internal bug tracking tool IDs, product names etc)
___ You have not given any evidence of testing beyond basic build tests.
Demonstrate some level of runtime or other sanity testing.
___ You have ^M present in some of your files. These have to be removed.
___ You have needlessly changed whitespace or added whitespace crimes
like trailing spaces, or spaces before tabs.
___ You have mixed real technical changes with whitespace and other
cosmetic code cleanup changes. These have to be separate commits.
___ You need to refactor your submission into logical chunks; there is
too much content into a single commit.
___ You have extraneous garbage in your review (merge commits etc)
___ You have giant attachments which should never have been sent;
Instead you should place your content in a public tree to be pulled.
___ You have too many commits attached to an e-mail; resend as threaded
commits, or place in a public tree for a pull.
___ You have resent this content multiple times without a clear indication
of what has changed between each re-send.
___ You have failed to adequately and individually address all of the
comments and change requests that were proposed in the initial review.
___ You have a misconfigured ~/.hgrc file (i.e. username, email etc)
___ Your computer have a badly configured date and time; confusing the
the threaded patch review.
___ Your changes affect IPC mechanism, and you don't present any results
for in-service upgradability test.
___ Your changes affect user manual and documentation, your patch series
do not contain the patch that updates the Doxygen manual.
------------------------------------------------------------------------------
HPCC Systems Open Source Big Data Platform from LexisNexis Risk Solutions
Find What Matters Most in Your Big Data with HPCC Systems
Open Source. Fast. Scalable. Simple. Ideal for Dirty Data.
Leverages Graph Analysis for Fast Processing & Easy Data Exploration
http://p.sf.net/sfu/hpccsystems
_______________________________________________
Opensaf-devel mailing list
Opensaf-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/opensaf-devel
