Summary: PLM: add support for ATCA entity paths Review request for Trac Ticket(s): 881 Peer Reviewer(s): Mathi Pull request to: Mathi Affected branch(es): default Development branch:
-------------------------------- Impacted area Impact y/n -------------------------------- Docs n Build system n RPM/packaging n Configuration files n Startup scripts n SAF services y OpenSAF services n Core libraries n Samples n Tests n Other n Comments (indicate scope for each "y" above): --------------------------------------------- changeset 00bdfc09aa2fc605cdbc7f9a90d19de3e1c95853 Author: Alex Jones <[email protected]> Date: Fri, 20 Jun 2014 14:28:49 -0400 plm: add support for ATCA-specific entity paths [#881] Jun 20 14:17:18 linux-po6q osafplmd[20561]: ER epath_matched: 0, he_type_idr_matched: 0#011#011HE. ent_path: SHELF_MANAGER.0,UNSPECIFIED.1,ADVANCEDTCA_CHASSIS.7,ROOT.0 Jun 20 14:17:18 linux-po6q osafplmd[20561]: ER HE SHELF_MANAGER.0,UNSPECIFIED.1,ADVANCEDTCA_CHASSIS.7,ROOT.0 verification FAILED. Jun 20 14:17:18 linux-po6q osafclmna[20582]: NO safNode=SC-2,safCluster=Q50clmCluster Joined cluster, nodeid=2020f Jun 20 14:17:18 linux-po6q osafplmd[20561]: ER epath_matched: 0, he_type_idr_matched: 0#011#011HE. ent_path: SHELF_MANAGER.0,UNSPECIFIED.2,ADVANCEDTCA_CHASSIS.7,ROOT.0 Jun 20 14:17:18 linux-po6q osafplmd[20561]: ER HE SHELF_MANAGER.0,UNSPECIFIED.2,ADVANCEDTCA_CHASSIS.7,ROOT.0 verification FAILED. PLM does not support entity paths with CHASSIS_SPECIFIC01 - CHASSIS_SPECIFIC13 in them. So, any entity with CHASSIS_SPECIFICxx in it, cannot be modeled as an HE. The real entity path from the above log message is SHELF_MANAGER.0,CHASSIS_SPECIFIC03.1,ADVANCEDTCA_CHASSIS.7,ROOT.0. CHASSIS_SPECIFIC03 is the XTCAHPI_ENT_SHELF_MANAGER_SLOT in ATCA. UNSPECIFIED should never be seen. Add the support for CHASSIS_SPECIFIC01 - CHASSIS_SPECIFIC13, so that ATCA entities can be recognized and modeled as HEs. Complete diffstat: ------------------ osaf/services/saf/plmsv/plms/hpi_intf/plms_epath_util.c | 32 +++++++++++++--- 1 files changed, 26 insertions(+), 6 deletions(-) Testing Commands: ----------------- (1) Model an HE with CHASSIS_SPECIFIC01 - 13 in the entity path (this needs to be in your HPI data as well.) (2) Bring up opensaf with PLM enabled. Testing, Expected Results: -------------------------- You should not see "UNSPECIFIED" in any path in /var/log/messages output. Conditions of Submission: ------------------------- Arch Built Started Linux distro ------------------------------------------- mips n n mips64 n n x86 n n x86_64 y y powerpc n n powerpc64 n n Reviewer Checklist: ------------------- [Submitters: make sure that your review doesn't trigger any checkmarks!] Your checkin has not passed review because (see checked entries): ___ Your RR template is generally incomplete; it has too many blank entries that need proper data filled in. ___ You have failed to nominate the proper persons for review and push. ___ Your patches do not have proper short+long header ___ You have grammar/spelling in your header that is unacceptable. ___ You have exceeded a sensible line length in your headers/comments/text. ___ You have failed to put in a proper Trac Ticket # into your commits. ___ You have incorrectly put/left internal data in your comments/files (i.e. internal bug tracking tool IDs, product names etc) ___ You have not given any evidence of testing beyond basic build tests. Demonstrate some level of runtime or other sanity testing. ___ You have ^M present in some of your files. These have to be removed. ___ You have needlessly changed whitespace or added whitespace crimes like trailing spaces, or spaces before tabs. ___ You have mixed real technical changes with whitespace and other cosmetic code cleanup changes. These have to be separate commits. ___ You need to refactor your submission into logical chunks; there is too much content into a single commit. ___ You have extraneous garbage in your review (merge commits etc) ___ You have giant attachments which should never have been sent; Instead you should place your content in a public tree to be pulled. ___ You have too many commits attached to an e-mail; resend as threaded commits, or place in a public tree for a pull. ___ You have resent this content multiple times without a clear indication of what has changed between each re-send. ___ You have failed to adequately and individually address all of the comments and change requests that were proposed in the initial review. ___ You have a misconfigured ~/.hgrc file (i.e. username, email etc) ___ Your computer have a badly configured date and time; confusing the the threaded patch review. ___ Your changes affect IPC mechanism, and you don't present any results for in-service upgradability test. ___ Your changes affect user manual and documentation, your patch series do not contain the patch that updates the Doxygen manual. ------------------------------------------------------------------------------ HPCC Systems Open Source Big Data Platform from LexisNexis Risk Solutions Find What Matters Most in Your Big Data with HPCC Systems Open Source. Fast. Scalable. Simple. Ideal for Dirty Data. Leverages Graph Analysis for Fast Processing & Easy Data Exploration http://p.sf.net/sfu/hpccsystems _______________________________________________ Opensaf-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/opensaf-devel
