Summary: log: fix validation and error handling for SaNameT Review request for Trac Ticket(s): #891 Peer Reviewer(s): [email protected] Pull request to: <<LIST THE PERSON WITH PUSH ACCESS HERE>> Affected branch(es): 4.3, 4.4, 4.5 Development branch: <<IF ANY GIVE THE REPO URL>>
-------------------------------- Impacted area Impact y/n -------------------------------- Docs n Build system n RPM/packaging n Configuration files n Startup scripts n SAF services y OpenSAF services n Core libraries n Samples n Tests n Other n Comments (indicate scope for each "y" above): --------------------------------------------- <<EXPLAIN/COMMENT THE PATCH SERIES HERE>> changeset fd83bad2c5e316f9586252d8f87f7633672cc4b7 Author: Lennart Lund <[email protected]> Date: Mon, 23 Jun 2014 09:39:10 +0200 log: Fix validation of SaNameT length in agent [#891] Fix the LOG API to check if SaNameT length >= 256 instead of > 256. changeset a2d0eb290763cb6ebe245a5c46137c3571450f65 Author: Lennart Lund <[email protected]> Date: Mon, 23 Jun 2014 10:41:12 +0200 log: Fix server error handling if SaNameT length is 256 or bigger [#891] Implement error handling if SaNameT length is 256 or bigger. The server shall not crach changeset 8cccfd892a975d7ceb195d0cc0f86ccde48c3373 Author: Lennart Lund <[email protected]> Date: Mon, 23 Jun 2014 10:41:17 +0200 log: New testcases for testing max length handling og SaNameT [#891] Add testcases for testing SaNameT with length 256 Complete diffstat: ------------------ osaf/libs/agents/saf/lga/lga_api.c | 29 +++++++- osaf/services/saf/logsv/lgs/lgs_evt.c | 2 +- osaf/services/saf/logsv/lgs/lgs_mds.c | 265 +++++++++++++++++++++++++++++++++++++++++++++++++++----------------------------------- 3 files changed, 180 insertions(+), 116 deletions(-) Testing Commands: ----------------- New test cases added to test section 2; 22, 39, 40 and 41 for testing length of SaNameT. a. With all patches applied: # logtest b. Without patch "log: Fix validation of SaNameT length in agent [#891]" This will test that the log server does not crach if length is set to an invalid value (>= 256) # logtest 2 Testing, Expected Results: -------------------------- a. All tests shall pass, including the new ones. b. ... 22 FAILED Open with stream name length == 256 (expected SA_AIS_ERR_INVALID_PARAM, got SA_AIS_ERR_TRY_AGAIN) ... 38 PASSED saLogWriteAsyncLog() invalid severity Waiting for log write callback Poll timeout 39 PASSED saLogWriteAsyncLog() NTF notificationObject length == 256 Waiting for log write callback Poll timeout 40 PASSED saLogWriteAsyncLog() NTF notifyingObject length == 256 Waiting for log write callback Poll timeout 41 PASSED saLogWriteLogAsync() Generic logSvcUsrName length == 256 ... All other tests shall pass Conditions of Submission: ------------------------- <<HOW MANY DAYS BEFORE PUSHING, CONSENSUS ETC>> Arch Built Started Linux distro ------------------------------------------- mips n n mips64 n n x86 n n x86_64 n n powerpc n n powerpc64 n n Reviewer Checklist: ------------------- [Submitters: make sure that your review doesn't trigger any checkmarks!] Your checkin has not passed review because (see checked entries): ___ Your RR template is generally incomplete; it has too many blank entries that need proper data filled in. ___ You have failed to nominate the proper persons for review and push. ___ Your patches do not have proper short+long header ___ You have grammar/spelling in your header that is unacceptable. ___ You have exceeded a sensible line length in your headers/comments/text. ___ You have failed to put in a proper Trac Ticket # into your commits. ___ You have incorrectly put/left internal data in your comments/files (i.e. internal bug tracking tool IDs, product names etc) ___ You have not given any evidence of testing beyond basic build tests. Demonstrate some level of runtime or other sanity testing. ___ You have ^M present in some of your files. These have to be removed. ___ You have needlessly changed whitespace or added whitespace crimes like trailing spaces, or spaces before tabs. ___ You have mixed real technical changes with whitespace and other cosmetic code cleanup changes. These have to be separate commits. ___ You need to refactor your submission into logical chunks; there is too much content into a single commit. ___ You have extraneous garbage in your review (merge commits etc) ___ You have giant attachments which should never have been sent; Instead you should place your content in a public tree to be pulled. ___ You have too many commits attached to an e-mail; resend as threaded commits, or place in a public tree for a pull. ___ You have resent this content multiple times without a clear indication of what has changed between each re-send. ___ You have failed to adequately and individually address all of the comments and change requests that were proposed in the initial review. ___ You have a misconfigured ~/.hgrc file (i.e. username, email etc) ___ Your computer have a badly configured date and time; confusing the the threaded patch review. ___ Your changes affect IPC mechanism, and you don't present any results for in-service upgradability test. ___ Your changes affect user manual and documentation, your patch series do not contain the patch that updates the Doxygen manual. ------------------------------------------------------------------------------ HPCC Systems Open Source Big Data Platform from LexisNexis Risk Solutions Find What Matters Most in Your Big Data with HPCC Systems Open Source. Fast. Scalable. Simple. Ideal for Dirty Data. Leverages Graph Analysis for Fast Processing & Easy Data Exploration http://p.sf.net/sfu/hpccsystems _______________________________________________ Opensaf-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/opensaf-devel
