Summary: Special precedence config object/env variables for overload limits Review request for Trac Ticket(s): #941 Peer Reviewer(s): [email protected] Pull request to: <<LIST THE PERSON WITH PUSH ACCESS HERE>> Affected branch(es): 4.3, 4.4, 4.5 Development branch: <<IF ANY GIVE THE REPO URL>>
-------------------------------- Impacted area Impact y/n -------------------------------- Docs n Build system n RPM/packaging n Configuration files n Startup scripts n SAF services y OpenSAF services n Core libraries n Samples n Tests n Other n Comments (indicate scope for each "y" above): --------------------------------------------- <<EXPLAIN/COMMENT THE PATCH SERIES HERE>> changeset 1580798004ef966fecd98411f8de12c422b28b75 Author: Lennart Lund <[email protected]> Date: Tue, 24 Jun 2014 15:16:20 +0200 log: For overload limits use environment variable value if limit in config object is 0 [#941] Write configuration to syslog Complete diffstat: ------------------ osaf/services/saf/logsv/README | 28 ++++++++++++++++++++++- osaf/services/saf/logsv/lgs/lgs_imm.c | 106 +++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++--------------------- 2 files changed, 107 insertions(+), 27 deletions(-) Testing Commands: ----------------- Testdescription below assumes UML environment a. Add the following environment variables to the logd.conf file and do ./build_uml export LOG_STREAM_SYSTEM_HIGH_LIMIT=50000 export LOG_STREAM_SYSTEM_LOW_LIMIT=5000 export LOG_STREAM_APP_HIGH_LIMIT=40000 export LOG_STREAM_APP_LOW_LIMIT=4000 Start the cluster (./opensaf start 2) b. Test with one or more of the environment variables commented out c. Change the corresponding attributes in the configuration object to a non zero value Can be done in the logsv_classes.xml file. <attr> <name>logStreamSystemHighLimit</name> <type>SA_UINT32_T</type> <category>SA_CONFIG</category> <flag>SA_WRITABLE</flag> <default-value>50001</default-value> </attr> <attr> <name>logStreamSystemLowLimit</name> <type>SA_UINT32_T</type> <category>SA_CONFIG</category> <flag>SA_WRITABLE</flag> <default-value>5001</default-value> </attr> <attr> <name>logStreamAppHighLimit</name> <type>SA_UINT32_T</type> <category>SA_CONFIG</category> <flag>SA_WRITABLE</flag> <default-value>50002</default-value> </attr> <attr> <name>logStreamAppLowLimit</name> <type>SA_UINT32_T</type> <category>SA_CONFIG</category> <flag>SA_WRITABLE</flag> <default-value>5002</default-value> </attr> d. Test with one or more of the values set to 0 Testing, Expected Results: -------------------------- a. The following shall be logged in the syslog (messages) ...osaflogd[409]: NO Log config sys: hi 50000 lo 5000, app: hi 40000 lo 4000 b. Same as above but the value for commented out variables shall be 0 c. The non zero value in the configuration object shall precedence the corresponding environment variable. A warning that the environment variable is not used shall be logged (for each variable). Example: ...WA Log Configuration object 'logConfig=1,safApp=safLogService' exists ...WA Ignoring environment variable LOG_STREAM_SYSTEM_HIGH_LIMIT . . . ...osaflogd[409]: NO Log config sys: hi 50001 lo 5001, app: hi 50002 lo 5002 d. Value in environment variable shall be used for attributes that has 0 as value Conditions of Submission: ------------------------- <<HOW MANY DAYS BEFORE PUSHING, CONSENSUS ETC>> Arch Built Started Linux distro ------------------------------------------- mips n n mips64 n n x86 n n x86_64 n n powerpc n n powerpc64 n n Reviewer Checklist: ------------------- [Submitters: make sure that your review doesn't trigger any checkmarks!] Your checkin has not passed review because (see checked entries): ___ Your RR template is generally incomplete; it has too many blank entries that need proper data filled in. ___ You have failed to nominate the proper persons for review and push. ___ Your patches do not have proper short+long header ___ You have grammar/spelling in your header that is unacceptable. ___ You have exceeded a sensible line length in your headers/comments/text. ___ You have failed to put in a proper Trac Ticket # into your commits. ___ You have incorrectly put/left internal data in your comments/files (i.e. internal bug tracking tool IDs, product names etc) ___ You have not given any evidence of testing beyond basic build tests. Demonstrate some level of runtime or other sanity testing. ___ You have ^M present in some of your files. These have to be removed. ___ You have needlessly changed whitespace or added whitespace crimes like trailing spaces, or spaces before tabs. ___ You have mixed real technical changes with whitespace and other cosmetic code cleanup changes. These have to be separate commits. ___ You need to refactor your submission into logical chunks; there is too much content into a single commit. ___ You have extraneous garbage in your review (merge commits etc) ___ You have giant attachments which should never have been sent; Instead you should place your content in a public tree to be pulled. ___ You have too many commits attached to an e-mail; resend as threaded commits, or place in a public tree for a pull. ___ You have resent this content multiple times without a clear indication of what has changed between each re-send. ___ You have failed to adequately and individually address all of the comments and change requests that were proposed in the initial review. ___ You have a misconfigured ~/.hgrc file (i.e. username, email etc) ___ Your computer have a badly configured date and time; confusing the the threaded patch review. ___ Your changes affect IPC mechanism, and you don't present any results for in-service upgradability test. ___ Your changes affect user manual and documentation, your patch series do not contain the patch that updates the Doxygen manual. ------------------------------------------------------------------------------ Open source business process management suite built on Java and Eclipse Turn processes into business applications with Bonita BPM Community Edition Quickly connect people, data, and systems into organized workflows Winner of BOSSIE, CODIE, OW2 and Gartner awards http://p.sf.net/sfu/Bonitasoft _______________________________________________ Opensaf-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/opensaf-devel
