Summary: Support creation of UNLOCKED SUs Review request for Trac Ticket(s): 911 Peer Reviewer(s): AMF devels Pull request to: <<LIST THE PERSON WITH PUSH ACCESS HERE>> Affected branch(es): default Development branch: <<IF ANY GIVE THE REPO URL>>
-------------------------------- Impacted area Impact y/n -------------------------------- Docs n Build system n RPM/packaging n Configuration files n Startup scripts n SAF services y OpenSAF services n Core libraries n Samples n Tests n Other n Comments (indicate scope for each "y" above): --------------------------------------------- changeset d7da8b50aeaf1b507003617faa57d71692451705 Author: Hans Feldt <[email protected]> Date: Mon, 30 Jun 2014 10:50:06 +0200 amfd: allow creation of UNLOCKED service units [#911] Allow creation of UNLOCKED SUs if the parent SG is LOCKED-IN or the hosting node is LOCKED-IN Complete diffstat: ------------------ osaf/services/saf/amf/amfd/su.cc | 158 +++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++--------------- 1 files changed, 143 insertions(+), 15 deletions(-) Testing Commands: ----------------- Build and start opensaf (single is enough) 1) Load unmodifed AppConfig-2N.xml (except for removing SC-2 ref) Restart opensaf 2) Load AppConfig-2N.xml with unlocked SUs, either tag removed or set to 1 (UNLOCKED) adm lock-in node 3) Load same AppConfig-2N.xml again 4) unlock-in/unlock node restart opensaf modify AppConfig-2N.xml to have SG locked-in 5) Load AppConfig-2N.xml 6) unlock-in/unlock SG Testing, Expected Results: -------------------------- test case works, suitable error logs when validation fails Conditions of Submission: ------------------------- Ack from Praveen Arch Built Started Linux distro ------------------------------------------- mips n n mips64 n n x86 n n x86_64 y y ubuntu14.04 powerpc n n powerpc64 n n Reviewer Checklist: ------------------- [Submitters: make sure that your review doesn't trigger any checkmarks!] Your checkin has not passed review because (see checked entries): ___ Your RR template is generally incomplete; it has too many blank entries that need proper data filled in. ___ You have failed to nominate the proper persons for review and push. ___ Your patches do not have proper short+long header ___ You have grammar/spelling in your header that is unacceptable. ___ You have exceeded a sensible line length in your headers/comments/text. ___ You have failed to put in a proper Trac Ticket # into your commits. ___ You have incorrectly put/left internal data in your comments/files (i.e. internal bug tracking tool IDs, product names etc) ___ You have not given any evidence of testing beyond basic build tests. Demonstrate some level of runtime or other sanity testing. ___ You have ^M present in some of your files. These have to be removed. ___ You have needlessly changed whitespace or added whitespace crimes like trailing spaces, or spaces before tabs. ___ You have mixed real technical changes with whitespace and other cosmetic code cleanup changes. These have to be separate commits. ___ You need to refactor your submission into logical chunks; there is too much content into a single commit. ___ You have extraneous garbage in your review (merge commits etc) ___ You have giant attachments which should never have been sent; Instead you should place your content in a public tree to be pulled. ___ You have too many commits attached to an e-mail; resend as threaded commits, or place in a public tree for a pull. ___ You have resent this content multiple times without a clear indication of what has changed between each re-send. ___ You have failed to adequately and individually address all of the comments and change requests that were proposed in the initial review. ___ You have a misconfigured ~/.hgrc file (i.e. username, email etc) ___ Your computer have a badly configured date and time; confusing the the threaded patch review. ___ Your changes affect IPC mechanism, and you don't present any results for in-service upgradability test. ___ Your changes affect user manual and documentation, your patch series do not contain the patch that updates the Doxygen manual. ------------------------------------------------------------------------------ Open source business process management suite built on Java and Eclipse Turn processes into business applications with Bonita BPM Community Edition Quickly connect people, data, and systems into organized workflows Winner of BOSSIE, CODIE, OW2 and Gartner awards http://p.sf.net/sfu/Bonitasoft _______________________________________________ Opensaf-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/opensaf-devel
